<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/assets/javascripts, branch issue_18656</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Load issues and merge requests templates from repository</title>
<updated>2016-08-16T18:43:21+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2016-06-24T19:43:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4687c341a74a34174284425ca0d368b36a03d5da'/>
<id>4687c341a74a34174284425ca0d368b36a03d5da</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Updated failing tests</title>
<updated>2016-08-13T05:57:40+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-08-12T09:10:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=61bdc80dbad253f6532a83ae2554de82deb40e5f'/>
<id>61bdc80dbad253f6532a83ae2554de82deb40e5f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename `markdown_preview` routes to `preview_markdown`</title>
<updated>2016-08-11T13:54:18+00:00</updated>
<author>
<name>Christopher Bartz</name>
<email>bartz@dkrz.de</email>
</author>
<published>2016-04-13T12:17:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ecb3f1eb6c87ab40108a5d71a3287a205ab6fefb'/>
<id>ecb3f1eb6c87ab40108a5d71a3287a205ab6fefb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-thumbs-award-loading-toggle' into 'master'</title>
<updated>2016-08-10T23:59:38+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-08-10T23:59:38+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=928edde2e6af7689b42453998bd2d129a352877d'/>
<id>928edde2e6af7689b42453998bd2d129a352877d</id>
<content type='text'>

Fix awardable button mutuality loading spinners

## What does this MR do?
Removes the showing and hiding of loading spinners when an awardable's opposite button is selected. 

## Are there points in the code the reviewer needs to double check?
Shouldn't be

## Why was this MR needed?
Makes the UI more consistent. Reduces confusion of why another button is showing the loading spinner when it was not clicked on.

## What are the relevant issue numbers?
Closes #18380 

## Screenshots (if relevant)
Before:
![loading](/uploads/d4c4e565fa58fbbf3db6ed8e28f9abb0/loading.gif)

After:
![CcwRYZcUVm](/uploads/b93fd04853f43a6c70de3cefb20d08a1/CcwRYZcUVm.gif)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5745</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix awardable button mutuality loading spinners

## What does this MR do?
Removes the showing and hiding of loading spinners when an awardable's opposite button is selected. 

## Are there points in the code the reviewer needs to double check?
Shouldn't be

## Why was this MR needed?
Makes the UI more consistent. Reduces confusion of why another button is showing the loading spinner when it was not clicked on.

## What are the relevant issue numbers?
Closes #18380 

## Screenshots (if relevant)
Before:
![loading](/uploads/d4c4e565fa58fbbf3db6ed8e28f9abb0/loading.gif)

After:
![CcwRYZcUVm](/uploads/b93fd04853f43a6c70de3cefb20d08a1/CcwRYZcUVm.gif)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5745</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'cs-remove-inline-js' into 'master'</title>
<updated>2016-08-10T22:11:06+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-08-10T22:11:06+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=279c61f3cbe79f37578ff4366adfc55a63cc5b5b'/>
<id>279c61f3cbe79f37578ff4366adfc55a63cc5b5b</id>
<content type='text'>

Remove two simple instances of inline JavaScript.

Not very complicated, they're moved to the dispatcher.

See merge request !5513</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Remove two simple instances of inline JavaScript.

Not very complicated, they're moved to the dispatcher.

See merge request !5513</pre>
</div>
</content>
</entry>
<entry>
<title>Fix awardable button mutuality loading spinners</title>
<updated>2016-08-10T21:29:11+00:00</updated>
<author>
<name>Clement Ho</name>
<email>ClemMakesApps@gmail.com</email>
</author>
<published>2016-08-09T20:54:58+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e3292f1ede67891feddfd896f16cfe42d3851558'/>
<id>e3292f1ede67891feddfd896f16cfe42d3851558</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'branch-permissions' into 'master'</title>
<updated>2016-08-08T13:38:04+00:00</updated>
<author>
<name>Jacob Schatz</name>
<email>jschatz@gitlab.com</email>
</author>
<published>2016-08-08T13:38:04+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b767d8688511d7fdb9487e96c18eb62788fd629b'/>
<id>b767d8688511d7fdb9487e96c18eb62788fd629b</id>
<content type='text'>

Branch permissions layout

CE part of https://gitlab.com/gitlab-org/gitlab-ee/issues/179

Related javascript code has been refactored and also layout has been updated.

![Screen_Shot_2016-08-04_at_3.23.19_PM](/uploads/a0f6165e255b3f93dcb80eaa3f3318e4/Screen_Shot_2016-08-04_at_3.23.19_PM.png)


See merge request !5652</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Branch permissions layout

CE part of https://gitlab.com/gitlab-org/gitlab-ee/issues/179

Related javascript code has been refactored and also layout has been updated.

![Screen_Shot_2016-08-04_at_3.23.19_PM](/uploads/a0f6165e255b3f93dcb80eaa3f3318e4/Screen_Shot_2016-08-04_at_3.23.19_PM.png)


See merge request !5652</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'backport-user-select-fix' into 'master'</title>
<updated>2016-08-08T10:07:18+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-08-08T10:07:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0ead7c9142c1058d3930463c623b242bba815c80'/>
<id>0ead7c9142c1058d3930463c623b242bba815c80</id>
<content type='text'>

fix: respect data-attribute 'skip-users' in user_selects

Backport https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/604 to CE, so that JS file is the same in both versions. Thanks @hwdegroot!

No CHANGELOG needed because this code path isn't used anywhere in CE at the moment.

See merge request !5685</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

fix: respect data-attribute 'skip-users' in user_selects

Backport https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/604 to CE, so that JS file is the same in both versions. Thanks @hwdegroot!

No CHANGELOG needed because this code path isn't used anywhere in CE at the moment.

See merge request !5685</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure we are looking for the right dropdown inside the form wrapper</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-05T22:09:21+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=26c1b72d8f63d1ef24738d5df43d2dfe9cb2cf68'/>
<id>26c1b72d8f63d1ef24738d5df43d2dfe9cb2cf68</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Set for for labels and ID for dropdowns on create form</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-05T22:04:10+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f096cc0471267e2aee289b9b60212d5cb5d259af'/>
<id>f096cc0471267e2aee289b9b60212d5cb5d259af</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
