<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/autocomplete_controller.rb, branch dm-diff-file-diffable</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add per page to user autocomplete</title>
<updated>2017-05-26T17:59:00+00:00</updated>
<author>
<name>Clement Ho</name>
<email>ClemMakesApps@gmail.com</email>
</author>
<published>2017-05-26T17:59:00+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2339bef1bcf77da258b2e07528122ad7a3a48407'/>
<id>2339bef1bcf77da258b2e07528122ad7a3a48407</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable the Style/TrailingCommaInLiteral cop</title>
<updated>2017-05-10T16:25:45+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-05-03T11:22:03+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d40e1f547ea9e31e822229bb808aaa6b9201f473'/>
<id>d40e1f547ea9e31e822229bb808aaa6b9201f473</id>
<content type='text'>
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix autocomplete in EE when permissions are sent</title>
<updated>2017-03-10T11:41:44+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-03-10T11:13:57+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c0f6c856de37b022f5a429b50a1784cf374c45f'/>
<id>5c0f6c856de37b022f5a429b50a1784cf374c45f</id>
<content type='text'>
In EE, `@users` can be an array at the point where we remove the current
user, because it can do a permissions check on the users for project
mirroring.

Fix this in CE by only using array methods, not AR methods. We can't use
`delete` because that uses `Object#equal?`, which isn't true in this
case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In EE, `@users` can be an array at the point where we remove the current
user, because it can do a permissions check on the users for project
mirroring.

Fix this in CE by only using array methods, not AR methods. We can't use
`delete` because that uses `Object#equal?`, which isn't true in this
case.
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't call `#uniq` on a relation</title>
<updated>2017-01-27T15:28:17+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-01-25T14:44:44+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2c40a012d63784d1ad91a3629cb1e66ca9ffa96a'/>
<id>2c40a012d63784d1ad91a3629cb1e66ca9ffa96a</id>
<content type='text'>
When there was no project, no search, and no current user or author
param, the AutocompleteController would call `#uniq!` on a relation
instead of an array. This performed the less-efficient `SELECT DISTINCT`
when it wasn't even needed (because the query wouldn't return duplicates
anyway - duplicates were only added by putting a user on top of the
list).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When there was no project, no search, and no current user or author
param, the AutocompleteController would call `#uniq!` on a relation
instead of an array. This performed the less-efficient `SELECT DISTINCT`
when it wasn't even needed (because the query wouldn't return duplicates
anyway - duplicates were only added by putting a user on top of the
list).
</pre>
</div>
</content>
</entry>
<entry>
<title>Shows current user on top of filtered dropdown list</title>
<updated>2017-01-17T15:22:48+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2017-01-17T15:22:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=92682b8ae1ee0620916bdebfe3194967ce1eb2e7'/>
<id>92682b8ae1ee0620916bdebfe3194967ce1eb2e7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Do not raise error in AutocompleteController#users when not authorized</title>
<updated>2016-11-30T05:09:14+00:00</updated>
<author>
<name>Semyon Pupkov</name>
<email>mail@semyonpupkov.com</email>
</author>
<published>2016-11-29T09:49:43+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f5e8337c7bb7e218303a713440e31f44a66471d7'/>
<id>f5e8337c7bb7e218303a713440e31f44a66471d7</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/issues/25031
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/issues/25031
</pre>
</div>
</content>
</entry>
<entry>
<title>Improved Ruby code in autocomplete user search</title>
<updated>2016-11-18T16:10:48+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-11-18T16:10:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=17ac0fd53dbd1e9b330821bee3b03c0c537d9e1e'/>
<id>17ac0fd53dbd1e9b330821bee3b03c0c537d9e1e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Include author in assignee dropdown search</title>
<updated>2016-11-17T11:13:39+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-11-17T11:13:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=80073da95771fc51a4ac05814b0a7ceae1cbdac9'/>
<id>80073da95771fc51a4ac05814b0a7ceae1cbdac9</id>
<content type='text'>
When searching for the author in the assignee dropdown it now correctly returns the user

Closes #22905
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When searching for the author in the assignee dropdown it now correctly returns the user

Closes #22905
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix: Todos Filter Shows All Users</title>
<updated>2016-11-04T11:41:14+00:00</updated>
<author>
<name>Valery Sizov</name>
<email>valery@gitlab.com</email>
</author>
<published>2016-11-03T10:22:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b7dff1b072204c8c2ad480301b3139e4823c41f4'/>
<id>b7dff1b072204c8c2ad480301b3139e4823c41f4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move to project dropdown with infinite scroll for better performance</title>
<updated>2016-08-17T05:33:51+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-08-05T13:29:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=03386633a42bd56b0b0b31b70eebaaaa33e1494e'/>
<id>03386633a42bd56b0b0b31b70eebaaaa33e1494e</id>
<content type='text'>
Use just SQL to check is a user can admin_issue on a project

Tradeoff

- we duplicate how we check admin_issue in a SQL relation in the Ability class
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use just SQL to check is a user can admin_issue on a project

Tradeoff

- we duplicate how we check admin_issue in a SQL relation in the Ability class
</pre>
</div>
</content>
</entry>
</feed>
