delta/gitlab/gitlab-ce.git/app/controllers/help_controller.rb, branch feature/github-edit-path gitlab.com: gitlab-org/gitlab-ce.git Replace reject_blocked with reject_blocked! in callbacks. 2016-07-27T19:56:30+00:00 Connor Shea connor.james.shea@gmail.com 2016-07-27T19:43:29+00:00 b1c94754436e4c15529276a61d601f72bb53c2b2 In Rails 4.2 and below, skipping callbacks (skip_before_action, skip_after_action, etc.) that use methods which do not exist will not throw any errors. On the other hand, Rails 5 does. See https://github.com/rails/rails/pull/19029 After testing with Rails 5 I noticed there are some methods that don't actually exist (because they were renamed, usually), this fixes a few instances of those. reject_blocked! was introduced in c9def945d4222eeb8026a0311495259bf99267a1, I can't find any references to reject_blocked ever existing. 
In Rails 4.2 and below, skipping callbacks (skip_before_action, skip_after_action, etc.) that use methods which do not exist will not throw any errors.

On the other hand, Rails 5 does. See https://github.com/rails/rails/pull/19029

After testing with Rails 5 I noticed there are some methods that don't actually exist (because they were renamed, usually), this fixes a few instances of those.

reject_blocked! was introduced in c9def945d4222eeb8026a0311495259bf99267a1, I can't find any references to reject_blocked ever existing.
Remove VideoJS and clean the integration 2016-07-20T09:36:42+00:00 Rémy Coutable remy@rymai.me 2016-07-12T17:28:39+00:00 6b7e9c7655e4ffc74de90f01a0850a230b10a03c Handle videos in: - MD preview in notes: commit, issue/MR, MR diff - New notes in: commit, issue/MR, MR diff - Persisted notes in: commit, issue/MR, MR diff Signed-off-by: Rémy Coutable <remy@rymai.me> 
Handle videos in:
- MD preview in notes: commit, issue/MR, MR diff
- New notes in: commit, issue/MR, MR diff
- Persisted notes in: commit, issue/MR, MR diff

Signed-off-by: Rémy Coutable <remy@rymai.me>
Clean path info 2016-07-11T19:12:55+00:00 Connor Shea connor.james.shea@gmail.com 2016-07-11T19:12:55+00:00 bd09b2d563d7190ab26f820401e4d981022022c8 






Update the help_page_path route to accept paths directly instead of using parameters.
2016-07-11T18:55:25+00:00

Connor Shea
connor.james.shea@gmail.com

2016-05-16T22:06:26+00:00

3358afa758c7db96ea8fce2a10cdf9c0abe85216












Simplify random user generation.
2016-04-16T20:00:30+00:00

Jacob Schatz
jacobschatz@Jacobs-MBP.fios-router.home

2016-04-16T20:00:30+00:00

e79b0dd762719828203bd48c253a88d876bcf61a












Make a user available for the user variable
2016-04-16T13:28:04+00:00

Jacob Schatz
jacobschatz@Jacobs-MBP.fios-router.home

2016-04-16T13:28:04+00:00

ffd2416c5636917c0da0a3376342d6c465bb1954












Simplify help path prefixing
2015-09-23T04:24:17+00:00

Robert Speicher
rspeicher@gmail.com

2015-09-23T04:24:17+00:00

95f73a68fa3ff235c35217b1c72666c5bad6ce03












Prevent double-prefixing of help page paths
2015-09-22T22:26:51+00:00

Robert Speicher
rspeicher@gmail.com

2015-09-22T22:26:51+00:00

64e0dfa5306aebdedeb65f2a6db95f4d2314f143

Prior, because the link "api/README.md" was matched twice, the first
link became "help/help/api/README.md". Now we do a negative lookahead to
make sure the link doesn't start with `help/`.

This fix is still not ideal, see TODO note.





Prior, because the link "api/README.md" was matched twice, the first
link became "help/help/api/README.md". Now we do a negative lookahead to
make sure the link doesn't start with `help/`.

This fix is still not ideal, see TODO note.







Make Help accessible for guests.
2015-09-08T13:42:30+00:00

Douwe Maan
douwe@gitlab.com

2015-09-08T13:42:30+00:00

c258e97747f13cdc60ca2765789213292099c87a












Use File.join instead of Rails.root.join in HelpController
2015-08-18T16:08:03+00:00

Robert Speicher
rspeicher@gmail.com

2015-08-18T16:08:03+00:00

a42c548a8d4cc9b8d8d3f50cc7593f0a92e3cfac