delta/gitlab/gitlab-ce.git/app/controllers/projects/branches_controller.rb, branch fix/serialized-commit-path

Merge branch 'jej-fix-missing-access-check-on-issues' into 'security'

2016-11-29T00:25:46+00:00

Fix missing access checks on issue lookup using IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :white_check_mark: app/controllers/projects/branches_controller.rb:39
  - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with
    confidential issues, issues only visible to team, etc.
- [x] :traffic_light: app/models/cycle_analytics/summary.rb:9 [`.count`]
- [x] :white_check_mark: app/controllers/projects/todos_controller.rb:19

- [x] Potential double render in app/controllers/projects/todos_controller.rb

- https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24

See merge request !2030

Add button to delete all merged branches

2016-11-09T20:04:03+00:00

It adds a button to the branches page that the user can use to delete
all the branches that are already merged. This can be used to clean up
all the branches that were forgotten to delete while merging MRs.

Fixes #21076.

Fix tests.

2016-08-17T15:23:43+00:00

Initial implementation of an async branch dropdown for Revert and Cherry Pick.

2016-08-17T15:23:43+00:00

Fix branches page dropdown sort initial state

2016-08-10T19:36:16+00:00

Fix the title of the toggle dropdown button

2016-07-28T15:20:57+00:00

Before when you choose the way of `sort` instead it display the title correctly it was just apply the humanize helper in sort value.

E.g.

When you choose `Last updated` it should display the title `Last updated` instead of `Recently updated`. This fix makes this correctly displays the title.

Change the implementation of the `link_to` `filter_branches_path`

- Change the value of the `params[:sort]` in `link_to`. E.g. instead of using `'recently_updated'` is now using `sort_value_recently_updated`.

- Change the values of the case in the `branches_sorted_by` method for the values it receives in the `params[:sort]` that are: `nil`, `'name'`, `'updated_desc'`, `'updated_asc'`.

implements the basic filter functionality

2016-07-19T18:30:10+00:00

Update tests to match new Code tab logic

2016-06-03T07:13:40+00:00

Signed-off-by: Dmitriy Zaporozhets

Put project Files and Commits tabs under Code tab

2016-06-03T07:13:40+00:00

Signed-off-by: Dmitriy Zaporozhets

Return status code 303 after a branch DELETE operation to avoid project deletion

2016-04-07T04:11:10+00:00

Closes #14994