delta/gitlab/gitlab-ce.git/app/controllers/projects/commits_controller.rb, branch fix/serialized-commit-path gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security' 2016-12-09T00:42:07+00:00 Douwe Maan douwe@gitlab.com 2016-11-29T13:47:43+00:00 f23b1cb453deea2659c0cb9e9047c72d859bbf9d Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested - [x] :bomb: app/finders/notes_finder.rb:17 - [x] :warning: app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] :bomb: app/controllers/concerns/creates_commit.rb:84 - [x] :traffic_light: app/controllers/projects/commits_controller.rb:24 - [x] :traffic_light: app/controllers/projects/compare_controller.rb:56 - [x] :vertical_traffic_light: app/controllers/projects/discussions_controller.rb:29 - [x] :white_check_mark: app/controllers/projects/todos_controller.rb:27 - [x] :vertical_traffic_light: app/models/commit.rb:268 - [x] :white_check_mark: lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033 
Replace MR access checks with use of MergeRequestsFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :bomb:  app/finders/notes_finder.rb:17
- [x] :warning:  app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb:  app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light:  app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light:  app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light:  app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark:  app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light:  app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71

- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use  of unchecked `merged_merge_request?`

See merge request !2033
Pass `@ref` along so we know which pipeline to show 2016-10-24T14:26:06+00:00 Lin Jen-Shin godfat@godfat.org 2016-10-21T08:22:43+00:00 5416d0e0837f69f35a3a9deaf947fd62e5293661 Closes #23615 
Closes #23615
Refactoring find_commits functionality 2016-10-20T09:45:34+00:00 Valery Sizov valery@gitlab.com 2016-10-19T16:43:04+00:00 fd2c3a3da0302a474d7c1adbd409aedea2a41053 






API support for the 'since' and 'until' operators on commit requests
2016-04-29T07:26:52+00:00

Paco Guzman
pacoguzmanp@gmail.com

2016-04-22T12:07:25+00:00

c4b9bd041321df25764ad1de90f89b1f0dda9f33

- Parameter validation as ISO8601 format




- Parameter validation as ISO8601 format






Replaces "Create merge request" link with one to the MR when one exists
2016-02-10T12:32:25+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-02-01T23:43:51+00:00

1353cff5fed083fd7192dddff5062ac383b1f8a0












Add support for ref and path to commits filtering
2016-01-07T14:16:11+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-01-07T12:00:47+00:00

4443a5f3c76015f7bf083248b6910d01839cfc88

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







Filter commits by search parameter
2016-01-07T14:16:10+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-01-06T10:27:23+00:00

9a250ad6d85678d7f9197a55c69cb724c81008e0

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







Prevent an XSS warning from the updated Brakeman
2015-12-28T02:19:14+00:00

Robert Speicher
rspeicher@gmail.com

2015-12-28T02:19:14+00:00

1bda2e43a2f5ffdd4afa7ae73798ca4e36c0de9f












Fix: Inability to reply to code comments in the MR view, if the MR comes from a fork
2015-10-22T16:38:00+00:00

Valery Sizov
valery@gitlab.com

2015-10-22T16:38:00+00:00

95df86638d364a87469550cce852871634ace262












Fixed the Rails/ActionFilter cop
2015-04-20T13:39:37+00:00

Jeroen van Baarsen
jeroenvanbaarsen@gmail.com

2015-04-16T12:03:37+00:00

5a4ebfb47af40de6cfe29fe59dae82f8c244e5e3

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>





Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>