<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/helpers/diff_helper.rb, branch koding-setting-api</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Avoid commit lookup on diff_helper</title>
<updated>2016-08-10T11:09:07+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-08-10T09:28:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5689e8a0827eb9f09b071bbd4dc74dc2cb0a3e7d'/>
<id>5689e8a0827eb9f09b071bbd4dc74dc2cb0a3e7d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add unfold links for Side-by-Side view</title>
<updated>2016-08-04T06:09:59+00:00</updated>
<author>
<name>Tim Masliuchenko</name>
<email>insside@gmail.com</email>
</author>
<published>2016-07-21T18:44:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b6d545df51d7c3b4e572b40cdafb7efeb78edaf4'/>
<id>b6d545df51d7c3b4e572b40cdafb7efeb78edaf4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>switch from diff_file_collection to diffs</title>
<updated>2016-08-03T05:00:20+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-27T17:00:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c86c1905b5574cac234315598d8d715fcaee3ea7'/>
<id>c86c1905b5574cac234315598d8d715fcaee3ea7</id>
<content type='text'>
So we have raw_diffs too
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So we have raw_diffs too
</pre>
</div>
</content>
</entry>
<entry>
<title>Move to Gitlab::Diff::FileCollection</title>
<updated>2016-08-03T05:00:20+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-26T07:21:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8f359ea9170b984ad43d126e17628c31ac3a1f14'/>
<id>8f359ea9170b984ad43d126e17628c31ac3a1f14</id>
<content type='text'>
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection</pre>
</div>
</content>
</entry>
<entry>
<title>Cache highlighted diff lines for merge requests</title>
<updated>2016-08-03T05:00:19+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-20T16:25:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd7c2cb6ddd4d9c9f9bdae00c887c0022c121c17'/>
<id>cd7c2cb6ddd4d9c9f9bdae00c887c0022c121c17</id>
<content type='text'>
Introducing the concept of SafeDiffs which relates 
diffs with UI highlighting.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Introducing the concept of SafeDiffs which relates 
diffs with UI highlighting.</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'</title>
<updated>2016-07-29T15:58:09+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-07-29T15:58:09+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=34c083a184b98372b3b28a661d5cf41e0f2d8259'/>
<id>34c083a184b98372b3b28a661d5cf41e0f2d8259</id>
<content type='text'>

Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014</pre>
</div>
</content>
</entry>
<entry>
<title>Add Discussion model to represent MR/diff discussion</title>
<updated>2016-07-20T22:18:18+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2016-07-20T22:18:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=79214be727aaa0704a1be5b50aa6dd3011629bc2'/>
<id>79214be727aaa0704a1be5b50aa6dd3011629bc2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix some useless access modifiers in the code</title>
<updated>2016-07-19T12:16:54+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2016-06-30T12:41:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c0ebfea6baf330ed5ae5bc870407fe47f76119cf'/>
<id>c0ebfea6baf330ed5ae5bc870407fe47f76119cf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Collapsed diffs lines/size don't accumulate to overflow diffs.</title>
<updated>2016-07-18T20:43:28+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-15T07:04:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a404ab380db5959ab22b09bc586607b1f6c507cd'/>
<id>a404ab380db5959ab22b09bc586607b1f6c507cd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into faster-diffs</title>
<updated>2016-07-11T21:19:17+00:00</updated>
<author>
<name>Jacob Schatz</name>
<email>jschatz1@gmail.com</email>
</author>
<published>2016-07-11T21:19:17+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0452e0a57e24fdd65f559cc1a8629892714adc7a'/>
<id>0452e0a57e24fdd65f559cc1a8629892714adc7a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
