delta/gitlab/gitlab-ce.git/app/models/notification_recipient.rb, branch 35942_api_binary_encoding gitlab.com: gitlab-org/gitlab-ce.git don't rely on order of notification levels 2017-08-21T22:34:25+00:00 http://jneen.net/ jneen@jneen.net 2017-08-18T20:40:09+00:00 3676275a5a07492bb24a8b1925f7221c375a2f42 factor out #suitable_notification_level? and check manually by notification level. this makes the notification logic clear and actually reflect what is in the documentation as to what should happen with each setting. 
factor out #suitable_notification_level? and check manually by
notification level. this makes the notification logic clear and actually
reflect what is in the documentation as to what should happen with each
setting.
skip the :read_project check for new_project_member 2017-08-11T23:02:08+00:00 http://jneen.net/ jneen@jneen.net 2017-08-10T17:41:25+00:00 38737345abdf91ac2cb0b1cdff4eb7132b4104ee since we're just adding them as a member, the permission may still return false. 
since we're just adding them as a member, the permission may still
return false.
make NotificationRecipient a little more customizable 2017-08-11T23:02:01+00:00 http://jneen.net/ jneen@jneen.net 2017-08-04T18:53:17+00:00 7e7f602d29fef237b5531795bd5c38541d14ea14 






move the read_ability logic into NotificationRecipient
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-08-02T21:14:53+00:00

eaa503d679e3c2a1396091efebda49a91637cb02












use the accessor for `type`
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-08-01T18:42:59+00:00

e5496e1e8ef3fa82e6cefcababcb9ad3b55a11c3












fix comment
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-08-01T18:42:46+00:00

4af2c647132bee8b2ef87d0d190936449759071c












use safe navigation on notification_setting
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-08-01T18:42:24+00:00

444c8584491ce0efe2314747326da6ab7d17490c












short-circuit if there is no policy, and add :read_project check
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-08-01T17:42:54+00:00

c2dd4239c939e003dfe569196ec2d39e2478606e












style fixes
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-07-31T22:04:42+00:00

18288fe21e12bb524757a97472008eabfca5a352












don't require project
2017-08-03T16:07:18+00:00

http://jneen.net/
jneen@jneen.net

2017-07-31T18:32:17+00:00

e7d136ebdabf3f784412b859bf3ad7427c88e7f6

it's not there in the case of personal snippets, f. ex., and we've
already guarded against its being missing in #find_notification_setting





it's not there in the case of personal snippets, f. ex., and we've
already guarded against its being missing in #find_notification_setting