<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/snippet.rb, branch 35942_api_binary_encoding</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>`current_application_settings` belongs on `Gitlab::CurrentSettings`</title>
<updated>2017-08-31T12:38:33+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-08-31T09:47:03+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5883ce95efcc4cc04f949f9b4e66d73fbede94e2'/>
<id>5883ce95efcc4cc04f949f9b4e66d73fbede94e2</id>
<content type='text'>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</pre>
</div>
</content>
</entry>
<entry>
<title>Added Cop to blacklist the use of `dependent:`</title>
<updated>2017-07-06T10:01:36+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-06-08T15:16:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8fbbf41e29f5e0f56b7eb9d37aadba856b68bcce'/>
<id>8fbbf41e29f5e0f56b7eb9d37aadba856b68bcce</id>
<content type='text'>
This is allowed for existing instances so we don't end up 76 offenses
right away, but for new code one should _only_ use this if they _have_
to remove non database data. Even then it's usually better to do this in
a service class as this gives you more control over how to remove the
data (e.g. in bulk).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is allowed for existing instances so we don't end up 76 offenses
right away, but for new code one should _only_ use this if they _have_
to remove non database data. Even then it's usually better to do this in
a service class as this gives you more control over how to remove the
data (e.g. in bulk).
</pre>
</div>
</content>
</entry>
<entry>
<title>Removes file_name_regex from Gitlab::Regex</title>
<updated>2017-07-05T18:10:14+00:00</updated>
<author>
<name>Tiago Botelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2017-07-05T16:01:38+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1207d451ed934f3ce2d8c02130a8e6b2cac88a70'/>
<id>1207d451ed934f3ce2d8c02130a8e6b2cac88a70</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '12910-snippets-description' into 'master'</title>
<updated>2017-06-07T09:26:48+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2017-06-07T09:26:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=563ea34692a18d82d9d1bc481002f19b8a407508'/>
<id>563ea34692a18d82d9d1bc481002f19b8a407508</id>
<content type='text'>
Support descriptions for snippets

Closes #31894

See merge request !11071</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Support descriptions for snippets

Closes #31894

See merge request !11071</pre>
</div>
</content>
</entry>
<entry>
<title>Port fix-realtime-edited-text-for-issues 9-2-stable fix to master.</title>
<updated>2017-05-31T10:35:05+00:00</updated>
<author>
<name>Luke "Jared" Bennett</name>
<email>lbennett@gitlab.com</email>
</author>
<published>2017-05-18T12:24:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=07c984d81cd7985d4ab7597cbb21b5f623b438e9'/>
<id>07c984d81cd7985d4ab7597cbb21b5f623b438e9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Support descriptions for snippets</title>
<updated>2017-05-31T05:17:03+00:00</updated>
<author>
<name>Jarka Kadlecova</name>
<email>jarka@gitlab.com</email>
</author>
<published>2017-05-03T15:26:49+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4464c22d6d23d893494682d309aec3fb31c11ae3'/>
<id>4464c22d6d23d893494682d309aec3fb31c11ae3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'snippets-finder-visibility' into 'security'</title>
<updated>2017-05-10T14:48:18+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2017-04-28T22:06:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ad309f5d110ebf8859b2e7196c7a1d0b039c0d7c'/>
<id>ad309f5d110ebf8859b2e7196c7a1d0b039c0d7c</id>
<content type='text'>
Refactor snippets finder &amp; dont return internal snippets for external users

See merge request !2094
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Refactor snippets finder &amp; dont return internal snippets for external users

See merge request !2094
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix feature tests</title>
<updated>2017-05-04T03:54:25+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2017-05-04T03:54:25+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=154610c92bec0f94067ab88f35c5afdf6f10791d'/>
<id>154610c92bec0f94067ab88f35c5afdf6f10791d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use blob viewers for snippets</title>
<updated>2017-04-30T16:21:20+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-04-13T16:47:28+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=60ebd101d0fa3ddbfab86a676b81efba589f8393'/>
<id>60ebd101d0fa3ddbfab86a676b81efba589f8393</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add option to start a new discussion on an MR</title>
<updated>2017-04-05T16:44:14+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-03-10T01:29:11+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=08bbb9fce66cb46d3262e6cd4c4379b59f065be0'/>
<id>08bbb9fce66cb46d3262e6cd4c4379b59f065be0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
