delta/gitlab/gitlab-ce.git/app/views/devise, branch 25264-ref-commit gitlab.com: gitlab-org/gitlab-ce.git Un-un-revert signin tab order fix. 2016-11-18T20:40:18+00:00 Bryce Johnson bryce@gitlab.com 2016-11-17T19:14:56+00:00 0bd5370911aa21c76b5d7e39a484c6ac50d4200a 






Allow registering users where the username contains dots (.).
2016-11-18T06:17:37+00:00

Timothy Andrew
mail@timothyandrew.net

2016-11-16T12:24:43+00:00

78b6d6624be3a6d59710bf766e7253c2e6787f5a

Javascript does not support the negative lookbehind assertion (?<!) used
in the Ruby regex (to disallow usernames ending in `.git` or `.atom`.

Getting the client side code to fully support this format is
non-trivial, since we'd either have to heavily complicate the
regex used, or modify the frontend code to support more complex
validation schemes (it currently uses HTML5 validations).

The pragmatic choice is to create a
`Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a
Javascript-compatible version of `NAMESPACE_REGEX_STR`.

The client-side code will not display an error for usernames ending in
`.git` and `.atom`, but these will be caught by the server-side
validation.





Javascript does not support the negative lookbehind assertion (?<!) used
in the Ruby regex (to disallow usernames ending in `.git` or `.atom`.

Getting the client side code to fully support this format is
non-trivial, since we'd either have to heavily complicate the
regex used, or modify the frontend code to support more complex
validation schemes (it currently uses HTML5 validations).

The pragmatic choice is to create a
`Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a
Javascript-compatible version of `NAMESPACE_REGEX_STR`.

The client-side code will not display an error for usernames ending in
`.git` and `.atom`, but these will be caught by the server-side
validation.







Fix no "Register" tab if ldap auth is enabled (#24038)
2016-11-10T16:24:42+00:00

Luc Didry
luc@didry.org

2016-11-03T16:29:35+00:00

45c9d1e7bbc8d86a1a4f22dfd910dd7aacf42a1a

This commit is dedicated to GuilhemB, thanks for supporting me on Tipeee
:-)





This commit is dedicated to GuilhemB, thanks for supporting me on Tipeee
:-)







Change show-gl-field-errors to gl-show-field-errors
2016-11-02T10:35:21+00:00

Bryce Johnson
bryce@gitlab.com

2016-11-02T10:35:21+00:00

d939fbed0953be5e19308ec7dc7832cfd1d38160












Upgrade gl_field_errors to support more use cases.
2016-11-01T15:48:37+00:00

Bryce Johnson
bryce@gitlab.com

2016-10-21T11:49:09+00:00

93bd3dd8a8f587dc860c72653364d853c27bc6fd












Merge branch 'register-tab' into 'master'

2016-10-25T02:47:27+00:00

Jacob Schatz
jschatz@gitlab.com

2016-10-25T02:47:27+00:00

132e3f547194de1923db258d4022b7f473f176e0


Only show register tab if signup enabled.

## What does this MR do?

Fixes a regression where the register tab is activated, even if sign-up enabled is not activated in application_settings.

## Screenshots (if relevant)

When signup is disabled: 

![Screen_Shot_2016-10-22_at_8.56.23_PM](/uploads/bd0fa5f27114779c0d290a8151c1c253/Screen_Shot_2016-10-22_at_8.56.23_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/23654

See merge request !7058





Only show register tab if signup enabled.

## What does this MR do?

Fixes a regression where the register tab is activated, even if sign-up enabled is not activated in application_settings.

## Screenshots (if relevant)

When signup is disabled: 

![Screen_Shot_2016-10-22_at_8.56.23_PM](/uploads/bd0fa5f27114779c0d290a8151c1c253/Screen_Shot_2016-10-22_at_8.56.23_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/23654

See merge request !7058






Only show register tab if signup enabled.
2016-10-24T15:50:19+00:00

Bryce Johnson
bryce@gitlab.com

2016-10-22T18:50:24+00:00

413c012db83695753a5dbf7bb8541fb3a7248aa9












Merge branch 'master' into sign_in_forgot_password
2016-10-22T19:51:59+00:00

Bernardo Anderson
bernardodsanderson@gmail.com

2016-10-22T19:51:59+00:00

85062dfd258179021205ff9a22aa3a9d089de40b












Fix sign in page Forgot your password link overlap
2016-10-22T19:20:13+00:00

Bernardo Anderson
bernardodsanderson@gmail.com

2016-10-22T19:20:13+00:00

3b7ca69e530d684faf89a8dc1ea48c26eed5ccb7












Ensure custom provider tab labels don't break layout.
2016-10-20T19:57:34+00:00

Bryce Johnson
bryce@gitlab.com

2016-10-19T12:40:58+00:00

57046eb0abf280594d6625db3429f13d45499c83

(Also fix some issues for session views on small screens.)





(Also fix some issues for session views on small screens.)