<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/db, branch fix-codequality</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'rd-set-missing-fields-on-migration' into 'master'</title>
<updated>2018-11-02T13:26:03+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-11-02T13:26:03+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=74b5dce44aa902364d7ff3a3d8f6a1fcd857993d'/>
<id>74b5dce44aa902364d7ff3a3d8f6a1fcd857993d</id>
<content type='text'>
Fixes a migration that causes error on some legacy DBs

Closes #46862

See merge request gitlab-org/gitlab-ce!22761</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes a migration that causes error on some legacy DBs

Closes #46862

See merge request gitlab-org/gitlab-ce!22761</pre>
</div>
</content>
</entry>
<entry>
<title>Fixes a migration that causes error on some legacy DBs</title>
<updated>2018-11-01T23:34:15+00:00</updated>
<author>
<name>Rubén Dávila</name>
<email>ruben@gitlab.com</email>
</author>
<published>2018-11-01T23:34:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d32a571acbebd8655991f09e63302e59ca646f68'/>
<id>d32a571acbebd8655991f09e63302e59ca646f68</id>
<content type='text'>
Looks like there are some legacy GitLab databases that have a NOT NULL
constraint for the `created_at` and `updated` fields.

This change fixes the migration by adding a default value to those
columns and I think we always should have it in mind when inserting DB
records through raw SQL.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Looks like there are some legacy GitLab databases that have a NOT NULL
constraint for the `created_at` and `updated` fields.

This change fixes the migration by adding a default value to those
columns and I think we always should have it in mind when inserting DB
records through raw SQL.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add index to find stuck merge requests.</title>
<updated>2018-11-01T16:26:35+00:00</updated>
<author>
<name>Andreas Brandl</name>
<email>abrandl@gitlab.com</email>
</author>
<published>2018-11-01T14:48:13+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f19b6ef351d2ae8d22dc8dd669393224ca42bc26'/>
<id>f19b6ef351d2ae8d22dc8dd669393224ca42bc26</id>
<content type='text'>
See https://gitlab.com/gitlab-org/gitlab-ce/issues/45608#note_113803790
for query and plan.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/45608.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
See https://gitlab.com/gitlab-org/gitlab-ce/issues/45608#note_113803790
for query and plan.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/45608.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'</title>
<updated>2018-11-01T10:34:23+00:00</updated>
<author>
<name>Achilleas Pipinellis</name>
<email>axil@gitlab.com</email>
</author>
<published>2018-11-01T10:34:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7f47e13218477c13cc627c2f0664500b72ea18b7'/>
<id>7f47e13218477c13cc627c2f0664500b72ea18b7</id>
<content type='text'>
Fix typos in comments and specs

See merge request gitlab-org/gitlab-ce!22683</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix typos in comments and specs

See merge request gitlab-org/gitlab-ce!22683</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typos in comments and specs</title>
<updated>2018-11-01T06:59:20+00:00</updated>
<author>
<name>George Tsiolis</name>
<email>tsiolis.g@gmail.com</email>
</author>
<published>2018-10-30T10:53:01+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=733ae9492129e835f183902a97ee0886e2dbdc9b'/>
<id>733ae9492129e835f183902a97ee0886e2dbdc9b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Drop gcp_clusters table</title>
<updated>2018-10-31T10:13:44+00:00</updated>
<author>
<name>Shinya Maeda</name>
<email>shinya@gitlab.com</email>
</author>
<published>2018-10-31T10:13:44+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=44089058d9ba9c3548e1f1ea772802a0924d38c8'/>
<id>44089058d9ba9c3548e1f1ea772802a0924d38c8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enhance performance of counting local LFS objects</title>
<updated>2018-10-30T07:42:11+00:00</updated>
<author>
<name>Toon Claes</name>
<email>toon@gitlab.com</email>
</author>
<published>2018-10-05T12:20:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d5f290e4170df0f287dbaab4b6c77c649682b13b'/>
<id>d5f290e4170df0f287dbaab4b6c77c649682b13b</id>
<content type='text'>
Add an index to the `file_store` column on `lfs_objects`. This makes
counting local objects faster.

Also, there is no longer need to check for objects with `file_store`
being `NULL`. See
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18557

---

### Query plans

#### Before &amp; with `NULL`

```
Aggregate  (cost=113495.96..113495.97 rows=1 width=8) (actual time=1691.394..1691.394 rows=1 loops=1)
  -&gt;  Seq Scan on lfs_objects  (cost=0.00..106415.50 rows=2832186 width=0) (actual time=0.012..1312.488 rows=2852607 loops=1)
        Filter: ((file_store = 1) OR (file_store IS NULL))
        Rows Removed by Filter: 131
Planning time: 0.077 ms
Execution time: 1691.433 ms
```

#### Before, without `NULL`

```
Aggregate  (cost=113495.96..113495.97 rows=1 width=8) (actual time=856.423..856.424 rows=1 loops=1)
  -&gt;  Seq Scan on lfs_objects  (cost=0.00..106415.50 rows=2832186 width=0) (actual time=0.012..672.181 rows=2852607 loops=1)
        Filter: (file_store = 1)
        Rows Removed by Filter: 131
Planning time: 0.128 ms
Execution time: 856.470 ms
```

#### After &amp; with `NULL`

```
Aggregate  (cost=68819.95..68819.96 rows=1 width=8) (actual time=583.355..583.355 rows=1 loops=1)
  -&gt;  Index Only Scan using index_lfs_objects_on_file_store on lfs_objects  (cost=0.43..61688.35 rows=2852643 width=0) (actual time=0.028..399.177 rows=2852607 loops=1)
        Filter: ((file_store = 1) OR (file_store IS NULL))
        Rows Removed by Filter: 131
        Heap Fetches: 867
Planning time: 0.096 ms
Execution time: 583.404 ms
```

#### After, without `NULL`

```
Aggregate  (cost=68817.29..68817.30 rows=1 width=8) (actual time=490.550..490.551 rows=1 loops=1)
  -&gt;  Index Only Scan using index_lfs_objects_on_file_store on lfs_objects  (cost=0.43..61685.68 rows=2852643 width=0) (actual time=0.040..311.760 rows=2852607 loops=1)
        Index Cond: (file_store = 1)
        Heap Fetches: 831
Planning time: 0.294 ms
Execution time: 490.590 ms
```

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6067
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add an index to the `file_store` column on `lfs_objects`. This makes
counting local objects faster.

Also, there is no longer need to check for objects with `file_store`
being `NULL`. See
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18557

---

### Query plans

#### Before &amp; with `NULL`

```
Aggregate  (cost=113495.96..113495.97 rows=1 width=8) (actual time=1691.394..1691.394 rows=1 loops=1)
  -&gt;  Seq Scan on lfs_objects  (cost=0.00..106415.50 rows=2832186 width=0) (actual time=0.012..1312.488 rows=2852607 loops=1)
        Filter: ((file_store = 1) OR (file_store IS NULL))
        Rows Removed by Filter: 131
Planning time: 0.077 ms
Execution time: 1691.433 ms
```

#### Before, without `NULL`

```
Aggregate  (cost=113495.96..113495.97 rows=1 width=8) (actual time=856.423..856.424 rows=1 loops=1)
  -&gt;  Seq Scan on lfs_objects  (cost=0.00..106415.50 rows=2832186 width=0) (actual time=0.012..672.181 rows=2852607 loops=1)
        Filter: (file_store = 1)
        Rows Removed by Filter: 131
Planning time: 0.128 ms
Execution time: 856.470 ms
```

#### After &amp; with `NULL`

```
Aggregate  (cost=68819.95..68819.96 rows=1 width=8) (actual time=583.355..583.355 rows=1 loops=1)
  -&gt;  Index Only Scan using index_lfs_objects_on_file_store on lfs_objects  (cost=0.43..61688.35 rows=2852643 width=0) (actual time=0.028..399.177 rows=2852607 loops=1)
        Filter: ((file_store = 1) OR (file_store IS NULL))
        Rows Removed by Filter: 131
        Heap Fetches: 867
Planning time: 0.096 ms
Execution time: 583.404 ms
```

#### After, without `NULL`

```
Aggregate  (cost=68817.29..68817.30 rows=1 width=8) (actual time=490.550..490.551 rows=1 loops=1)
  -&gt;  Index Only Scan using index_lfs_objects_on_file_store on lfs_objects  (cost=0.43..61685.68 rows=2852643 width=0) (actual time=0.040..311.760 rows=2852607 loops=1)
        Index Cond: (file_store = 1)
        Heap Fetches: 831
Planning time: 0.294 ms
Execution time: 490.590 ms
```

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6067
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'origin/master' into dev-master</title>
<updated>2018-10-29T21:37:19+00:00</updated>
<author>
<name>DJ Mountney</name>
<email>david@twkie.net</email>
</author>
<published>2018-10-29T21:37:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=06b6daacb15b92b04e05538b37aadfdb04fc5a4b'/>
<id>06b6daacb15b92b04e05538b37aadfdb04fc5a4b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-redact-links' into 'master'</title>
<updated>2018-10-29T16:10:32+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2018-10-29T16:10:32+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5b0b73d922f5081e84697d439b30959161966727'/>
<id>5b0b73d922f5081e84697d439b30959161966727</id>
<content type='text'>
[master] Redact unsubscribe links in issuable texts

See merge request gitlab/gitlabhq!2528</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[master] Redact unsubscribe links in issuable texts

See merge request gitlab/gitlabhq!2528</pre>
</div>
</content>
</entry>
<entry>
<title>[master] Persist only SHA digest of PersonalAccessToken#token</title>
<updated>2018-10-29T16:06:45+00:00</updated>
<author>
<name>Imre Farkas</name>
<email>ifarkas@gitlab.com</email>
</author>
<published>2018-10-29T16:06:45+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b9652d8e4dc8544766c9371057be72cc26fe3a4b'/>
<id>b9652d8e4dc8544766c9371057be72cc26fe3a4b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
