delta/gitlab/gitlab-ce.git/doc/development/code_review.md, branch fix-trace-reader-encoding

Rename endboss -> maintainer, miniboss -> reviewer

2017-01-13T16:12:02+00:00

We want to describe these roles in a way that is more understandable to
people not familiar with GitLab.

Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master'

2016-12-05T11:07:57+00:00


Rename MWBS service to Merge When Pipeline Succeeds

## What does this MR do?

This MR renames Merge When Build Succeeds feature to Merge When Pipeline Succeeds, because we recently changed the behavior, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6675.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing

## What are the relevant issue numbers?

Closes #23354

See merge request !7135

Remove change to MWBS in code review guideline

2016-12-02T07:55:53+00:00

[ci skip]

Copy-edit text about right balance in code reviews

2016-12-01T09:42:35+00:00

[ci skip]

Extend code review docs with chapter about the right balance

2016-11-30T10:23:09+00:00

Update some docs to reflect MWPS name change

2016-11-21T10:27:28+00:00

Fix typo and add he MWBS accronym for "Merge When Build Succeeds"

2016-10-07T14:17:28+00:00

Signed-off-by: Rémy Coutable

Improve the contribution and MR review guide

2016-10-07T13:28:15+00:00

Signed-off-by: Rémy Coutable

Re-add a note about sarcasm to the Code Review guide

2016-04-11T02:54:44+00:00

[ci skip]

First pass at a Code Review guide

2016-04-10T01:49:47+00:00

Largely borrowed from thoughtbot's code review guide, so attribution is
included.

[ci skip]