delta/gitlab/gitlab-ce.git/lib/banzai/reference_parser, branch dm-diff-file-diffable

Fix /unsubscribe slash command creating extra todos

2017-05-30T10:24:55+00:00

The /unsubscribe slash command means that we check if the current user is
subscribed to the issuable without having an explicit subscription. That means
that we use the UserParser to find references to them in the notes.

The UserParser (and all parsers inheriting from BaseParser) use RequestStore to
cache ActiveRecord objects, so that we don't need to load the User object each
time, if we're parsing references a bunch of times in the same request.

However, it was always returning _all_ of the previously cached items, not just
the ones matching the IDs passed. This would mean that we did two runs through
with UserParser if you were mentioned in a comment, and then mentioned someone
else in your comment while using /unsubscribe:

1. Because /unsubscribe was used, we see if you were mentioned in any comments.
2. Because you mentioned someone, we find them - but we would also get back your
   user, even if you didn't mention yourself. This would have the effect of
   creating a mention or directly addressed todo for yourself incorrectly.

The fix is simple: only return values from the cache matching the IDs passed.

Backport of multiple_assignees_feature [ci skip]

2017-05-04T14:11:53+00:00

Remove N+1 queries when checking nodes visible to user

2017-05-02T16:35:19+00:00

N in this case is low, as it's the number of distinct projects referenced from
MRs, rather than the number of MRs referenced (issues use their own
optimization). Still, on issues or MRs which are often referenced from MRs, it
will save a few queries.

Fix regression in rendering Markdown references that do not exist

2017-04-15T14:26:32+00:00

Closes #30972

Reuse "merge_requests_for_nodes" in "MergeRequestParser"

2017-04-10T10:42:20+00:00

Add indication for closed or merged issuables in GFM

2017-04-07T19:31:43+00:00

Example: for issues that are closed, the links will now show '[closed]'
following the issue number. This is done as post-process after the markdown has
been loaded from the cache as the status of the issue may change between
the cache being populated and the content being displayed.

In order to avoid N+1 queries problem when rendering notes ObjectRenderer
populates the cache of referenced issuables for all notes at once,
before the post processing phase.

As a part of this change, the Banzai BaseParser#grouped_objects_for_nodes
method has been refactored to return a Hash utilising the node itself as the
key, since this was a common pattern of usage for this method.

Use Enumerable#index_by where possible

2017-03-16T22:33:15+00:00

use a magic default :global symbol instead of nil

2017-03-09T19:49:52+00:00

to make sure we mean the global permissions

Create directly_addressed Todos when mentioned in beginning of a line

2017-02-08T16:23:34+00:00

Merge branch 'issue_23548_dev' into 'master'

2016-11-09T11:25:17+00:00

disable markdown in comments when referencing disabled features

fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23548

This MR prevents the following references when tool is disabled:

- issues
- snippets
- commits - when repo is disabled
- commit range - when repo is disabled
- milestones

This MR does not prevent references to repository files, since they are just markdown links and don't leak
information.

See merge request !2011

Signed-off-by: Rémy Coutable