<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/banzai, branch koding-setting-api</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>AbstractReferenceFilter caches current project_ref on RequestStore when active</title>
<updated>2016-09-28T12:37:24+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-09-27T15:13:08+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c3f504169b30307a314e328bbcd994493ab1be81'/>
<id>c3f504169b30307a314e328bbcd994493ab1be81</id>
<content type='text'>
Before we weren’t caching current_project_ref because normally the reference to 
the current project doesn’t include the path with namespace. But now we store 
the current project in the projects reference cache to be used for the same 
filter when accessing using path with namespace of for subsequent filters executed on the cache.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before we weren’t caching current_project_ref because normally the reference to 
the current project doesn’t include the path with namespace. But now we store 
the current project in the projects reference cache to be used for the same 
filter when accessing using path with namespace of for subsequent filters executed on the cache.</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid database queries on Banzai::ReferenceParser::BaseParser for nodes without references</title>
<updated>2016-09-28T07:08:28+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-09-27T15:13:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f4a84f504f2119a32a6c8909dc72680a191d7174'/>
<id>f4a84f504f2119a32a6c8909dc72680a191d7174</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix the leak mentioned in 504a3b5 by another way</title>
<updated>2016-09-23T13:29:28+00:00</updated>
<author>
<name>Ahmad Sherif</name>
<email>me@ahmadsherif.com</email>
</author>
<published>2016-09-21T13:55:04+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ca823abacd85f3b78d4b0aeb3e07fdc7a39f090d'/>
<id>ca823abacd85f3b78d4b0aeb3e07fdc7a39f090d</id>
<content type='text'>
The previous fix introduced another leak; as it made
Banzai::Filter::SanitizationFiler#customized? always return false, so we
were always appending two elements to
HTML::Pipeline::SanitizationFilter::WHITELIST[:elements]. This growth in
the elements array would slow the sanitization process over time.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The previous fix introduced another leak; as it made
Banzai::Filter::SanitizationFiler#customized? always return false, so we
were always appending two elements to
HTML::Pipeline::SanitizationFilter::WHITELIST[:elements]. This growth in
the elements array would slow the sanitization process over time.
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Fix a memory leak caused by Banzai::Filter::SanitizationFilter"</title>
<updated>2016-09-23T13:27:48+00:00</updated>
<author>
<name>Ahmad Sherif</name>
<email>me@ahmadsherif.com</email>
</author>
<published>2016-09-21T13:46:31+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0fe33f925a26c5004080a0102e6665fc8012a67d'/>
<id>0fe33f925a26c5004080a0102e6665fc8012a67d</id>
<content type='text'>
This reverts commit 504a3b5e6f0b2e2957cf1e4d9d8eebbf32234bdb.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit 504a3b5e6f0b2e2957cf1e4d9d8eebbf32234bdb.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix URLs with anchors in wiki</title>
<updated>2016-09-14T06:53:40+00:00</updated>
<author>
<name>Qingping Hou</name>
<email>dave2008713@gmail.com</email>
</author>
<published>2016-09-11T23:29:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c9376f90dc977205df374c7504d477d05bc988c'/>
<id>5c9376f90dc977205df374c7504d477d05bc988c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'js-tooltips-for-mentions' into 'master'</title>
<updated>2016-09-01T14:36:09+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-09-01T14:36:09+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3e11bc95a56bec7b86468a72627e621a41fc087b'/>
<id>3e11bc95a56bec7b86468a72627e621a41fc087b</id>
<content type='text'>

Use JavaScript tooltips for mentions

## What does this MR do?

- use JavaScript tooltips instead of plain title for mentions (issue, merge request, snippet, user, group, commit, commit range, milestone)

## Why was this MR needed?

JavaScript tooltips look nicer and can wrap.

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5261#note_13106713, fixes #21500

See merge request !5301</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Use JavaScript tooltips for mentions

## What does this MR do?

- use JavaScript tooltips instead of plain title for mentions (issue, merge request, snippet, user, group, commit, commit range, milestone)

## Why was this MR needed?

JavaScript tooltips look nicer and can wrap.

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5261#note_13106713, fixes #21500

See merge request !5301</pre>
</div>
</content>
</entry>
<entry>
<title>Use JavaScript tooltips for mentions (!5301)</title>
<updated>2016-08-31T23:21:34+00:00</updated>
<author>
<name>winniehell</name>
<email>git@winniehell.de</email>
</author>
<published>2016-07-17T00:03:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0d8352973bfbd3d1857657fce35284fcaf241cf7'/>
<id>0d8352973bfbd3d1857657fce35284fcaf241cf7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>remove Ability.abilities</title>
<updated>2016-08-30T18:35:06+00:00</updated>
<author>
<name>http://jneen.net/</name>
<email>jneen@jneen.net</email>
</author>
<published>2016-08-08T18:55:13+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5853c96b49010aaf33b85caeb94dfc18873d5656'/>
<id>5853c96b49010aaf33b85caeb94dfc18873d5656</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a memory leak caused by Banzai::Filter::SanitizationFilter</title>
<updated>2016-08-14T20:28:18+00:00</updated>
<author>
<name>Ahmad Sherif</name>
<email>me@ahmadsherif.com</email>
</author>
<published>2016-08-14T20:27:49+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=504a3b5e6f0b2e2957cf1e4d9d8eebbf32234bdb'/>
<id>504a3b5e6f0b2e2957cf1e4d9d8eebbf32234bdb</id>
<content type='text'>
In Banzai::Filter::SanitizationFilter#customize_whitelist, we append
three lambdas that has reference to the SanitizationFilter instance,
which in turn (potentially) has a reference to the following chain:

context hash -&gt; Project instance -&gt; Repository instance -&gt; lookup hash
-&gt; various Rugged instances -&gt; various mmap-ed git pack files.

All of the above is not garbage collected because the array we append
the lambdas to is the constant
HTML::Pipeline::SanitizationFilter::WHITELIST.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In Banzai::Filter::SanitizationFilter#customize_whitelist, we append
three lambdas that has reference to the SanitizationFilter instance,
which in turn (potentially) has a reference to the following chain:

context hash -&gt; Project instance -&gt; Repository instance -&gt; lookup hash
-&gt; various Rugged instances -&gt; various mmap-ed git pack files.

All of the above is not garbage collected because the array we append
the lambdas to is the constant
HTML::Pipeline::SanitizationFilter::WHITELIST.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'relative-link-filter-ref' into 'master'</title>
<updated>2016-08-09T21:45:59+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-08-09T21:45:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bd1b8ae9bbbe8c81d5f1c18a5c8d86fbcb4f1dbf'/>
<id>bd1b8ae9bbbe8c81d5f1c18a5c8d86fbcb4f1dbf</id>
<content type='text'>

Do not look up commit again when it is passed to RelativeLinkFilter

## What does this MR do?

Use `context[:commit]` in RelativeLinkFilter instead of looking up commit using `context[:ref]`.

## Why was this MR needed?

Even though the commit object was already passed, unnecessary I/O is done to retrieve the commit object.

## What are the relevant issue numbers?

Fixes #20026

See merge request !5455</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Do not look up commit again when it is passed to RelativeLinkFilter

## What does this MR do?

Use `context[:commit]` in RelativeLinkFilter instead of looking up commit using `context[:ref]`.

## Why was this MR needed?

Even though the commit object was already passed, unnecessary I/O is done to retrieve the commit object.

## What are the relevant issue numbers?

Fixes #20026

See merge request !5455</pre>
</div>
</content>
</entry>
</feed>
