delta/gitlab/gitlab-ce.git/lib/email_template_interceptor.rb, branch github-import-docs gitlab.com: gitlab-org/gitlab-ce.git use Gitlab::UserSettings directly as a singleton instead of including/extending it 2018-02-02T18:39:55+00:00 Mario de la Ossa mdelaossa@gitlab.com 2018-02-02T18:39:55+00:00 eaada9d7066a20b5af815f723e09cde60a5c8c10 






`current_application_settings` belongs on `Gitlab::CurrentSettings`
2017-08-31T12:38:33+00:00

Sean McGivern
sean@gitlab.com

2017-08-31T09:47:03+00:00

5883ce95efcc4cc04f949f9b4e66d73fbede94e2

The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.





The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.







Use #parts instead of #part to read all the parts of the Message.
2017-01-09T18:01:07+00:00

Ruben Davila
rdavila84@gmail.com

2017-01-09T18:01:07+00:00

c6ebe440dad6932f65254f058a5a291973526f99

Looks like I was accidentally using #part which was adding an extra
empty Mime section





Looks like I was accidentally using #part which was adding an extra
empty Mime section







Add new configuration setting to enable/disable HTML emails.
2016-11-28T22:00:03+00:00

Ruben Davila
rdavila84@gmail.com

2016-11-28T22:00:03+00:00

b62e2bedbfa49aacfc4847049aa589f045af15ce

This new global setting will allow admins to specify if HTML emails should be sent or not,
this is basically useful when system administrators want to save some disk space by avoiding
emails in HTML format and using only the Plain Text version.





This new global setting will allow admins to specify if HTML emails should be sent or not,
this is basically useful when system administrators want to save some disk space by avoiding
emails in HTML format and using only the Plain Text version.