<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/qa, branch github-rake-task-rate-limiting</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix test selection in Test::Integration::Mattermost</title>
<updated>2017-11-08T12:13:47+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-11-08T12:13:47+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e1f037980fda1620c2ba6ed407c35349989275fa'/>
<id>e1f037980fda1620c2ba6ed407c35349989275fa</id>
<content type='text'>
In ce3b81b953f we changed Test::Integration::Mattermost#perform to
consume a required positional parameter and pass on the rest of the
arguments to the superclass. There was an error in implementation here
and instead of splatting the files array to produce no additional
arguments, we passed in the default case an empty array.

This had the effect of calling rspec with no test files,
rather than expected default of 'qa/specs/features`

Here we correct that bug, and re-add the :core suite, as that was a poor
deuction in the investagtion for 74d6b8a211.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In ce3b81b953f we changed Test::Integration::Mattermost#perform to
consume a required positional parameter and pass on the rest of the
arguments to the superclass. There was an error in implementation here
and instead of splatting the files array to produce no additional
arguments, we passed in the default case an empty array.

This had the effect of calling rspec with no test files,
rather than expected default of 'qa/specs/features`

Here we correct that bug, and re-add the :core suite, as that was a poor
deuction in the investagtion for 74d6b8a211.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixup rspec tag misuse</title>
<updated>2017-11-06T17:54:21+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-11-06T17:54:21+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=74d6b8a2114ed6b05ad7dd12688bf5b4c62c5358'/>
<id>74d6b8a2114ed6b05ad7dd12688bf5b4c62c5358</id>
<content type='text'>
In !14818 we added the ability to specify the example groups that should
run via the `-t` (tag) option to rspec.  It was assumed that the
inclusion filter generated `{:core =&gt; true, :mattermost =&gt; true}` would
run examples tagged :core OR :mattermost, when instead it means :core
AND :mattermost.

Here in order to assure at least some tests run, we specify that
the :mattermost tagged examples are the only ones we care about.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In !14818 we added the ability to specify the example groups that should
run via the `-t` (tag) option to rspec.  It was assumed that the
inclusion filter generated `{:core =&gt; true, :mattermost =&gt; true}` would
run examples tagged :core OR :mattermost, when instead it means :core
AND :mattermost.

Here in order to assure at least some tests run, we specify that
the :mattermost tagged examples are the only ones we care about.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add tests for mattermost login via oauth</title>
<updated>2017-10-30T14:48:40+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-25T04:55:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ce3b81b953f04caabee30498bb4719c59b8b5d34'/>
<id>ce3b81b953f04caabee30498bb4719c59b8b5d34</id>
<content type='text'>
* Adds Runtime::Scenario as a place to record the properties of the
  Scenario we're interested in.

* Adds a positional argument to Test::Integration::Mattermost to specify
  Runtime::Scenario.mattermost

* Adds Page::Mattermost::{Main,Login} to model the mattermost pages we
  need to interact with.

* Adds qa/features/mattermost/login_spec to perform a login via oauth
  and ensure we are logged in.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Adds Runtime::Scenario as a place to record the properties of the
  Scenario we're interested in.

* Adds a positional argument to Test::Integration::Mattermost to specify
  Runtime::Scenario.mattermost

* Adds Page::Mattermost::{Main,Login} to model the mattermost pages we
  need to interact with.

* Adds qa/features/mattermost/login_spec to perform a login via oauth
  and ensure we are logged in.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add spec for QA::Scenario::Entrypoint</title>
<updated>2017-10-25T04:59:49+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-25T03:50:26+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4598c00a8f565a33c4460ae920ce7a65ba6540cc'/>
<id>4598c00a8f565a33c4460ae920ce7a65ba6540cc</id>
<content type='text'>
For added confidence, and because I plan to fiddle with some behaviours
shortly, add spec testing to the newly extracted
QA::Scenario::Entrypoint class.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For added confidence, and because I plan to fiddle with some behaviours
shortly, add spec testing to the newly extracted
QA::Scenario::Entrypoint class.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use the new buttons for creating groups and projects in QA tests</title>
<updated>2017-10-23T09:47:30+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2017-10-23T08:25:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=09ba91edde51bb3f9cb55c86e86aa90bce3c8c9e'/>
<id>09ba91edde51bb3f9cb55c86e86aa90bce3c8c9e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move tags out to containing feature</title>
<updated>2017-10-16T11:49:54+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T11:49:54+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d600ea75c35235fd23da8bd65a8034778112c0d2'/>
<id>d600ea75c35235fd23da8bd65a8034778112c0d2</id>
<content type='text'>
We can currently reduce the number of times we specify the tag of a
given example group by moving them hoisting them up one level to the
containing `feature`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We can currently reduce the number of times we specify the tag of a
given example group by moving them hoisting them up one level to the
containing `feature`
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup a stray instance variable</title>
<updated>2017-10-16T11:26:23+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T11:26:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9818d3eec69cbf27c63ee481871544f726a9decc'/>
<id>9818d3eec69cbf27c63ee481871544f726a9decc</id>
<content type='text'>
This was added as part of the previous filtering via RSpec::Config.  It
should have been removed previously as part of moving the logic to
specify the tags we wanted in Specs::Runner
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was added as part of the previous filtering via RSpec::Config.  It
should have been removed previously as part of moving the logic to
specify the tags we wanted in Specs::Runner
</pre>
</div>
</content>
</entry>
<entry>
<title>Explicitly tag :core and :mattermost scenarios</title>
<updated>2017-10-16T09:34:59+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T09:34:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=da393460b690a6e394460cfd768822a3134efe7b'/>
<id>da393460b690a6e394460cfd768822a3134efe7b</id>
<content type='text'>
It's adding additional potentially confusing behaviour to derive test
tagging from the file path, as it's not immediately apparent where that
lives when considering the tests in isolation.  Instead, just explicitly
tag.

* Remove the tagging of examples based on :file_path
* Explicitly tags scenarios as :core, or :mattermost
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's adding additional potentially confusing behaviour to derive test
tagging from the file path, as it's not immediately apparent where that
lives when considering the tests in isolation.  Instead, just explicitly
tag.

* Remove the tagging of examples based on :file_path
* Explicitly tags scenarios as :core, or :mattermost
</pre>
</div>
</content>
</entry>
<entry>
<title>Move rspec cli handling logic into Specs::Runner</title>
<updated>2017-10-16T09:21:00+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T09:15:50+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cbc67b485efff3f51e86131a0da5af5a38a59955'/>
<id>cbc67b485efff3f51e86131a0da5af5a38a59955</id>
<content type='text'>
Here we convert Specs::Runner#rspec to use keyword arguments[1] and pass
named parameters rather than a pre-processed array of cli switches.
This allows parameter to cli logic to live just in Specs::Runner.

[1] https://robots.thoughtbot.com/ruby-2-keyword-arguments
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Here we convert Specs::Runner#rspec to use keyword arguments[1] and pass
named parameters rather than a pre-processed array of cli switches.
This allows parameter to cli logic to live just in Specs::Runner.

[1] https://robots.thoughtbot.com/ruby-2-keyword-arguments
</pre>
</div>
</content>
</entry>
<entry>
<title>Update comment</title>
<updated>2017-10-13T15:00:20+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-13T15:00:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6faeb7209d3e376fb1f5ac320a8fd706b0f93d5'/>
<id>c6faeb7209d3e376fb1f5ac320a8fd706b0f93d5</id>
<content type='text'>
Entrypoint is intended as a base class, so mention that in the comment.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Entrypoint is intended as a base class, so mention that in the comment.
</pre>
</div>
</content>
</entry>
</feed>
