<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/controllers/application_controller_spec.rb, branch issue_51323</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix content caching for non auth users</title>
<updated>2018-10-23T14:22:12+00:00</updated>
<author>
<name>James Lopez</name>
<email>james@jameslopez.es</email>
</author>
<published>2018-10-18T11:28:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=782badd0a2cd00d2a9cbe591e78b30aca32e252b'/>
<id>782badd0a2cd00d2a9cbe591e78b30aca32e252b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use InvalidUTF8ErrorHandler only for rails 4</title>
<updated>2018-10-13T17:45:27+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2018-10-13T17:45:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6a4c9231e983f2bd5f0c2115a5c9c16fd18bfb2'/>
<id>c6a4c9231e983f2bd5f0c2115a5c9c16fd18bfb2</id>
<content type='text'>
In Rails 5 catches invalid UTF8 characters in querystring in a
params middleware, errors are handled by a params middleware and
raises a BadRequest exception. This means that these UTF8 errors
are not raised deeper in application stack and these can't also
be handled on application level.

If we would want to have custom handler for these errors, we would
have to create a new middleware and insert it before actionpack's
params middleware and rescue BadRequest exceptions there. But there
is no need to do this currently (see discussion on
https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In Rails 5 catches invalid UTF8 characters in querystring in a
params middleware, errors are handled by a params middleware and
raises a BadRequest exception. This means that these UTF8 errors
are not raised deeper in application stack and these can't also
be handled on application level.

If we would want to have custom handler for these errors, we would
have to create a new middleware and insert it before actionpack's
params middleware and rescue BadRequest exceptions there. But there
is no need to do this currently (see discussion on
https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove Git circuit breaker</title>
<updated>2018-10-10T07:08:18+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2018-10-09T05:59:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=30b4ce940d28804e0b38ea9ea4f89793d41392db'/>
<id>30b4ce940d28804e0b38ea9ea4f89793d41392db</id>
<content type='text'>
Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add custom header for error responses</title>
<updated>2018-10-01T17:43:40+00:00</updated>
<author>
<name>David</name>
<email>david.piegza@mailbox.org</email>
</author>
<published>2018-10-01T17:43:40+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fea4efe42f03e983c1b4bcfcce2c7e8db82f7447'/>
<id>fea4efe42f03e983c1b4bcfcce2c7e8db82f7447</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Render 412 for invalid UTF-8 parameters</title>
<updated>2018-09-22T15:15:53+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2018-09-05T19:41:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1fcc7f9ba23a5ca02773e080ccb66f37435150ff'/>
<id>1fcc7f9ba23a5ca02773e080ccb66f37435150ff</id>
<content type='text'>
Renders 412 error page when invalid UTF-8 is passed
as parameters in controllers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Renders 412 error page when invalid UTF-8 is passed
as parameters in controllers.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix logins via OAuth2 geting logged out in an hour</title>
<updated>2018-08-10T21:41:59+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-08-10T19:15:06+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a7e2f96b59035fd4628a047370c87400e16a4b63'/>
<id>a7e2f96b59035fd4628a047370c87400e16a4b63</id>
<content type='text'>
Users without GitLab 2FA enabled would be logged out after an hour
due to a regression in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20700.

The OAuth2 controller sets the current_user after the controller is finished, so
we should only limit session times after this has been done.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50210
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Users without GitLab 2FA enabled would be logged out after an hour
due to a regression in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20700.

The OAuth2 controller sets the current_user after the controller is finished, so
we should only limit session times after this has been done.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50210
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't set gon variables in JSON requests</title>
<updated>2018-08-07T21:28:57+00:00</updated>
<author>
<name>Peter Leitzen</name>
<email>peter@leitzen.de</email>
</author>
<published>2018-08-07T21:28:57+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ffcf50c8725c42a11f19c30dd8b680ec3525365f'/>
<id>ffcf50c8725c42a11f19c30dd8b680ec3525365f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'feature/gb/login-activity-metrics' into 'master'</title>
<updated>2018-07-31T10:44:22+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2018-07-31T10:44:22+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e6dd3c527626af1c0f521792360f7c4b29bfee36'/>
<id>e6dd3c527626af1c0f521792360f7c4b29bfee36</id>
<content type='text'>
Add user authentication activity metrics

Closes #47789

See merge request gitlab-org/gitlab-ce!20668</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add user authentication activity metrics

Closes #47789

See merge request gitlab-org/gitlab-ce!20668</pre>
</div>
</content>
</entry>
<entry>
<title>Add authentication metrics for sessionless sign in</title>
<updated>2018-07-27T10:56:34+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2018-07-27T10:56:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=00e4d918a3cf14a96d25822b6d65c7b6d8f00b63'/>
<id>00e4d918a3cf14a96d25822b6d65c7b6d8f00b63</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Limit the TTL for anonymous sessions to 1 hour</title>
<updated>2018-07-18T19:39:51+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-07-18T18:18:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c559c43dafb75005f5589c473729054845bb498b'/>
<id>c559c43dafb75005f5589c473729054845bb498b</id>
<content type='text'>
By default, all sessions are given the same expiration time configured in the
session store (e.g. 1 week). However, unauthenticated users can generate a lot
of sessions, primarily for CSRF verification. It makes sense to reduce the TTL
for unauthenticated to something much lower than the default (e.g. 1 hour) to
limit Redis memory. In addition, Rails creates a new session after login,
so the short TTL doesn't even need to be extended.

Closes #48101
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
By default, all sessions are given the same expiration time configured in the
session store (e.g. 1 week). However, unauthenticated users can generate a lot
of sessions, primarily for CSRF verification. It makes sense to reduce the TTL
for unauthenticated to something much lower than the default (e.g. 1 hour) to
limit Redis memory. In addition, Rails creates a new session after login,
so the short TTL doesn't even need to be extended.

Closes #48101
</pre>
</div>
</content>
</entry>
</feed>
