delta/gitlab/gitlab-ce.git/spec/controllers/help_controller_spec.rb, branch docs-patch-71

Change `be_success` to `be_successful` in specs

2019-08-19T12:40:56+00:00

Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```

Fix broken spec from file rename

2019-08-01T04:06:03+00:00

b36323f3d26131405925bf86742b2b4acd786230

Add some frozen string to spec/**/*.rb

2019-04-15T10:17:05+00:00

Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Fix broken links on help page

2019-02-11T22:41:58+00:00

Update the help controller to correctly handle relative links on the help pages
when the relative link is before an external link on the same line in the
markdown file.

Test cases have been implement to check for
 - relative links before external link on same line,
 - HTTPS in query part of link,
 - URLs without '//' and
 - protocol-relative links.

Update specs to rails5 format

2018-12-18T23:04:31+00:00

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Updating `HelpController` spec to use an existing image

2018-02-07T18:05:25+00:00

Refactor `have_http_status` into `have_gitlab_http_status` in the specs

2017-10-20T08:13:18+00:00

Fix URL rewritting in the Help section

2016-12-01T15:40:48+00:00

Signed-off-by: Rémy Coutable

Fix broken external links in help/index.html

2016-11-20T19:15:08+00:00

An external link was recently added but was broken because
'https://gitlab.com/help/' was prepended to every link in the page.

Since no link in the main help readme begins with "help" and since doing
so wouldn't make sense, the substitution conditionaly prepending "help"
can be simplified and reused.

Signed-off-by: David Wagner

fix error links in help page

2016-11-12T13:45:45+00:00