delta/gitlab/gitlab-ce.git/spec/controllers/projects, branch docs-patch-71

Standardize remote_ip and path keys for auth.log and api_json.log

2019-08-20T18:12:28+00:00

Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167

Merge branch 'fix-deprecation-warnings-change-success-to-successful' into 'master'

2019-08-20T16:02:32+00:00

Change `be_success` to `be_successful` in specs

See merge request gitlab-org/gitlab-ce!31969

Merge branch 'mc/bug/nplusone-pipelines-show' into 'master'

2019-08-19T21:52:56+00:00

Improve nplusone spec for PipelinesController#show

See merge request gitlab-org/gitlab-ce!31976

Fix N+1s queries while loading users

2019-08-19T20:35:46+00:00

Improve nplusone spec for PipelinesController#show

2019-08-19T19:02:28+00:00

Change `be_success` to `be_successful` in specs

2019-08-19T12:40:56+00:00

Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```

Merge branch '66023-starrers-count-do-not-match-after-searching' into 'master'

2019-08-16T20:34:27+00:00

Fix starrers counts after searching

See merge request gitlab-org/gitlab-ce!31823

Merge branch '24705-multi-selection-for-delete-on-registry-page' into 'master'

2019-08-15T23:57:38+00:00

Resolve "Multi selection for delete on registry page"

Closes #24705

See merge request gitlab-org/gitlab-ce!30837

Fix starrers counters after searching

2019-08-15T17:34:16+00:00

Allow CI to clone public projects when HTTP protocol is disabled

2019-08-14T19:15:33+00:00

GitLab has a mechanism that allows CI to clone repositories via HTTP
even when the HTTP protocol is disabled. This works as expected
when a project is private or internal. However, when a project is
public CI gets an error message that HTTP is not allowed. This
happens because Git only sends auth in a subsequent request after a
401 is returned first. For public projects, GitLab grabs onto that
unauthenticated request and sends it through since it recognizes
that Guests are ordinarily allowed to access the repository.
Later on this leads to a 403 since HTTP protocol is disabled.
Fix this by only continuing with unauthenticated requests when
HTTP is allowed.