delta/gitlab/gitlab-ce.git/spec/features/dashboard, branch mr-commit-optimization

Make user/author use project.creator in most factories

2018-01-31T17:31:21+00:00

Signed-off-by: Rémy Coutable

Merge branch 'conditionally-eager-load-event-target-authors' into 'master'

2018-01-04T16:46:40+00:00

Eager load event target authors whenever possible

Closes #41618

See merge request gitlab-org/gitlab-ce!16199

Eager load event target authors whenever possible

2018-01-04T13:32:38+00:00

This ensures that the "author" association of an event's "target"
association is eager loaded whenever the "target" association defines an
"author" association. This in turn solves the N+1 query problem we first
tried to solve in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15788 but caused
problems when displaying milestones as those don't define an "author"
association.

The approach in this commit does mean that the authors are _always_
eager loaded since this takes place in the "belongs_to" block. This
however shouldn't pose too much of a problem, and as far as I can tell
there's no real way around this unfortunately.

Update test to remove carent icon check

2018-01-02T09:29:22+00:00

Replace '.team << [user, role]' with 'add_role(user)' in specs

2017-12-22T08:18:28+00:00

Fix broken test

2017-12-11T13:23:14+00:00

Merge branch 'master' into sh-headless-chrome-support

2017-11-03T19:02:52+00:00

* master: (33 commits)
  Ignore SQL CACHE hits in Sherlock
  Fix SQL timings for the performance bar
  Find the LFS-objects for a fork within a the fork network
  Remove bottom-border from last responsive table row
  Add system hooks user_rename and group_rename
  Unlink a project from a fork network when it's source was deleted.
  Make sure the settings page renders when root of a fork is deleted
  Remove Peek's original keyboard shortcut (numpad 0, keycode 96)
  Add application setting to Auto DevOps docs
  Enable MergeableSelector in scss-lint (for !14567)
  Enable MergeableSelector in scss-lint (for !14055)
  Enable MergeableSelector in scss-lint (for !14062)
  Enable MergeableSelector in scss-lint (for !14398)
  Enable MergeableSelector in scss-lint (for !13480)
  Enable MergeableSelector in scss-lint (for !13473)
  Enable MergeableSelector in scss-lint (for !13600)
  Enable MergeableSelector in scss-lint
  Resolve ""To do" should be "Todos" on Todos list page"
  Avoid regenerating the ref path for the environment
  Remove white space at bottom of issue boards
  ...

Resolve ""To do" should be "Todos" on Todos list page"

2017-11-03T00:01:56+00:00

Merge branch 'master' into sh-headless-chrome-support

2017-10-23T07:32:14+00:00

* master: (297 commits)
  Fix deletion of container registry or images returning an error
  The fog-aliyun gem had a bug in v0.1.0 for file storage creation/update. This merge requests update the gem to v0.2.0 which contains the fix:
  Decrease ABC threshold to 54.28
  Update VERSION to 10.2.0-pre
  Update CHANGELOG.md for 10.1.0
  Document `CI_SHARED_ENVIRONMENT` and `CI_DISPOSABLE_ENVIRONMENT`
  Fix the external URLs generated for online view of HTML artifacts
  Use title as placeholder instead of issue title for reusability
  Fix failure in current_settings_spec.rb
  Clarify the difference between project_update and project_rename
  URI decode Page-Title header to preserve UTF-8 characters
  Update Gitaly version to v0.49.0
  Decrease Perceived Complexity threshold to 14
  Resolve "Remove help text regarding group issues on group issues page (and group merge requests page)"
  Force non diff resolved discussion to display when collapse toggled
  Added submodule support in multi-file editor
  add note about after_script being run separately
  Check for element before evaluate_script
  Merge branch 'master-i18n' into 'master'
  Update Prometheus gem to fix problems with other files overwriting current file
  ...

Merge branch 'feature/reliable-rspec-with-eval-script' into 'master'

2017-10-20T18:53:42+00:00

Check for element before execute_script

See merge request gitlab-org/gitlab-ce!14898