delta/gitlab/gitlab-ce.git/spec/features/profiles, branch test-gitlab-git gitlab.com: gitlab-org/gitlab-ce.git Remove sleeping and replace escaped text. 2016-08-13T05:57:40+00:00 Connor Shea connor.james.shea@gmail.com 2016-08-12T17:44:43+00:00 1392cad8956c490b5ba6106678ab16d790662148 






Updated tests
2016-08-13T05:57:40+00:00

Phil Hughes
me@iamphill.com

2016-08-11T16:48:32+00:00

f668da11cb225a9b2c2f1d3ba9d1e9fb2797d4f9












Avoid to show the original password field when password is automatically seted
2016-08-08T16:55:57+00:00

Carlos Ribeiro
mail@carlosribeiro.me

2016-08-08T14:03:30+00:00

ed63ead22aa9fd9fe509f3bebd73223b4ff8b8c5












Implement @DouweM's feedback.
2016-06-16T02:54:13+00:00

Timothy Andrew
mail@timothyandrew.net

2016-06-16T02:54:13+00:00

7ee0898a9ec4a03c9a55841b1cbea67add460c50

- Extract a duplicated `redirect_to`
- Fix a typo: "token", not "certificate"
- Have the "Expires at" datepicker be attached to a text field, not inline
- Have both private tokens and personal access tokens verified in a
  single "authenticate_from_private_token" method, both in the
  application and API. Move relevant logic to
  `User#find_by_personal_access_token`
- Remove unnecessary constants relating to API auth. We don't need a
  separate constant for personal access tokens since the param is the
  same as for private tokens.





- Extract a duplicated `redirect_to`
- Fix a typo: "token", not "certificate"
- Have the "Expires at" datepicker be attached to a text field, not inline
- Have both private tokens and personal access tokens verified in a
  single "authenticate_from_private_token" method, both in the
  application and API. Move relevant logic to
  `User#find_by_personal_access_token`
- Remove unnecessary constants relating to API auth. We don't need a
  separate constant for personal access tokens since the param is the
  same as for private tokens.







Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokens
2016-06-14T03:36:53+00:00

Timothy Andrew
mail@timothyandrew.net

2016-06-14T03:36:53+00:00

d0bcba1105686c2306414a402bf33c85a08a17a6












Fix preferences_spec test
2016-06-10T20:08:13+00:00

Annabel Dunstone
annabel.dunstone@gmail.com

2016-06-10T20:08:13+00:00

3e28d04cced2c417ee9144a17866e0cc2c910a6c












Implement second round of comments from @jschatz1.
2016-06-10T05:00:49+00:00

Timothy Andrew
mail@timothyandrew.net

2016-06-10T03:19:05+00:00

e18a08fd89f59088db22208069370a85f6a33001

- Just use a link for the clipboard button. Having a non-clickable
  container (that looks like a button) is confusing.
- Use `text-danger` for the "you won't be able to access it again" message.
- Highlight the created token so people know to look there.





- Just use a link for the clipboard button. Having a non-clickable
  container (that looks like a button) is confusing.
- Use `text-danger` for the "you won't be able to access it again" message.
- Highlight the created token so people know to look there.







Implement @jschatz1's comments.
2016-06-09T08:38:49+00:00

Timothy Andrew
mail@timothyandrew.net

2016-06-09T08:38:49+00:00

1f5ecf916ee7b1d34fbf8775890b2aada2055384

- No hardcoded colors in any SCSS file except `variables.scss`
- Don't allow choosing a date in the past
- Use the same table as in the "Applications" tab
- The button should say "Create Personal Access Token"
- Float the revoke button to the right of the table cell
- Change the revocation message to be more explicit.
- Date shouldn't look selected on page load
- Don't use a panel for the created token
    - Use a normal flash for "Your new personal access token has been created"
    - Show the input (with the token) below it full width.
    - Put the "Make sure you save it - you won't be able to access it again." message near the input
- Have the created token's input highlight all on single click





- No hardcoded colors in any SCSS file except `variables.scss`
- Don't allow choosing a date in the past
- Use the same table as in the "Applications" tab
- The button should say "Create Personal Access Token"
- Float the revoke button to the right of the table cell
- Change the revocation message to be more explicit.
- Date shouldn't look selected on page load
- Don't use a panel for the created token
    - Use a normal flash for "Your new personal access token has been created"
    - Show the input (with the token) below it full width.
    - Put the "Make sure you save it - you won't be able to access it again." message near the input
- Have the created token's input highlight all on single click







Add tests for errors while creating/revoking personal access tokens.
2016-06-03T04:30:03+00:00

Timothy Andrew
mail@timothyandrew.net

2016-06-03T04:23:49+00:00

3adf125a155fd04fbba4f0882c739eae1cc73e15












Don't use `natve['innerHTML']` in the feature spec.
2016-06-03T03:28:15+00:00

Timothy Andrew
mail@timothyandrew.net

2016-06-03T03:28:15+00:00

a1295d8ebef223eb0a87bc9e1660efcb9147599c

- The `have_text` matcher works fine.





- The `have_text` matcher works fine.