<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/javascripts/notes/stores, branch docs-sethgitlab-featureflags</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add edit_note and spec for editing quick actions</title>
<updated>2019-08-26T09:20:00+00:00</updated>
<author>
<name>Patrick Derichs</name>
<email>pderichs@gitlab.com</email>
</author>
<published>2019-08-26T09:20:00+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a13abd6731ecc3dc24017729c019ad6af9a7b114'/>
<id>a13abd6731ecc3dc24017729c019ad6af9a7b114</id>
<content type='text'>
Call QuickActionsService on Note update

Add support for notes which just contain
commands after editing

Return http status gone (410) if note was deleted

Temporary frontend addition so it is not
failing when a note is deleted

Move specs to shared examples

Fix rubocop style issue

Deleting note on frontend when status is 410

Use guard clause for note which got deleted

Simplified condition for nil note

This method should no longer be called
with nil note

Refactoring of execute method to reduce
complexity

Move errors update to delete_note method

Note is now deleted visually when it only
contains commands after update

Add expectation

Fix style issues

Changing action to fix tests

Add tests for removeNote and update
deleteNote expectations
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Call QuickActionsService on Note update

Add support for notes which just contain
commands after editing

Return http status gone (410) if note was deleted

Temporary frontend addition so it is not
failing when a note is deleted

Move specs to shared examples

Fix rubocop style issue

Deleting note on frontend when status is 410

Use guard clause for note which got deleted

Simplified condition for nil note

This method should no longer be called
with nil note

Refactoring of execute method to reduce
complexity

Move errors update to delete_note method

Note is now deleted visually when it only
contains commands after update

Add expectation

Fix style issues

Changing action to fix tests

Add tests for removeNote and update
deleteNote expectations
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor nextUnresolvedDiscussionId and previousUnresolvedDiscussionId getters</title>
<updated>2019-08-15T19:07:20+00:00</updated>
<author>
<name>Arun Kumar Mohan</name>
<email>arunmohandm@gmail.com</email>
</author>
<published>2019-08-13T06:04:10+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b179b752e8024679e6ce6fbd2a5fe1da17fef3f6'/>
<id>b179b752e8024679e6ce6fbd2a5fe1da17fef3f6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add kbd shortcuts for discussion navigation</title>
<updated>2019-08-12T06:41:04+00:00</updated>
<author>
<name>Sam Bigelow</name>
<email>sbigelow@gitlab.com</email>
</author>
<published>2019-08-12T06:41:04+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eba44228039d54ef3b84db4cf695a9058beb166d'/>
<id>eba44228039d54ef3b84db4cf695a9058beb166d</id>
<content type='text'>
Add keyboard shortcuts `p` and `n` to navigate duscussions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add keyboard shortcuts `p` and `n` to navigate duscussions.
</pre>
</div>
</content>
</entry>
<entry>
<title>Do not persist notes filter when auto-switching</title>
<updated>2019-08-07T15:45:23+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-08-07T15:45:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b689ddd9b6d7ebed2f4d014a77ee223df2d3491b'/>
<id>b689ddd9b6d7ebed2f4d014a77ee223df2d3491b</id>
<content type='text'>
Send a `persist_filter: false` param to backend when
opening links to notes and auto-switching to show
all notes
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Send a `persist_filter: false` param to backend when
opening links to notes and auto-switching to show
all notes
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove deleteNote from notes service</title>
<updated>2019-07-10T16:48:15+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-07-10T16:48:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=49d5cc34ca60191669550726b357e6bef475d68d'/>
<id>49d5cc34ca60191669550726b357e6bef475d68d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove applySuggestion from notes service</title>
<updated>2019-07-05T22:59:30+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-07-05T22:59:30+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=23bd46cf015aebcb34d125c705915f164d756762'/>
<id>23bd46cf015aebcb34d125c705915f164d756762</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typo in updateResolvableDiscussionsCounts action</title>
<updated>2019-07-02T23:11:13+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-07-02T23:11:13+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c2429ed55349ea7cbf6a054eefe0ad174fbcd085'/>
<id>c2429ed55349ea7cbf6a054eefe0ad174fbcd085</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rearrange discussion resolve buttons &amp; update button display</title>
<updated>2019-06-28T07:32:03+00:00</updated>
<author>
<name>Samantha Ming</name>
<email>sming@gitlab.com</email>
</author>
<published>2019-06-28T07:32:03+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4bf043435906db75fa9543db96991b8cc7171f46'/>
<id>4bf043435906db75fa9543db96991b8cc7171f46</id>
<content type='text'>
- next-discuss button is always show unless there is only 1 discussion
- regroup buttons arrangements
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- next-discuss button is always show unless there is only 1 discussion
- regroup buttons arrangements
</pre>
</div>
</content>
</entry>
<entry>
<title>Add failing test for saveNote error handling</title>
<updated>2019-05-07T21:15:36+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-05-03T21:11:55+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0625ccc652f97310b2444bb16ed8e20ee0642300'/>
<id>0625ccc652f97310b2444bb16ed8e20ee0642300</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve discussion when suggestion is applied</title>
<updated>2019-05-07T05:00:40+00:00</updated>
<author>
<name>Paul Slaughter</name>
<email>pslaughter@gitlab.com</email>
</author>
<published>2019-05-06T17:56:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d24d77a93a64e4698163c5ca579954f61ad9248a'/>
<id>d24d77a93a64e4698163c5ca579954f61ad9248a</id>
<content type='text'>
- Adds color and a tooltip to describe this new behavior
- Does not resolve if discussion is already resolved
- Adds an action `resolveDiscussion` to simplify `toggleResolveNote`
- Updates docs

https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Adds color and a tooltip to describe this new behavior
- Does not resolve if discussion is already resolved
- Adds an action `resolveDiscussion` to simplify `toggleResolveNote`
- Updates docs

https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
</pre>
</div>
</content>
</entry>
</feed>
