delta/gitlab/gitlab-ce.git/spec/models/user_spec.rb, branch ref-dropdown-jquery-objects

Add a blank line between before and it:

2016-06-07T14:34:09+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12301563

Avoid using subject and is_expected.to:

2016-06-07T14:34:09+00:00

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12274602

Prefer do and end for before/after:

2016-06-07T14:34:09+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12217415

Fix method definition style

2016-06-07T14:34:09+00:00

Use rspec's matchers and update style:

2016-06-07T14:34:09+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12194552

Use subject for more consistent testing style:

2016-06-07T14:34:09+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12194489

This is easier to write:

2016-06-07T14:34:09+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12194471

Add a test for User#ci_authorized_runners

2016-06-07T14:34:09+00:00

Add a `U2fRegistrations` table/model.

2016-06-06T07:20:31+00:00

- To hold registrations from U2F devices, and to authenticate them.
- Previously, `User#two_factor_enabled` was aliased to the
  `otp_required_for_login` column on `users`.
- This commit changes things a bit:
    - `User#two_factor_enabled` is not a method anymore
    - `User#two_factor_enabled?` checks both the
      `otp_required_for_login` column, as well as `U2fRegistration`s
    - Change all instances of `User#two_factor_enabled` to
      `User#two_factor_enabled?`
- Add the `u2f` gem, and implement registration/authentication at the
  model level.

Merge branch 'master' into awardables

2016-06-03T13:20:11+00:00