delta/gitlab/gitlab-ce.git/spec/views/admin, branch git-write-ref-prep gitlab.com: gitlab-org/gitlab-ce.git `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31T12:38:33+00:00 Sean McGivern sean@gitlab.com 2017-08-31T09:47:03+00:00 5883ce95efcc4cc04f949f9b4e66d73fbede94e2 The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form. 
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
Change all `:empty_project` to `:project` 2017-08-02T21:47:31+00:00 Robert Speicher rspeicher@gmail.com 2017-08-02T19:55:11+00:00 72a7b30c9f363063449b28aa9efc3a26a1752f9f 






Upgrade Devise from 4.1.1 to 4.2.0.
2016-09-28T02:08:49+00:00

Connor Shea
connor.james.shea@gmail.com

2016-09-21T23:06:33+00:00

8062380f60df576478677e9819ff602303166e4d

This fixes an issue with Rails 5 and brings us up-to-date with the latest Devise release.

This also replaces the deprecated Devise::TestHelpers with Devise::Test::ControllerHelpers.

Changelog: https://github.com/plataformatec/devise/blob/v4.2.0/CHANGELOG.md#420---2016-07-01





This fixes an issue with Rails 5 and brings us up-to-date with the latest Devise release.

This also replaces the deprecated Devise::TestHelpers with Devise::Test::ControllerHelpers.

Changelog: https://github.com/plataformatec/devise/blob/v4.2.0/CHANGELOG.md#420---2016-07-01







Add gitlab-workhorse version to admin dashboard
2016-07-23T04:56:32+00:00

Katarzyna Kobierska
kkobierska@gmail.com

2016-07-18T11:58:08+00:00

10d9df28ec3b494361abcee27ffddece580bbf3a

Test for showing GitLab Workhorse version on Admin Dashboard

Refactoring





Test for showing GitLab Workhorse version on Admin Dashboard

Refactoring