diff options
| author | Shinya Maeda <shinya@gitlab.com> | 2018-10-04 15:11:36 +0900 |
|---|---|---|
| committer | Shinya Maeda <shinya@gitlab.com> | 2018-10-04 15:11:36 +0900 |
| commit | 10b09db46ddfdc6dfab55fa9671e716cd46a565b (patch) | |
| tree | 7726a58c031d7df9d4ab4f16e027f00a9452d18b | |
| parent | 5381985bd012562696637122b1dcd067480a94d3 (diff) | |
| download | gitlab-ce-10b09db46ddfdc6dfab55fa9671e716cd46a565b.tar.gz | |
Avoid conflicts between enumlator's schedule! method and state machine's schedule! method
| -rw-r--r-- | app/models/ci/pipeline.rb | 2 | ||||
| -rw-r--r-- | app/workers/pipeline_schedule_worker.rb | 2 | ||||
| -rw-r--r-- | app/workers/run_pipeline_schedule_worker.rb | 2 | ||||
| -rw-r--r-- | spec/workers/pipeline_schedule_worker_spec.rb | 2 | ||||
| -rw-r--r-- | spec/workers/run_pipeline_schedule_worker_spec.rb | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index b74c65c2627..1e76cbe7c01 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -63,7 +63,7 @@ module Ci push: 1, web: 2, trigger: 3, - schedule: 4, + source_schedule: 4, api: 5, external: 6 } diff --git a/app/workers/pipeline_schedule_worker.rb b/app/workers/pipeline_schedule_worker.rb index 85d1ffe0fa9..412df94d238 100644 --- a/app/workers/pipeline_schedule_worker.rb +++ b/app/workers/pipeline_schedule_worker.rb @@ -12,7 +12,7 @@ class PipelineScheduleWorker pipeline = Ci::CreatePipelineService.new(schedule.project, schedule.owner, ref: schedule.ref) - .execute(:schedule, ignore_skip_ci: true, save_on_errors: false, schedule: schedule) + .execute(:source_schedule, ignore_skip_ci: true, save_on_errors: false, schedule: schedule) schedule.deactivate! unless pipeline.persisted? rescue => e diff --git a/app/workers/run_pipeline_schedule_worker.rb b/app/workers/run_pipeline_schedule_worker.rb index f72331c003a..626c3e23f73 100644 --- a/app/workers/run_pipeline_schedule_worker.rb +++ b/app/workers/run_pipeline_schedule_worker.rb @@ -21,6 +21,6 @@ class RunPipelineScheduleWorker Ci::CreatePipelineService.new(schedule.project, user, ref: schedule.ref) - .execute(:schedule, ignore_skip_ci: true, save_on_errors: false, schedule: schedule) + .execute(:source_schedule, ignore_skip_ci: true, save_on_errors: false, schedule: schedule) end end diff --git a/spec/workers/pipeline_schedule_worker_spec.rb b/spec/workers/pipeline_schedule_worker_spec.rb index a2fe4734d47..3ce394789be 100644 --- a/spec/workers/pipeline_schedule_worker_spec.rb +++ b/spec/workers/pipeline_schedule_worker_spec.rb @@ -25,7 +25,7 @@ describe PipelineScheduleWorker do shared_examples 'successful scheduling' do it 'creates a new pipeline' do expect { subject }.to change { project.pipelines.count }.by(1) - expect(Ci::Pipeline.last).to be_schedule + expect(Ci::Pipeline.last).to be_source_schedule pipeline_schedule.reload expect(pipeline_schedule.next_run_at).to be > Time.now diff --git a/spec/workers/run_pipeline_schedule_worker_spec.rb b/spec/workers/run_pipeline_schedule_worker_spec.rb index 481a84837f9..afda3d9287b 100644 --- a/spec/workers/run_pipeline_schedule_worker_spec.rb +++ b/spec/workers/run_pipeline_schedule_worker_spec.rb @@ -30,7 +30,7 @@ describe RunPipelineScheduleWorker do it 'calls the Service' do expect(Ci::CreatePipelineService).to receive(:new).with(project, user, ref: pipeline_schedule.ref).and_return(create_pipeline_service) - expect(create_pipeline_service).to receive(:execute).with(:schedule, ignore_skip_ci: true, save_on_errors: false, schedule: pipeline_schedule) + expect(create_pipeline_service).to receive(:execute).with(:source_schedule, ignore_skip_ci: true, save_on_errors: false, schedule: pipeline_schedule) worker.perform(pipeline_schedule.id, user.id) end |
