1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
|
import {
updateChangesTabCount,
getDerivedMergeRequestInformation,
} from '~/diffs/utils/merge_request';
import { ZERO_CHANGES_ALT_DISPLAY } from '~/diffs/constants';
import { diffMetadata } from '../mock_data/diff_metadata';
describe('Merge Request utilities', () => {
const derivedBaseInfo = {
mrPath: '/gitlab-org/gitlab-test/-/merge_requests/4',
namespace: 'gitlab-org',
project: 'gitlab-test',
id: '4',
};
const derivedVersionInfo = {
diffId: '4',
startSha: 'eb227b3e214624708c474bdab7bde7afc17cefcc',
};
const noVersion = {
diffId: undefined,
startSha: undefined,
};
const unparseableEndpoint = {
mrPath: undefined,
namespace: undefined,
project: undefined,
id: undefined,
...noVersion,
};
describe('updateChangesTabCount', () => {
let dummyTab;
let badge;
beforeEach(() => {
dummyTab = document.createElement('div');
dummyTab.classList.add('js-diffs-tab');
dummyTab.insertAdjacentHTML('afterbegin', '<span class="gl-badge">ERROR</span>');
badge = dummyTab.querySelector('.gl-badge');
});
afterEach(() => {
dummyTab.remove();
dummyTab = null;
badge = null;
});
it('uses the alt hyphen display when the new changes are falsey', () => {
updateChangesTabCount({ count: 0, badge });
expect(dummyTab.textContent).toBe(ZERO_CHANGES_ALT_DISPLAY);
updateChangesTabCount({ badge });
expect(dummyTab.textContent).toBe(ZERO_CHANGES_ALT_DISPLAY);
updateChangesTabCount({ count: false, badge });
expect(dummyTab.textContent).toBe(ZERO_CHANGES_ALT_DISPLAY);
});
it('uses the actual value for display when the value is truthy', () => {
updateChangesTabCount({ count: 42, badge });
expect(dummyTab.textContent).toBe('42');
updateChangesTabCount({ count: '999+', badge });
expect(dummyTab.textContent).toBe('999+');
});
it('selects the proper element to modify by default', () => {
document.body.insertAdjacentElement('afterbegin', dummyTab);
updateChangesTabCount({ count: 42 });
expect(dummyTab.textContent).toBe('42');
});
});
describe('getDerivedMergeRequestInformation', () => {
const bare = diffMetadata.latest_version_path;
it.each`
argument | response
${{ endpoint: `${bare}.json?searchParam=irrelevant` }} | ${{ ...derivedBaseInfo, ...noVersion }}
${{}} | ${unparseableEndpoint}
${{ endpoint: undefined }} | ${unparseableEndpoint}
${{ endpoint: null }} | ${unparseableEndpoint}
`('generates the correct derived results based on $argument', ({ argument, response }) => {
expect(getDerivedMergeRequestInformation(argument)).toStrictEqual(response);
});
describe('sub-group namespace', () => {
it('extracts the entire namespace plus the project name', () => {
const { namespace, project } = getDerivedMergeRequestInformation({
endpoint: `/some/deep/path/of/groups${bare}`,
});
expect(namespace).toBe('some/deep/path/of/groups/gitlab-org');
expect(project).toBe('gitlab-test');
});
});
describe('version information', () => {
it('still gets the correct derived information', () => {
expect(
getDerivedMergeRequestInformation({
endpoint: diffMetadata.merge_request_diffs[0].compare_path,
}),
).toMatchObject(derivedBaseInfo);
});
it.each`
url | versionPart
${diffMetadata.merge_request_diffs[0].compare_path} | ${derivedVersionInfo}
${`${bare}?diff_id=${derivedVersionInfo.diffId}`} | ${{ ...derivedVersionInfo, startSha: undefined }}
${`${bare}?start_sha=${derivedVersionInfo.startSha}`} | ${{ ...derivedVersionInfo, diffId: undefined }}
`(
'generates the correct derived version information based on $url',
({ url, versionPart }) => {
expect(getDerivedMergeRequestInformation({ endpoint: url })).toMatchObject(versionPart);
},
);
it('extracts nothing if there is no available version-like information in the URL', () => {
expect(getDerivedMergeRequestInformation({ endpoint: bare })).toMatchObject(noVersion);
});
});
});
});
|
