<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git, branch pb-remove-gitlab-keys</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Remove gitlab-keys script</title>
<updated>2019-08-23T06:15:33+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-08-23T06:15:33+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=cb9b5447eb8cb8ae6535ebf90e5a5e9e724721bd'/>
<id>cb9b5447eb8cb8ae6535ebf90e5a5e9e724721bd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Release v9.4.1</title>
<updated>2019-08-20T18:01:19+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2019-08-20T18:01:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=27ac932878d117d1cbffc0d190ed179f3353886c'/>
<id>27ac932878d117d1cbffc0d190ed179f3353886c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'jv-fix-compile-gdk' into 'master'</title>
<updated>2019-08-20T17:43:39+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2019-08-20T17:43:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=4083df3d24735db731067baed06f3827bbc93c32'/>
<id>4083df3d24735db731067baed06f3827bbc93c32</id>
<content type='text'>
Fix bin/compile in GDK

Closes gitlab-development-kit#585

See merge request gitlab-org/gitlab-shell!327</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix bin/compile in GDK

Closes gitlab-development-kit#585

See merge request gitlab-org/gitlab-shell!327</pre>
</div>
</content>
</entry>
<entry>
<title>Fix bin/compile in GDK</title>
<updated>2019-08-20T17:43:39+00:00</updated>
<author>
<name>Jacob Vosmaer</name>
<email>jacob@gitlab.com</email>
</author>
<published>2019-08-20T17:43:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=4bfbf9bf460cb5154e320e3f29efe11a90daa6e0'/>
<id>4bfbf9bf460cb5154e320e3f29efe11a90daa6e0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'release-9-4-0' into 'master'</title>
<updated>2019-08-20T06:42:03+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-08-20T06:42:03+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=19da8838e5ad38b353453232b25a5011fe1eceb8'/>
<id>19da8838e5ad38b353453232b25a5011fe1eceb8</id>
<content type='text'>
Release v9.4.0

See merge request gitlab-org/gitlab-shell!325</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Release v9.4.0

See merge request gitlab-org/gitlab-shell!325</pre>
</div>
</content>
</entry>
<entry>
<title>Release v9.4.0</title>
<updated>2019-08-19T07:46:06+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-08-19T07:46:06+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=151b8ee3fdc53e3fce1f43df13e9078b61ba3af6'/>
<id>151b8ee3fdc53e3fce1f43df13e9078b61ba3af6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'jv-go-mod' into 'master'</title>
<updated>2019-08-19T05:02:05+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-08-19T05:02:05+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=256c97066bb7838d43798b6760d3acbb82c44263'/>
<id>256c97066bb7838d43798b6760d3acbb82c44263</id>
<content type='text'>
Use go mod

See merge request gitlab-org/gitlab-shell!323</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use go mod

See merge request gitlab-org/gitlab-shell!323</pre>
</div>
</content>
</entry>
<entry>
<title>Use go mod</title>
<updated>2019-08-19T05:02:05+00:00</updated>
<author>
<name>Jacob Vosmaer</name>
<email>jacob@gitlab.com</email>
</author>
<published>2019-08-19T05:02:05+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=4d330cb1dd0fa2d6470d459fc33a987e8f550887'/>
<id>4d330cb1dd0fa2d6470d459fc33a987e8f550887</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '206-quick-fix' into 'master'</title>
<updated>2019-08-15T11:03:21+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-08-15T11:03:21+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=81f5854513a527c3a00398e91930a12ebad70272'/>
<id>81f5854513a527c3a00398e91930a12ebad70272</id>
<content type='text'>
Replace symlinks with actual binaries

Closes #206

See merge request gitlab-org/gitlab-shell!324</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace symlinks with actual binaries

Closes #206

See merge request gitlab-org/gitlab-shell!324</pre>
</div>
</content>
</entry>
<entry>
<title>Replace symlinks with actual binaries</title>
<updated>2019-08-15T10:15:49+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-08-15T10:06:04+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=41f919eb86a3b1f69876f8b97572615b06521538'/>
<id>41f919eb86a3b1f69876f8b97572615b06521538</id>
<content type='text'>
We had `gitlab-shell-authorized-keys-check` and
`gitlab-shell-authorized-principals-check` as symlinks to
`gitlab-shell` before.

We determine the `Command` and `CommandArgs` that we build based
on the `Name` of the `Executable`. We also use that to know which
fallback ruby executable should we fallback to. We use
`os.Executable()` to do that.

`os.Executable()` behaves differently depending on OS. It may
return the symlink or the target's name. That can result to a
buggy behavior.

The fix is to create binaries for each instead of using a symlink.
That way we don't need to rely on `os.Executable()` to get the name.
We pass the `Name` of the executable instead.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We had `gitlab-shell-authorized-keys-check` and
`gitlab-shell-authorized-principals-check` as symlinks to
`gitlab-shell` before.

We determine the `Command` and `CommandArgs` that we build based
on the `Name` of the `Executable`. We also use that to know which
fallback ruby executable should we fallback to. We use
`os.Executable()` to do that.

`os.Executable()` behaves differently depending on OS. It may
return the symlink or the target's name. That can result to a
buggy behavior.

The fix is to create binaries for each instead of using a symlink.
That way we don't need to rely on `os.Executable()` to get the name.
We pass the `Name` of the executable instead.
</pre>
</div>
</content>
</entry>
</feed>
