<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git, branch sh-fix-logrus-race</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Fix race conditions with logrus testing</title>
<updated>2020-05-12T05:31:13+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-12T05:02:58+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=0372634076cdfd7cda740cd040e16e629ea662e4'/>
<id>0372634076cdfd7cda740cd040e16e629ea662e4</id>
<content type='text'>
logrus fires a Goroutine to write logs, so the tests could fail if they
checked the event queue before the logrus have fired.  Since there isn't
an easy way to flush all outstanding hooks, we just retry every 100 ms
for up to a second for log to arrive in the queue.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
logrus fires a Goroutine to write logs, so the tests could fail if they
checked the event queue before the logrus have fired.  Since there isn't
an easy way to flush all outstanding hooks, we just retry every 100 ms
for up to a second for log to arrive in the queue.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-add-http-status-code' into 'master'</title>
<updated>2020-05-11T13:42:28+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2020-05-11T13:42:28+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=940aa912784b2e99d6f2a767f13bd013a62c94f8'/>
<id>940aa912784b2e99d6f2a767f13bd013a62c94f8</id>
<content type='text'>
Add HTTP status code to internal API logs

Closes #450

See merge request gitlab-org/gitlab-shell!376</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add HTTP status code to internal API logs

Closes #450

See merge request gitlab-org/gitlab-shell!376</pre>
</div>
</content>
</entry>
<entry>
<title>Fix race conditions in tests</title>
<updated>2020-05-08T22:40:18+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-08T22:40:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=c0cf314c5722a4f7ec0a1f355d23fa2511344989'/>
<id>c0cf314c5722a4f7ec0a1f355d23fa2511344989</id>
<content type='text'>
Calling logrus hook.LastEntry() can lead to race conditions.  Use
AllEntries instead:
https://github.com/sirupsen/logrus/blob/60c74ad9be0d874af0ab0daef6ab07c5c5911f0d/hooks/test/test.go#L77

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Calling logrus hook.LastEntry() can lead to race conditions.  Use
AllEntries instead:
https://github.com/sirupsen/logrus/blob/60c74ad9be0d874af0ab0daef6ab07c5c5911f0d/hooks/test/test.go#L77

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</pre>
</div>
</content>
</entry>
<entry>
<title>Add HTTP status code to internal API logs</title>
<updated>2020-05-08T21:59:35+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-08T21:56:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=1adadc2e299529e805aae3dac7c2579b88c8dae7'/>
<id>1adadc2e299529e805aae3dac7c2579b88c8dae7</id>
<content type='text'>
This would make it easier to filter the logs by status code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This would make it easier to filter the logs by status code.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'release-13-1-0' into 'master'</title>
<updated>2020-05-06T21:33:41+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-05-06T21:33:41+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=716e30c55e893ebe2385b27f85902a789f26c6ef'/>
<id>716e30c55e893ebe2385b27f85902a789f26c6ef</id>
<content type='text'>
Release v13.1.0

See merge request gitlab-org/gitlab-shell!382</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Release v13.1.0

See merge request gitlab-org/gitlab-shell!382</pre>
</div>
</content>
</entry>
<entry>
<title>Release v13.1.0</title>
<updated>2020-05-06T21:28:31+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-05-06T21:28:31+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=aa28765034f50fb2954e44f798e237cc66771b62'/>
<id>aa28765034f50fb2954e44f798e237cc66771b62</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'pass-secret-to-client' into 'master'</title>
<updated>2020-05-06T21:26:46+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-05-06T21:26:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=cee449e5b1e18cfae290d29ebaef0bf90fc596df'/>
<id>cee449e5b1e18cfae290d29ebaef0bf90fc596df</id>
<content type='text'>
Ensure we are passing the parsed secret

Closes #458

See merge request gitlab-org/gitlab-shell!381</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ensure we are passing the parsed secret

Closes #458

See merge request gitlab-org/gitlab-shell!381</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure we are passing the parsed secret</title>
<updated>2020-05-06T20:57:01+00:00</updated>
<author>
<name>DJ Mountney</name>
<email>dj@gitlab.com</email>
</author>
<published>2020-05-06T20:57:01+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=e6482b8797cc34a024429f5ce9e75e11a139fd3b'/>
<id>e6482b8797cc34a024429f5ce9e75e11a139fd3b</id>
<content type='text'>
Rather than the secret file. The parsing of the file was already done in
the gitlab-shell config.

This fixes an issue where a recent refactor of the gitlabnet client
passed the wrong value.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Rather than the secret file. The parsing of the file was already done in
the gitlab-shell config.

This fixes an issue where a recent refactor of the gitlabnet client
passed the wrong value.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'gitlab-shell-release-13-0-0' into 'master'</title>
<updated>2020-05-06T00:30:25+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2020-05-06T00:30:25+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=accd5e5abd03d9f08ca72068e5dafb2df090c7e3'/>
<id>accd5e5abd03d9f08ca72068e5dafb2df090c7e3</id>
<content type='text'>
Release v13.0.0

See merge request gitlab-org/gitlab-shell!379</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Release v13.0.0

See merge request gitlab-org/gitlab-shell!379</pre>
</div>
</content>
</entry>
<entry>
<title>Release v13.0.0</title>
<updated>2020-05-05T20:38:12+00:00</updated>
<author>
<name>John Cai</name>
<email>jcai@gitlab.com</email>
</author>
<published>2020-05-05T20:36:13+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=04a834f6ab8dfc339b7aa05f40786528c3c40409'/>
<id>04a834f6ab8dfc339b7aa05f40786528c3c40409</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
