<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git/internal/command, branch id-context-fields</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Add context fields to logging</title>
<updated>2021-09-15T17:46:08+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-09-15T17:46:00+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=af3aac6b459791fabd8ebc306cdff47c609fbf53'/>
<id>af3aac6b459791fabd8ebc306cdff47c609fbf53</id>
<content type='text'>
It adds correlation ids wherever possible
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It adds correlation ids wherever possible
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: rearchitect command and executable Go modules</title>
<updated>2021-09-08T14:41:57+00:00</updated>
<author>
<name>feistel</name>
<email>6742251-feistel@users.noreply.gitlab.com</email>
</author>
<published>2021-09-08T14:40:35+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=67415dc4f6f293460517d4281b5e4e80e66ffb91'/>
<id>67415dc4f6f293460517d4281b5e4e80e66ffb91</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'remove/generic-args' into 'main'</title>
<updated>2021-09-08T10:06:06+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-09-08T10:06:06+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=7884a4420ac8ffd3ee34589c0f8e0d25ca0fd076'/>
<id>7884a4420ac8ffd3ee34589c0f8e0d25ca0fd076</id>
<content type='text'>
refactor: remove commandargs.GenericArgs

Closes #212

See merge request gitlab-org/gitlab-shell!506</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
refactor: remove commandargs.GenericArgs

Closes #212

See merge request gitlab-org/gitlab-shell!506</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: add acceptargs field to executable</title>
<updated>2021-09-08T09:54:44+00:00</updated>
<author>
<name>feistel</name>
<email>6742251-feistel@users.noreply.gitlab.com</email>
</author>
<published>2021-09-08T09:54:44+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=8b4621aa6cba1674192ffb6e3c3e801a567f2516'/>
<id>8b4621aa6cba1674192ffb6e3c3e801a567f2516</id>
<content type='text'>
parse logic will only run if the executable accept args.
healthcheck is the only one not accepting arguments.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
parse logic will only run if the executable accept args.
healthcheck is the only one not accepting arguments.
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: improve unknown executable error message</title>
<updated>2021-09-08T08:47:56+00:00</updated>
<author>
<name>feistel</name>
<email>6742251-feistel@users.noreply.gitlab.com</email>
</author>
<published>2021-09-08T08:47:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=4f5b7512c3c1ad7b67b044976b5ac3aae413beb2'/>
<id>4f5b7512c3c1ad7b67b044976b5ac3aae413beb2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: move away from ioutil (deprecated)</title>
<updated>2021-08-19T15:54:20+00:00</updated>
<author>
<name>feistel</name>
<email>6742251-feistel@users.noreply.gitlab.com</email>
</author>
<published>2021-08-19T15:54:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=087c010c476ed6c009b6c94a76a7e9db3b9d3fdd'/>
<id>087c010c476ed6c009b6c94a76a7e9db3b9d3fdd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: remove commandargs.GenericArgs</title>
<updated>2021-08-11T17:29:59+00:00</updated>
<author>
<name>feistel</name>
<email>6742251-feistel@users.noreply.gitlab.com</email>
</author>
<published>2021-08-11T17:29:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=fa2cdbda42dc46428377e9d000e164f6fefd8da1'/>
<id>fa2cdbda42dc46428377e9d000e164f6fefd8da1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-300265' into 'main'</title>
<updated>2021-08-04T02:31:15+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2021-08-04T02:31:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=df0138b5f0f8f998a832c6c063128f56d1953604'/>
<id>df0138b5f0f8f998a832c6c063128f56d1953604</id>
<content type='text'>
Modify regex to prevent partial matches

See merge request gitlab-org/security/gitlab-shell!6</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Modify regex to prevent partial matches

See merge request gitlab-org/security/gitlab-shell!6</pre>
</div>
</content>
</entry>
<entry>
<title>Remove some unreliable tests</title>
<updated>2021-07-30T16:11:15+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-07-30T15:09:07+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=72d70eab03d38b7c01054b7c598d17afe177212a'/>
<id>72d70eab03d38b7c01054b7c598d17afe177212a</id>
<content type='text'>
Logrus buffers its output internally, which makes these tests fail
intermittently. They're also not a good example to follow generally.

We now have acceptance tests that exercise this functionality so I'm
pretty relaxed about losing the expectations. However, we can test
them by inspecting the server-received metadata too, so there's no loss
of coverage here.

The move from logrus to labkit for logging also makes these tests hard
to justify keeping.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Logrus buffers its output internally, which makes these tests fail
intermittently. They're also not a good example to follow generally.

We now have acceptance tests that exercise this functionality so I'm
pretty relaxed about losing the expectations. However, we can test
them by inspecting the server-received metadata too, so there's no loss
of coverage here.

The move from logrus to labkit for logging also makes these tests hard
to justify keeping.
</pre>
</div>
</content>
</entry>
<entry>
<title>Switch to labkit/log for logging functionality</title>
<updated>2021-07-22T15:38:47+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-07-22T14:58:58+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-shell.git/commit/?id=fb7b9417842c66e12466e658e861e19619dfcd9a'/>
<id>fb7b9417842c66e12466e658e861e19619dfcd9a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
