Fix handling non 200 response codeszj-fix-non-200-resp-code

After the cleanup in https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/231
gitlab-shell mishandled the non 200 response codes. This commit removes
another few lines of codes, which fixes this. Also now we test against
this case through mocking.

Fixes https://gitlab.com/gitlab-org/gitlab-shell/issues/152

1 files changed, 9 insertions, 0 deletions

diff --git a/spec/gitlab_net_spec.rb b/spec/gitlab_net_spec.rb
index 9f7c462..e14fd83 100644
--- a/spec/gitlab_net_spec.rb
+++ b/spec/gitlab_net_spec.rb
@@ -347,6 +347,15 @@ describe GitlabNet, vcr: true do
       end
     end
 
+    it 'handles non 200 status codes' do
+      resp = double(:resp, code: 501)
+
+      allow(gitlab_net).to receive(:post).and_return(resp)
+
+      access = gitlab_net.check_access('git-upload-pack', nil, project, 'user-2', changes, 'ssh')
+      expect(access).not_to be_allowed
+    end
+
     it "raises an exception if the connection fails" do
       allow_any_instance_of(Net::HTTP).to receive(:request).and_raise(StandardError)
       expect {