diff options
Diffstat (limited to 'internal/command/uploadpack')
-rw-r--r-- | internal/command/uploadpack/gitalycall.go | 5 | ||||
-rw-r--r-- | internal/command/uploadpack/uploadpack.go | 10 |
2 files changed, 11 insertions, 4 deletions
diff --git a/internal/command/uploadpack/gitalycall.go b/internal/command/uploadpack/gitalycall.go index ba0fef2..3ebc8b3 100644 --- a/internal/command/uploadpack/gitalycall.go +++ b/internal/command/uploadpack/gitalycall.go @@ -2,7 +2,6 @@ package uploadpack import ( "context" - "os" "google.golang.org/grpc" @@ -13,7 +12,7 @@ import ( "gitlab.com/gitlab-org/gitlab-shell/internal/handler" ) -func (c *Command) performGitalyCall(response *accessverifier.Response) error { +func (c *Command) performGitalyCall(response *accessverifier.Response, gitProtocolVersion string) error { gc := &handler.GitalyCommand{ Config: c.Config, ServiceName: string(commandargs.UploadPack), @@ -24,7 +23,7 @@ func (c *Command) performGitalyCall(response *accessverifier.Response) error { request := &pb.SSHUploadPackRequest{ Repository: &response.Gitaly.Repo, - GitProtocol: os.Getenv(commandargs.GitProtocolEnv), + GitProtocol: gitProtocolVersion, GitConfigOptions: response.GitConfigOptions, } diff --git a/internal/command/uploadpack/uploadpack.go b/internal/command/uploadpack/uploadpack.go index fca3823..bf5db2c 100644 --- a/internal/command/uploadpack/uploadpack.go +++ b/internal/command/uploadpack/uploadpack.go @@ -2,6 +2,7 @@ package uploadpack import ( "context" + "os" "gitlab.com/gitlab-org/gitlab-shell/internal/command/commandargs" "gitlab.com/gitlab-org/gitlab-shell/internal/command/readwriter" @@ -38,7 +39,14 @@ func (c *Command) Execute(ctx context.Context) error { return customAction.Execute(ctx, response) } - return c.performGitalyCall(response) + var gitProtocolVersion string + if c.Args.RemoteAddr != nil { + gitProtocolVersion = c.Args.GitProtocolVersion + } else { + gitProtocolVersion = os.Getenv(commandargs.GitProtocolEnv) + } + + return c.performGitalyCall(response, gitProtocolVersion) } func (c *Command) verifyAccess(ctx context.Context, repo string) (*accessverifier.Response, error) { |