summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* Print console messages to $stderr if present9217-warn-on-git-fetch-over-ssh-if-the-secondary-is-lagging-the-primaryAsh McKenzie2019-04-042-3/+9
| | | | Using ConsoleHelper::write_stderr
* Use write_stderr instead of $stderr.putsAsh McKenzie2019-04-042-5/+10
|
* New ConsoleHelper moduleAsh McKenzie2019-04-041-0/+17
| | | | | .write_stderr .format_for_stderr
* Explicitly include gitlab_access_status.rbAsh McKenzie2019-04-041-0/+1
|
* Remove hooks, they belong to Gitaly nowJacob Vosmaer2019-04-034-267/+0
|
* Rename print_broadbast method to be genericdisplay-post-receive-warningsLuke Duncalfe2019-04-011-3/+3
| | | | | | print_warnings is now using that method in order to print a large formatted warning message, so renaming the method to be less tied to the broadcast message functionality.
* Allow GitlabPostReceive to print warningsLuke Duncalfe2019-03-281-0/+6
| | | | | | Warnings are printed using the same method that prints broadcast messages. This ensures that whatever warnings are returned will be displayed correctly.
* Add support for using gl_project_pathsh-use-gl-project-pathStan Hu2019-02-162-3/+8
| | | | | | This will enable us to track the human-readable project path with SSH access in gitlab-shell. Currently the Gitaly logs will only show the hashed storage and gl_repository path (e.g. project-1234).
* Provide expires_in for LFS if available57353-git-push-fails-on-large-lfs-files-where-the-push-take-a-long-timeAsh McKenzie2019-02-141-10/+23
|
* Make better use of constants in lib/gitlab_shell.rbJacob Vosmaer2018-12-211-5/+5
|
* Gitaly hook transistion changesJacob Vosmaer2018-12-202-2/+7
|
* Disable rubocop for old (<2.2) hash syntaxJonathon Reinhart2018-12-131-1/+1
| | | | See the discussion on gitlab-org/gitlab-shell!166
* Use `module_fuction` instead of `extend self`Jonathon Reinhart2018-12-131-1/+1
| | | | https://github.com/rubocop-hq/ruby-style-guide#module-function
* Use 'push_options' everywhere instead of 'push_opts'Jonathon Reinhart2018-12-132-5/+5
|
* Pass push options to GitLab /internal/post_receive APIJonathon Reinhart2018-12-132-4/+6
| | | | | | | | | | push_opts[] is named as such so that it becomes an array in the GitLab internal Grape::API params hash. If it were named push_opts, only the final (scalar) push_opts parameter would be present. Also update specs to include push_opts parameter: - gitlab_post_receive_spec - gitlab_net_spec for the internal API change
* Add lib/hooks_utils.rbJonathon Reinhart2018-12-131-0/+15
| | | | | | | This module is responsible for converting the GIT_PUSH_OPTION_* environment variables into an array. See https://gitlab.com/gitlab-org/gitlab-ce/issues/18667
* Remove unused lib/names_helper.rbJonathon Reinhart2018-12-133-10/+0
| | | | As of 7eb45672b7, NamesHelper is no longer used.
* Remove circular dependency between HTTPHelper and GitlabNetsh-fix-circular-dependency-errorsStan Hu2018-11-273-3/+5
| | | | | | | | | HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet included HttpHelper. Specs in Ruby 2.5 were breaking as a result of Action::Custom not able to reference constants in GitLabNet: https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702. Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169
* Include LFS operation when making auth requestashmckenzie/8114-geo-push-ssh-lfs-http-auth-bugAsh McKenzie2018-11-082-18/+13
| | | | Operation is either upload or download
* Changes the HTTP error code from Gateway timeout to Service Unavailableadd-http-gateway-time-out-handlingTiago Botelho2018-10-241-1/+1
|
* Adds handling of Net::HTTPGatewayTimeOut exception to GitlabNetTiago Botelho2018-10-241-1/+1
|
* Display helpful feedback when proxying an SSH git push to secondary request ↵Ash McKenzie2018-09-255-36/+34
| | | | (v2)
* Merge branch 'ash.mckenzie/display-feedback' into 'master'Stan Hu2018-09-132-3/+10
|\ | | | | | | | | Display helpful feedback when proxying an SSH git push to secondary request See merge request gitlab-org/gitlab-shell!244
| * Print message to $stderr for custom actionAsh McKenzie2018-09-131-0/+6
| |
| * Make ordered expectations around results outputAsh McKenzie2018-09-131-2/+2
| | | | | | | | This also cleans up the output from the tests as previously, Base64 encoded output was printed.
| * Consider 300 a successful response alsoAsh McKenzie2018-09-131-1/+2
| |
* | Merge branch 'sh-fix-nonatomic-puts' into 'master'v8.3.2Nick Thomas2018-09-121-2/+3
|\ \ | |/ |/| | | | | | | | | Fix newlines not appearing between new log entries Closes gitlab-com/gl-infra/infrastructure#5017 See merge request gitlab-org/gitlab-shell!242
| * Fix newlines not appearing between new log entriessh-fix-nonatomic-putsStan Hu2018-09-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/5017, we observed that lots of log messages were being dropped by Fluentd due to missing newlines. This occurs because there is a bug in Ruby where IO#puts calls write() twice: once to write the main text, and another to write the newline (https://bugs.ruby-lang.org/issues/14042). In a highly concurrent environment like GitLab.com, this can lead to interleaved newlines. A workaround is to use `IO#print` and append the newline ourselves. Closes https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/5017
* | Ensure text/plain & text/html content typs are handled and add missing specs ↵Ash McKenzie2018-09-113-6/+11
|/ | | | for handled HTTP status codes
* Only decode result body if it has content upon custom action failureStan Hu2018-09-071-1/+3
|
* Custom Action supportash.mckenzie/custom-action-supportAsh McKenzie2018-09-085-17/+175
|
* GitlabAccessStatus needs HTTP response status codeAsh McKenzie2018-09-071-2/+4
|
* Use constants for git commands in GitlabShellAsh McKenzie2018-09-071-6/+11
|
* New HTTPCodes moduleAsh McKenzie2018-09-071-0/+3
|
* GitAccessStatus initializer sensible defaultsAsh McKenzie2018-09-072-9/+2
|
* Move some GitlabNet requires into HTTPHelperAsh McKenzie2018-09-072-2/+2
|
* /api/v4/allowed returns proper HTTP status codesAsh McKenzie2018-09-071-1/+2
| | | | | * Previously, a 200 (OK) was sent when the user was unauthorised or the project was not found (or the user didn't have access) * We still treat 401 and 404 as 'success' but we need to explicitly handle them
* New HTTPCodes moduleAsh McKenzie2018-09-072-0/+9
|
* Fix handling non 200 response codeszj-fix-non-200-resp-codeZeger-Jan van de Weg2018-09-052-2/+1
| | | | | | | | | After the cleanup in https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/231 gitlab-shell mishandled the non 200 response codes. This commit removes another few lines of codes, which fixes this. Also now we test against this case through mocking. Fixes https://gitlab.com/gitlab-org/gitlab-shell/issues/152
* Clean up cmd_exec execution environmentZeger-Jan van de Weg2018-08-242-67/+16
| | | | | | | | | | | Given the gitaly-* now proxy the data from the client to the Gitaly server, the environment variables aren't used. Therefor we don't have to set them either. Only exception to the rule, is the GITALY_TOKEN. These changes also remove the `GIT_TRACE` options, introduced by 192e2bd367494bf66746c8971896a2d9cb84fc92. Part of: https://gitlab.com/gitlab-org/gitaly/issues/1300
* Remove non Gitaly code pathsZeger-Jan van de Weg2018-08-201-23/+23
| | | | | | | All shell access goes through Gitaly, so dead code paths exist to support the legacy way too. This change mostly removes the dead code from `#process_cmd`.
* Remove repo_path from GitlabShellzj-remove-repo-pathZeger-Jan van de Weg2018-08-162-13/+2
| | | | | | | | | | | | | | | The internal api returns '/' from gitlab, since `8fad07383ada021fc995294fd0fe0f77fe37da35` from GitLab CE. To clean up later, https://gitlab.com/gitlab-org/gitlab-shell/issues/135 was created. This change closes that issue, making it possible to remove the field from the response on GitLab-CE too. Given the Rails app always returns `/` as the repository_path, the associated checks are basically a noop too. The tests are updated and at times look a little fishy, but those are testing code that is to be removed in another MR. Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/135
* Fix a RuboCop warningRobert Speicher2018-08-151-1/+1
|
* Override `ROOT_PATH` in specs in a less insane wayRobert Speicher2018-08-151-1/+1
|
* Merge remote-tracking branch 'upstream/8-1-stable' into ↵Nick Thomas2018-08-141-1/+1
|\ | | | | | | 148-merge-8-1-1-to-master
| * Guard discovery by username or key against bad API responsesNick Thomas2018-08-091-1/+1
| |
| * Fix two regressions in SSH certificate supportÆvar Arnfjörð Bjarmason2018-08-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix two regressions in my 2e8b670 ("Add support for SSH certificate authentication", 2018-06-14) merged in gitlab-org/gitlab-shell!207. This fixes the issue noted in gitlab-org/gitlab-shell#145 where the command-line contains things other than the key/user/username, and also a regression where SSH certificates are being used, and the username presented in the key is unknown to GitLab. In that case, we should log the user in as "Anonymous" (on an instance that allows public access), but because of how the error checking around api.discover() was implemented we ended up erroring out instead.
* | Restore "Pass custom git_config_options to Gitalyo"Nick Thomas2018-08-143-2/+7
| | | | | | | | This reverts commit 764f6f47fa6a8698ae033532ae49875a87030518.
* | Revert "Merge branch 'ash.mckenzie/srp-refactor' into 'master'"Nick Thomas2018-08-1419-564/+397
| | | | | | | | | | This reverts commit 3aaf4751e09262c53544a1987f59b1308af9b6c1, reversing changes made to c6577e0d75f51b017f2f332838b97c3ca5b497c0.
* | Revert "Pass custom git_config_options to Gitalyo"Nick Thomas2018-08-141-5/+2
| | | | | | | | This reverts commit f4ce4a3c31a9a7fb2fa0bb7daa185d34b8c03c00.
View Lorry Controller Status