From 1adadc2e299529e805aae3dac7c2579b88c8dae7 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Fri, 8 May 2020 14:56:36 -0700 Subject: Add HTTP status code to internal API logs This would make it easier to filter the logs by status code. --- client/gitlabnet.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'client/gitlabnet.go') diff --git a/client/gitlabnet.go b/client/gitlabnet.go index 67c48c7..7fbf63e 100644 --- a/client/gitlabnet.go +++ b/client/gitlabnet.go @@ -123,18 +123,22 @@ func (c *GitlabNetClient) DoRequest(method, path string, data interface{}) (*htt "url": request.URL.String(), "duration_ms": time.Since(start) / time.Millisecond, } + logger := log.WithFields(fields) if err != nil { - log.WithError(err).WithFields(fields).Error("Internal API unreachable") + logger.WithError(err).Error("Internal API unreachable") return nil, fmt.Errorf("Internal API unreachable") } + if response != nil { + logger = logger.WithField("status", response.StatusCode) + } if err := parseError(response); err != nil { - log.WithError(err).WithFields(fields).Error("Internal API error") + logger.WithError(err).Error("Internal API error") return nil, err } - log.WithFields(fields).Info("Finished HTTP request") + logger.Info("Finished HTTP request") return response, nil } -- cgit v1.2.1