From e794bdf37503360094e6414bb931dbf135e636ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Ho=CC=88ltje?= Date: Fri, 15 Mar 2013 13:06:34 -0400 Subject: Use Kernel::exec instead of system() We don't need to keep the ruby process around once we've established that it's ok to run a git command. --- lib/gitlab_shell.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'lib/gitlab_shell.rb') diff --git a/lib/gitlab_shell.rb b/lib/gitlab_shell.rb index 842714e..75c7751 100644 --- a/lib/gitlab_shell.rb +++ b/lib/gitlab_shell.rb @@ -44,13 +44,17 @@ class GitlabShell def process_cmd repo_full_path = File.join(repos_path, repo_name) - system("#{@git_cmd} #{repo_full_path}") + exec_cmd "#{@git_cmd} #{repo_full_path}" end def validate_access api.allowed?(@git_cmd, @repo_name, @key_id, '_any') end + def exec_cmd args + Kernel::exec args + end + def api GitlabNet.new end -- cgit v1.2.1