delta/go-git.git/src/cmd/objdump/main.go, branch dev.inline

cmd/objdump: Fix error logging

2014-12-09T00:27:39+00:00

Change-Id: I6b1b4d3e8c039ba3198cb4b9765de75859ea8c32
Reviewed-on: https://go-review.googlesource.com/1214
Reviewed-by: Brad Fitzpatrick

cmd/objdump, cmd/pprof: factor disassembly into cmd/internal/objfile

2014-11-07T00:56:55+00:00

Moving so that new Go 1.4 pprof can use it.

The old 'GNU objdump workalike' mode for 'go tool objdump'
is now gone, as are the tests for that mode. It was used only
by pre-Go 1.4 pprof. You can still specify an address range on
the command line; you just get the same output format as
you do when dumping the entire binary (without an address
limitation).

LGTM=r
R=r
CC=golang-codereviews, iant
https://golang.org/cl/167320043

cmd/objdump: use cmd/internal/objfile

2014-10-29T22:07:24+00:00

This removes a bunch of ugly duplicate code.
The end goal is to factor the disassembly code
into cmd/internal/objfile too, so that pprof can use it,
but one step at a time.

LGTM=r, iant
R=r, alex.brainman, iant
CC=golang-codereviews
https://golang.org/cl/149400043

cmd/objdump: disassemble local text symbols

2014-10-29T03:25:55+00:00

Fixes #8803.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/169720043

cmd/objdump: move armasm, x86asm into internal packages

2014-09-30T16:28:24+00:00

For Go 1.3 these external packages were collapsed into
large single-file implementations stored in the cmd/objdump
directory.

For Go 1.4 we want pprof to be able to link against them too,
so move them into cmd/internal, where they can be shared.

The new files are copied from the repo in the file path (rsc.io/...).
Those repos were code reviewed during development
(mainly by crawshaw and minux), because we knew the
main repo would use them.

Update #8798

LGTM=bradfitz
R=crawshaw, bradfitz
CC=golang-codereviews
https://golang.org/cl/153750044

cmd/{addr2line,objdump}: fix finding pclntab and symtab for pe and plan9obj

2014-08-28T01:01:17+00:00

Broken by 8b5fc7c59d05.

Update #8092

LGTM=iant, alex.brainman
R=rsc, iant, alex.brainman
CC=golang-codereviews
https://golang.org/cl/138770043

cmd/{ld,link,objdump}, runtime, debug/gosym: move linker-defined symbols into runtime package

2014-08-28T00:15:05+00:00

Fixes #8092.

LGTM=rsc
R=iant, rsc
CC=golang-codereviews
https://golang.org/cl/126790043

cmd/addr2line, cmd/objdump: fix on amd64 Plan 9

2014-07-19T09:16:16+00:00

Fix virtual address of the start of the text segment
on amd64 Plan 9.

This issue has been partially fixed in cmd/add2line,
as part of CL 106460044, but we forgot to report the
change to cmd/objdump.

In the meantime, we also fixed the textStart address
in both cmd/add2line and cmd/objdump.

LGTM=aram, ality, mischief
R=rsc, mischief, aram, ality
CC=golang-codereviews, jas
https://golang.org/cl/117920043

objdump: remove out-of-date comment

2014-07-15T13:03:36+00:00

LGTM=iant
R=rsc, iant
CC=golang-codereviews
https://golang.org/cl/112320043

cmd/objdump: add arm disassembler

2014-06-01T22:53:59+00:00

Fixes #7452.

LGTM=minux, iant
R=minux, iant
CC=golang-codereviews
https://golang.org/cl/104770046