delta/go-git.git/test/fixedbugs, branch dev.debug

cmd/compile: consider exported flag in namedata

2017-07-24T18:05:00+00:00

It is possible to have an unexported name with a nil package,
for an embedded field whose type is a pointer to an unexported type.
We must encode that fact in the type..namedata symbol name,
to avoid incorrectly merging an unexported name with an exported name.

Fixes #21120

Change-Id: I2e3879d77fa15c05ad92e0bf8e55f74082db5111
Reviewed-on: https://go-review.googlesource.com/50710
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot 
Reviewed-by: David Crawshaw

cmd/compile: fix unaligned loads/stores to global variables on s390x

2017-07-19T14:22:48+00:00

Load/store-merging and move optimizations can result in unaligned
memory accesses. This is fine so long as the load/store instruction
used does not take a relative offset. In the SSA rules this means we
must not merge (MOVDaddr (SB)) ops into loads/stores unless we can
guarantee the alignment of the target.

Fixes #21048.

Change-Id: I70f13a62a148d5f0a56e704e8f76e36b4a4226d9
Reviewed-on: https://go-review.googlesource.com/49250
Run-TryBot: Michael Munday 
TryBot-Result: Gobot Gobot 
Reviewed-by: Cherry Zhang

cmd/compile: fix slice-in-bound check on amd64p32

2017-06-28T16:20:53+00:00

Should use CMPL instead of CMPQ.

Fixes #20811.

Change-Id: I610d487949c2c8a08b3743656149069d931a51bb
Reviewed-on: https://go-review.googlesource.com/46870
Reviewed-by: Matthew Dempsky 
Run-TryBot: Cherry Zhang 
TryBot-Result: Gobot Gobot

cmd/compile: suppress errors after "cannot assign to X"

2017-06-27T20:29:33+00:00

If the LHS is unassignable, there's no point in trying to make sure
the RHS can be assigned to it or making sure they're realizable
types. This is consistent with go/types.

In particular, this prevents "1 = 2" from causing a panic when "1"
still ends up with the type "untyped int", which is not realizable.

Fixes #20813.

Change-Id: I4710bdaac2e375ef12ec29b888b8ac84fb640e56
Reviewed-on: https://go-review.googlesource.com/46835
Run-TryBot: Matthew Dempsky 
TryBot-Result: Gobot Gobot 
Reviewed-by: Robert Griesemer

test/fixedbugs: Close opening parenthesis in comment in issue20789.go

2017-06-27T00:01:20+00:00

Updates #20789

Change-Id: Ic7a94394e283bc1b667cdad999ceee9513f35e37
Reviewed-on: https://go-review.googlesource.com/46770
Reviewed-by: Robert Griesemer

cmd/compile: use correct variable when setting up dummy CallStmt in error

2017-06-26T18:39:37+00:00

Fixes crash when printing a related error message later on.

Fixes #20789.

Change-Id: I6d2c35aafcaeda26a211fc6c8b7dfe4a095a3efe
Reviewed-on: https://go-review.googlesource.com/46713
Run-TryBot: Robert Griesemer 
Reviewed-by: Josh Bleecher Snyder 
Reviewed-by: Matthew Dempsky 
TryBot-Result: Gobot Gobot

cmd/compile: fix array slice expression bounds check

2017-06-22T23:31:45+00:00

Fixes #20749.

Change-Id: Ic6a7edc858575c4cb8b2e2ca97ee0c4b69f22c27
Reviewed-on: https://go-review.googlesource.com/46466
Run-TryBot: Robert Griesemer 
Reviewed-by: Matthew Dempsky 
TryBot-Result: Gobot Gobot

cmd/compile: add regress test for #20682

2017-06-15T22:01:35+00:00

Minimal reconstruction of reported failure case.

Manually verified that test fails with CL 45911 reverted.

Change-Id: Ia5d11500d91b46ba1eb5d841db3987edb9136c39
Reviewed-on: https://go-review.googlesource.com/45970
Run-TryBot: Matthew Dempsky 
Reviewed-by: Robert Griesemer

cmd/compile: fix exporting of function bodies

2017-06-15T04:17:30+00:00

Before CL 36170, we identified all function bodies that needed to be
exported before writing any export data.

With CL 36170, we started identifying additional functions while
exporting function bodies. As a consequence, we cannot use a
range-based for loop for iterating over function bodies anymore.

Fixes #18895.

Change-Id: I9cbefa8d311ca8c9898c8272b2ac365976b02396
Reviewed-on: https://go-review.googlesource.com/45817
Run-TryBot: Matthew Dempsky 
TryBot-Result: Gobot Gobot 
Reviewed-by: Robert Griesemer

runtime: restore arm assembly stubs for div/mod

2017-06-15T03:51:03+00:00

These are used by DIV[U] and MOD[U] assembly instructions.
Add a test in the stdlib so we actually exercise linking
to these routines.

Update #19507

Change-Id: I0d8e19a53e3744abc0c661ea95486f94ec67585e
Reviewed-on: https://go-review.googlesource.com/45703
Reviewed-by: Cherry Zhang