diff options
| author | Daniel Theophanes <kardianos@gmail.com> | 2016-10-17 09:28:06 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-10-21 08:31:15 +0000 |
| commit | 325c2aa5b6f12ccc82e8472beec0e1511e975bd4 (patch) | |
| tree | 2a1e88b595ee80f311d27c825fff39c29d62a459 /src/database/sql/sql_test.go | |
| parent | 930ab0afd787214d379aca230944d0d41c8b90e6 (diff) | |
| download | go-git-325c2aa5b6f12ccc82e8472beec0e1511e975bd4.tar.gz | |
database/sql: update the conversion errors to be clearer
There was some ambiguity over which argument was referred to when
a conversion error was returned. Now refer to the argument by
either explicit ordinal position or name if present.
Fixes #15676
Change-Id: Id933196b7e648baa664f4121fa3fb1b07b3c4880
Reviewed-on: https://go-review.googlesource.com/31262
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/database/sql/sql_test.go')
| -rw-r--r-- | src/database/sql/sql_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go index f4b887ca96..228a3f2580 100644 --- a/src/database/sql/sql_test.go +++ b/src/database/sql/sql_test.go @@ -745,8 +745,8 @@ func TestExec(t *testing.T) { {[]interface{}{7, 9}, ""}, // Invalid conversions: - {[]interface{}{"Brad", int64(0xFFFFFFFF)}, "sql: converting argument #1's type: sql/driver: value 4294967295 overflows int32"}, - {[]interface{}{"Brad", "strconv fail"}, "sql: converting argument #1's type: sql/driver: value \"strconv fail\" can't be converted to int32"}, + {[]interface{}{"Brad", int64(0xFFFFFFFF)}, "sql: converting argument $2 type: sql/driver: value 4294967295 overflows int32"}, + {[]interface{}{"Brad", "strconv fail"}, `sql: converting argument $2 type: sql/driver: value "strconv fail" can't be converted to int32`}, // Wrong number of args: {[]interface{}{}, "sql: expected 2 arguments, got 0"}, |