diff options
| author | Daniel Theophanes <kardianos@gmail.com> | 2016-11-17 09:33:31 -0800 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-11-17 18:13:41 +0000 |
| commit | 90b8a0ca2d0b565c7c7199ffcf77b15ea6b6db3a (patch) | |
| tree | 5ac17375b5ad7be0a202283ecbc017271f761b65 /src/database/sql/sql_test.go | |
| parent | e0942b76c735a69df18d24a23fa16da1e5db8c2e (diff) | |
| download | go-git-90b8a0ca2d0b565c7c7199ffcf77b15ea6b6db3a.tar.gz | |
database/sql: ensure all driver Stmt are closed once
Previously driver.Stmt could could be closed multiple times in
edge cases that drivers may not test for initially. Make their
job easier by ensuring the driver is only closed a single time.
Fixes #16019
Change-Id: I1e4777ef70697a849602e6ef9da73054a8feb4cd
Reviewed-on: https://go-review.googlesource.com/33352
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/database/sql/sql_test.go')
| -rw-r--r-- | src/database/sql/sql_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go index ea86264ae6..c46aaf60f8 100644 --- a/src/database/sql/sql_test.go +++ b/src/database/sql/sql_test.go @@ -672,7 +672,7 @@ func TestStatementClose(t *testing.T) { msg string }{ {&Stmt{stickyErr: want}, "stickyErr not propagated"}, - {&Stmt{tx: &Tx{}, txsi: &driverStmt{&sync.Mutex{}, stubDriverStmt{want}}}, "driverStmt.Close() error not propagated"}, + {&Stmt{tx: &Tx{}, txds: &driverStmt{Locker: &sync.Mutex{}, si: stubDriverStmt{want}}}, "driverStmt.Close() error not propagated"}, } for _, test := range tests { if err := test.stmt.Close(); err != want { |