diff options
| author | Daniel Theophanes <kardianos@gmail.com> | 2017-04-07 12:21:50 -0700 |
|---|---|---|
| committer | Daniel Theophanes <kardianos@gmail.com> | 2017-04-12 17:36:26 +0000 |
| commit | dec95d8fad2e1b3dea3fa1472cc21542c40236ce (patch) | |
| tree | d5b1f1eadb14c26086a9079f3a8639015b23517e /src/database/sql/sql_test.go | |
| parent | 10a200e56000c03fc820d6d43853b43b9e1c8a8c (diff) | |
| download | go-git-dec95d8fad2e1b3dea3fa1472cc21542c40236ce.tar.gz | |
database/sql: correctly guard the query Row preventing early release
When a Tx starts a query, prevent returning the connection to the pool
until after the query finishes.
Fixes #19058
Change-Id: I2c0480d9cca9eeb173b5b3441a5aeed6f527e0ac
Reviewed-on: https://go-review.googlesource.com/40400
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/database/sql/sql_test.go')
| -rw-r--r-- | src/database/sql/sql_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go index f511aa4ac3..b5a1f850bd 100644 --- a/src/database/sql/sql_test.go +++ b/src/database/sql/sql_test.go @@ -2997,7 +2997,6 @@ func TestIssue18719(t *testing.T) { // canceled context. cancel() - waitForRowsClose(t, rows, 5*time.Second) } func TestConcurrency(t *testing.T) { |