diff options
| author | Keith Randall <khr@google.com> | 2019-10-17 12:31:53 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2019-10-17 19:53:52 +0000 |
| commit | 9b8079158488120a0586d79ec57e0505fe0ec3eb (patch) | |
| tree | 4273b97d39e5f78feadfde009c7ed5e93f3a5ea8 /src/regexp/exec_test.go | |
| parent | dc72a2f95feebcfe5ccbd50636b8f8db05587d5f (diff) | |
| download | go-git-9b8079158488120a0586d79ec57e0505fe0ec3eb.tar.gz | |
regexp: skip long-running benchmarks if -short is specified
This CL helps race.bash finish in a reasonable amount of
time. Otherwise the Match/Hard1/32M benchmark takes over 1200 seconds
to finish on arm64, triggering a timeout. With this change the regexp
benchmarks as a whole take only about a minute.
Change-Id: Ie2260ef9f5709e32a74bd76f135bc384b2d9853f
Reviewed-on: https://go-review.googlesource.com/c/go/+/201742
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/regexp/exec_test.go')
| -rw-r--r-- | src/regexp/exec_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/regexp/exec_test.go b/src/regexp/exec_test.go index 1e8795525d..1f9a7a96e0 100644 --- a/src/regexp/exec_test.go +++ b/src/regexp/exec_test.go @@ -665,7 +665,7 @@ func BenchmarkMatch(b *testing.B) { for _, data := range benchData { r := MustCompile(data.re) for _, size := range benchSizes { - if isRaceBuilder && size.n > 1<<10 { + if (isRaceBuilder || testing.Short()) && size.n > 1<<10 { continue } t := makeText(size.n) @@ -688,7 +688,7 @@ func BenchmarkMatch_onepass_regex(b *testing.B) { b.Fatalf("want onepass regex, but %q is not onepass", r) } for _, size := range benchSizes { - if isRaceBuilder && size.n > 1<<10 { + if (isRaceBuilder || testing.Short()) && size.n > 1<<10 { continue } t := makeText(size.n) |