summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* doc: add tool sections to go1.8.htmlBrad Fitzpatrick2016-11-302-33/+50
| | | | | | | | | | | | Some still in TODO form. TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I63547bed3c6ce34b706821a3c150ae03d7d82cf8 Reviewed-on: https://go-review.googlesource.com/33682 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: add release notes for os and os/signal packagesIan Lance Taylor2016-11-302-9/+53
| | | | | | | | | | TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I2e5b24fb0b110d833a8b73bccfbf399cb6e37ea2 Reviewed-on: https://go-review.googlesource.com/33681 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: more go1.8.html additionsBrad Fitzpatrick2016-11-302-359/+124
| | | | | | | | | | | | And start deleting from go1.8.txt. TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I71011d97b23a7ba94cd51e16ae61fda18e8b96eb Reviewed-on: https://go-review.googlesource.com/33680 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: remove remaining cmd/go entries from go1.8.txtIan Lance Taylor2016-11-301-12/+0
| | | | | | | | None of them need to be called out in the release notes. Change-Id: I143a1879b25063574e4107c1e89264434d45d1d5 Reviewed-on: https://go-review.googlesource.com/33676 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* net/http: remove logging on bad client requestsKenny Grant2016-11-301-2/+0
| | | | | | | | | | As discussed in #18095 the server should not log for bad user input. Change-Id: I628a796926eff3a971e5b04abec17ea377c3f9b7 Reviewed-on: https://go-review.googlesource.com/33617 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* cmd/compile/internal/gc: document variables and functionsKevin Burke2016-11-303-0/+10
| | | | | | Change-Id: I01b2278eb50585331b8ff7ff5e3c1f9c5ba52b63 Reviewed-on: https://go-review.googlesource.com/33156 Reviewed-by: Matthew Dempsky <mdempsky@google.com>
* doc: note net/UnixListener.SetUnlinkOnClose in go1.8.htmlDan Peterson2016-11-302-1/+8
| | | | | | | | | | TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I201ffe489842ff17277424be4a012558d161f0a7 Reviewed-on: https://go-review.googlesource.com/33672 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* go/ast: fix doc string for ast.GenDeclRobert Griesemer2016-11-291-1/+1
| | | | | | | | Fixes #18109. Change-Id: I5e3a44422794b7bae7741523fb7cacb6ba147af7 Reviewed-on: https://go-review.googlesource.com/33669 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net: expand nss myhostname fallback detectionDan Peterson2016-11-293-59/+101
| | | | | | | | | | | | | Expand myhostname fallback detection to properly detect the local hostname in addition to other supported special names and suffixes. Fixes #17967 Change-Id: I1fe141fd9838b25886c08b6f2fd325e58be60457 Reviewed-on: https://go-review.googlesource.com/33550 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
* doc: add note about gccgo go go1.8.htmlIan Lance Taylor2016-11-291-1/+7
| | | | | | | | | | TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I28559724322007d4259810c209a92ec1cc10f338 Reviewed-on: https://go-review.googlesource.com/33668 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: add notes about cgo to go1.8.htmlIan Lance Taylor2016-11-292-8/+30
| | | | | | | | | | TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I0215a7873977be81f2f84374f0b628abaf0e57c1 Reviewed-on: https://go-review.googlesource.com/33667 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* crypto/tls: update CBC Lucky13 warning a bitBrad Fitzpatrick2016-11-291-1/+1
| | | | | | | | | | Some countermeasures were implemented in https://golang.org/cl/18130 Updates #13385 Change-Id: I723e1e3be0fa6d13767b65b145d90c89e92b2774 Reviewed-on: https://go-review.googlesource.com/33665 Reviewed-by: Adam Langley <agl@golang.org>
* doc: more additions to go1.8.htmlBrad Fitzpatrick2016-11-292-40/+190
| | | | | | | | | | | | Adds crypto/tls, crypto/x509, math/big, mime. TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I3fa3739e56f8c005e2a43c19f525cc5e2d981935 Reviewed-on: https://go-review.googlesource.com/33666 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: more go1.8.html tweaks and new context additions sectionBrad Fitzpatrick2016-11-291-51/+89
| | | | | | | | | | TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: Id5d5472cf1e41472d8d0f82ee133c7387257ba2b Reviewed-on: https://go-review.googlesource.com/33664 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/compile/internal/syntax: remove unused node fieldRobert Griesemer2016-11-291-1/+2
| | | | | | | | | | | | The doc field is not yet used - remove it for now (we may end up with a different solution for 1.9). This reduces memory consumption for parsing all of std lib by about 40MB and makes parsing slightly faster. Change-Id: Iafb00b9c7f1be9c66fdfb29096d3da5049b2fcf5 Reviewed-on: https://go-review.googlesource.com/33661 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
* database/sql: do not bypass the driver locks with Context methodsDaniel Theophanes2016-11-295-217/+242
| | | | | | | | | | | | | | | | | When context methods were initially added it was attempted to unify behavior between drivers without Context methods and those with Context methods to always return right away when the Context expired. However in doing so the driver call could be executed outside of the scope of the driver connection lock and thus bypassing thread safety. The new behavior waits until the driver operation is complete. It then checks to see if the context has expired and if so returns that error. Change-Id: I4a5c7c3263420c57778f36a5ed6fa0ef8cb32b20 Reviewed-on: https://go-review.googlesource.com/32422 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* cmd/go: report position info in package errorsDhananjay Nakrani2016-11-292-21/+18
| | | | | | | | | | | | Also refactor common position filling code into a function. Fixes #18011 Change-Id: I76528626da67a7309193fa92af1e361c8e2fcf84 Reviewed-on: https://go-review.googlesource.com/33631 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
* internal/pprof/profile: parse mutex profile including commentsHana Kim2016-11-292-26/+95
| | | | | | | | | | | Skip lines if they are empty or starting with "#" which are valid legacy pprof output format. Fixes #18025 Change-Id: I7aee439171496932637b8ae3188700911f569b16 Reviewed-on: https://go-review.googlesource.com/33454 Reviewed-by: Peter Weinberger <pjw@google.com>
* net/http/httptest: fix typo in doc commentMichal Bohuslávek2016-11-291-1/+1
| | | | | | Change-Id: I89f276b32015882437e128814573343a4ca53569 Reviewed-on: https://go-review.googlesource.com/33615 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/compile: don't panic on syntax error in select statementRobert Griesemer2016-11-292-17/+27
| | | | | | | | | | Fixes #18092. Change-Id: I54e2da2e0f168c068f5e4a1b22ba508d78259168 Reviewed-on: https://go-review.googlesource.com/33658 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
* runtime: fall back to /proc/self/auxv in Android libsAustin Clements2016-11-294-28/+37
| | | | | | | | | | | | | | | | | | | Android's libc doesn't provide access to auxv, so currently the Go runtime synthesizes a fake, minimal auxv when loaded as a library on Android. This used to be sufficient, but now we depend on auxv to retrieve the system physical page size and panic if we can't retrieve it. Fix this by falling back to reading auxv from /proc/self/auxv if the loader-provided auxv is empty and removing the synthetic auxv vectors. Fixes #18041. Change-Id: Ia2ec2c764a6609331494a5d359032c56cbb83482 Reviewed-on: https://go-review.googlesource.com/33652 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
* runtime: extract Linux auxv handlingAustin Clements2016-11-291-0/+4
| | | | | | | | | | | | | This refactoring is in preparation for handling auxv differently in Android shared libraries. Updates #18041. Change-Id: If0458a309f9c804e7abd0a58b5a224d89f8da257 Reviewed-on: https://go-review.googlesource.com/33651 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
* doc: more go1.8.html updatesBrad Fitzpatrick2016-11-291-20/+51
| | | | | | | | | | TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I648df63aeb67aa2229c7b4fc23676a78b31140a0 Reviewed-on: https://go-review.googlesource.com/33657 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: update go1.8.html after feedback from RussBrad Fitzpatrick2016-11-291-84/+197
| | | | | | | | | | | | Address Russ's feedback from https://golang.org/cl/33244 TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I708d71f519f6414ecec629d3c273d9e737d8ed50 Reviewed-on: https://go-review.googlesource.com/33656 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/link: handle STT_COMMON symbolsIan Lance Taylor2016-11-291-3/+5
| | | | | | | | | | | | | | | | | | | | Tested by running GOTRACEBACK=2 CGO_CFLAGS="-Wa,--elf-stt-common=yes" go test -ldflags=-linkmode=internal in misc/cgo/test. That failed before this CL, succeeded after. I don't think it's worth doing that as a regular test, though, especially since only recent versions of the GNU binutils support the --elf-stt-common option. Fixes #18088. Change-Id: I893d86181faee217b1504c054b0ed3f7c8d977d3 Reviewed-on: https://go-review.googlesource.com/33653 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* os: fix handling of Windows Unicode console input and ^ZRuss Cox2016-11-293-171/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Go 1.5 worked with Unicode console input but not ^Z. Go 1.6 did not work with Unicode console input but did handle one ^Z case. Go 1.7 did not work with Unicode console input but did handle one ^Z case. The intent of this CL is for Go 1.8 to work with Unicode console input and also handle all ^Z cases. Here's a simple test program for reading from the console. It prints a "> " prompt, calls read, prints what it gets, and repeats. package main import ( "fmt" "os" ) func main() { p := make([]byte, 100) fmt.Printf("> ") for { n, err := os.Stdin.Read(p) fmt.Printf("[%d %q %v]\n> ", n, p[:n], err) } } On Unix, typing a ^D produces a break in the input stream. If the ^D is at the beginning of a line, then the 0 bytes returned appear as an io.EOF: $ go run /tmp/x.go > hello [6 "hello\n" <nil>] > hello^D[5 "hello" <nil>] > ^D[0 "" EOF] > ^D[0 "" EOF] > hello^Dworld [5 "hello" <nil>] > [6 "world\n" <nil>] > On Windows, the EOF character is ^Z, not ^D, and there has been a long-standing problem that in Go programs, ^Z on Windows does not behave in the expected way, namely like ^D on Unix. Instead, the ^Z come through as literal ^Z characters: C:\>c:\go1.5.4\bin\go run x.go > ^Z [3 "\x1a\r\n" <nil>] > hello^Zworld [13 "hello\x1aworld\r\n" <nil>] > CL 4310 attempted to fix this bug, then known as #6303, by changing the use of ReadConsole to ReadFile. This CL was released as part of Go 1.6 and did fix the case of a ^Z by itself, but not as part of a larger input: C:\>c:\go1.6.3\bin\go run x.go > ^Z [0 "" EOF] > hello^Zworld [13 "hello\x1aworld\r\n" <nil>] > So the fix was incomplete. Worse, the fix broke Unicode console input. ReadFile does not handle Unicode console input correctly. To handle Unicode correctly, programs must use ReadConsole. Early versions of Go used ReadFile to read the console, leading to incorrect Unicode handling, which was filed as #4760 and fixed in CL 7312053, which switched to ReadConsole and was released as part of Go 1.1 and still worked as of Go 1.5: C:\>c:\go1.5.4\bin\go run x.go > hello [7 "hello\r\n" <nil>] > hello world™ [16 "hello world™\r\n" <nil>] > But in Go 1.6: C:\>c:\go1.6.3\bin\go run x.go > hello [7 "hello\r\n" <nil>] > hello world™ [0 "" EOF] > That is, changing back to ReadFile in Go 1.6 reintroduced #4760, which has been refiled as #17097. (We have no automated test for this because we don't know how to simulate console input in a test: it appears that one must actually type at a keyboard to use the real APIs. This CL at least adds a comment warning not to reintroduce ReadFile again.) CL 29493 attempted to fix #17097, but it was not a complete fix: the hello world™ example above still fails, as does Shift-JIS input, which was filed as #17939. CL 29493 also broke ^Z handling, which was filed as #17427. This CL attempts the never before successfully performed trick of simultaneously fixing Unicode console input and ^Z handling. It changes the console input to use ReadConsole again, as in Go 1.5, which seemed to work for all known Unicode input. Then it adds explicit handling of ^Z in the input stream. (In the case where standard input is a redirected file, ^Z processing should not happen, and it does not, because this code path is only invoked when standard input is the console.) With this CL: C:\>go run x.go > hello [7 "hello\r\n" <nil>] > hello world™ [16 "hello world™\r\n" <nil>] > ^Z [0 "" EOF] > [2 "\r\n" <nil>] > hello^Zworld [5 "hello" <nil>] > [0 "" EOF] > [7 "world\r\n" <nil>] This almost matches Unix: $ go run /tmp/x.go > hello [6 "hello\n" <nil>] > hello world™ [15 "hello world™\n" <nil>] > ^D [0 "" EOF] > [1 "\n" <nil>] > hello^Dworld [5 "hello" <nil>] > [6 "world\n" <nil>] > The difference is in the handling of hello^Dworld / hello^Zworld. On Unix, hello^Dworld terminates the read of hello but does not result in a zero-length read between reading hello and world. This is dictated by the tty driver, not any special Go code. On Windows, in this CL, hello^Zworld inserts a zero length read result between hello and world, which is treated as an interior EOF. This is implemented by the Go code in this CL, but it matches the handling of ^Z on the console in other programs: C:\>copy con x.txt hello^Zworld 1 file(s) copied. C:\>type x.txt hello C:\> A natural question is how to test all this. As noted above, we don't know how to write automated tests using the actual Windows console. CL 29493 introduced the idea of substituting a different syscall.ReadFile implementation for testing; this CL continues that idea but substituting for syscall.ReadConsole instead. To avoid the regression of putting ReadFile back, this CL adds a comment warning against that. Fixes #17427. Fixes #17939. Change-Id: Ibaabd0ceb2d7af501d44ac66d53f64aba3944142 Reviewed-on: https://go-review.googlesource.com/33451 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Quentin Smith <quentin@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
* os: Executable can use /proc/self/exe on androidDavid Crawshaw2016-11-291-1/+1
| | | | | | | | | | Fixes the os test on the Android builder. Change-Id: Ibb9db712156a620fcccf515e035475c5e2f535a5 Reviewed-on: https://go-review.googlesource.com/33650 Run-TryBot: David Crawshaw <crawshaw@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* net/http, net/http/httptest: cross-reference the two NewRequest funcsBrad Fitzpatrick2016-11-282-5/+8
| | | | | | | | Updates #18082 Change-Id: I2e65b115b809c1e1bf813f538989d1a1f96b2876 Reviewed-on: https://go-review.googlesource.com/33636 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* internal/pprof: don't discard allocations called by reflect.CallIan Lance Taylor2016-11-282-6/+25
| | | | | | | | | | | | | | | The pprof code discards all heap allocations made by runtime routines. This caused it to discard heap allocations made by functions called by reflect.Call, as the calls are made via the functions `runtime.call32`, `runtime.call64`, etc. Fix the profiler to retain these heap allocations. Fixes #18077. Change-Id: I8962d552f1d0b70fc7e6f7b2dbae8d5bdefb0735 Reviewed-on: https://go-review.googlesource.com/33635 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net/http: document restrictions on ETag as expected by ServeContentJoe Tsai2016-11-281-2/+2
| | | | | | | | | | Fixes #18054 Change-Id: I6773943a95b92eebd7e347f8f7a80843b4827243 Reviewed-on: https://go-review.googlesource.com/33630 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
* net: document that Header.Get key is case insensitiveKaviraj2016-11-283-3/+11
| | | | | | | | | | | Document that key in Header.Get(key) is case insensitive in http.Header, mail.Header, textproto.Header. Fixes #18019 Change-Id: Iba7932491e02e555190b6fce053088b580a853ef Reviewed-on: https://go-review.googlesource.com/33530 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/asm: fix parsing of the s390x instructions VSTE{G,F,H,B}Michael Munday2016-11-282-1/+6
| | | | | | | | | | | | | | | The element index needs to be placed in From3. Before this CL it was impossible to write a VSTE instruction that could be successfully parsed, so this won't affect existing assembly code. Fixes #18075. Change-Id: I5b71be4c6632b1d5a30820a529122f96fd1bc864 Reviewed-on: https://go-review.googlesource.com/33584 Run-TryBot: Michael Munday <munday@ca.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bill O'Farrell <billotosyr@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
* net: add missing comma on BUGS section for consistencyMikio Hara2016-11-281-2/+2
| | | | | | | | Change-Id: Ic96fb52f37257e06e77cc08da5c73ea6f9ff158c Reviewed-on: https://go-review.googlesource.com/33592 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
* net: update documentation on Conn and PacketConnJoe Tsai2016-11-261-14/+26
| | | | | | | | Fixes #17982 Change-Id: I4884a6b57905420ac0e37210c411de98c582de1d Reviewed-on: https://go-review.googlesource.com/33473 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* testing: comment out flag.Parse from exampleDaniel Martí2016-11-251-1/+1
| | | | | | | | | | | | | | | | | | The TestMain docs explain that flag.Parse() should be called if TestMain itself depends on command-line flags. The issue here is that the example implementation does not use any flags, and thus the flag.Parse call is unnecessary. This leads to people who use this example as a starting point for their own implementations to forget that the call is not necessary in most cases. Comment it out instead of removing the line to keep it as a reminder, as suggested by Minux Ma. Change-Id: I6ffc5413e7036366ae3cf0f069b7065e832a3b45 Reviewed-on: https://go-review.googlesource.com/33273 Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
* database/sql: force users of NamedParam to name struct literals fieldsBrad Fitzpatrick2016-11-241-0/+2
| | | | | | | | | | | Or they can use sql.Param instead. Change-Id: Icf21dbcc87170635c3f5d3f49736429a37abe9da Reviewed-on: https://go-review.googlesource.com/33576 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Daniel Theophanes <kardianos@gmail.com> Reviewed-by: Minux Ma <minux@golang.org>
* doc: add database/sql and os changes to go1.8 release notesDaniel Theophanes2016-11-242-10/+78
| | | | | | Change-Id: Ib936539946f43556a7dd501f8127054f6a27861f Reviewed-on: https://go-review.googlesource.com/33553 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net/http: fix receiver for Server.Shutdown and Server.CloseDan Peterson2016-11-241-15/+15
| | | | | | | | Change-Id: Ia27ca728bafcf20d001b477787b21d16ae12960d Reviewed-on: https://go-review.googlesource.com/33552 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* runtime/cgo: save correct floating point registers on s390xMichael Munday2016-11-233-53/+65
| | | | | | | | | | | | | | | | | | When transitioning from C code to Go code we must respect the C calling convention. On s390x this means that r6-r13, r15 and f8-f15 must be saved and restored by functions that use them. On s390x we were saving the wrong set of floating point registers (f0, f2, f4 and f6) rather than f8-f15 which means that Go code could clobber registers that C code expects to be restored. This CL modifies the crosscall functions on s390x to save/restore the correct floating point registers. Fixes #18035. Change-Id: I5cc6f552c893a4e677669c8891521bf735492e97 Reviewed-on: https://go-review.googlesource.com/33571 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* test: remove amd64 build tag from testBrad Fitzpatrick2016-11-231-1/+0
| | | | | | | | | | | It was supposed to be testing SSA, not amd64. For #18024 Change-Id: Ibe65d7eb6bed9bc4b3eda68e1eaec5fa39fe8f76 Reviewed-on: https://go-review.googlesource.com/33491 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
* math/rand: export Source64, mainly for documentation valueRuss Cox2016-11-231-8/+11
| | | | | | | | | | | | There is some code value too: types intending to implement Source64 can write a conversion confirming that. For #4254 and the Go 1.8 release notes. Change-Id: I7fc350a84f3a963e4dab317ad228fa340dda5c66 Reviewed-on: https://go-review.googlesource.com/33456 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: add net/http section to go1.8.htmlBrad Fitzpatrick2016-11-232-31/+147
| | | | | | | | | | TBR=See https://golang.org/cl/33244 and review there. Updates #17929 Change-Id: I752ec7a6d086f370feaf3cf282708620e891079b Reviewed-on: https://go-review.googlesource.com/33478 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/gofmt: don't call Chmod on windowsBrad Fitzpatrick2016-11-232-5/+23
| | | | | | | | | | Fixes #18026 Change-Id: Id510f427ceffb2441c3d6f5bb5c93244e46c6497 Reviewed-on: https://go-review.googlesource.com/33477 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
* doc: add SIGPIPE behaviour change to go1.8.txtElias Naur2016-11-231-0/+1
| | | | | | | | | CL 32796 changes the SIGPIPE behaviour for c-archive and c-shared programs. Add it to go1.8.txt. Change-Id: I31200187033349c642965a4bb077bcc77d5329a3 Reviewed-on: https://go-review.googlesource.com/33397 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* reflect: fix typo in commentIan Lance Taylor2016-11-231-1/+1
| | | | | | | | Sigh, forgot to run `git mail`. Change-Id: Idc49be2bb20d6f0e392cb472a63267ffee2ca22c Reviewed-on: https://go-review.googlesource.com/33476 Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
* reflect: fix size of StructOf ending in zero-sized fieldIan Lance Taylor2016-11-232-0/+46
| | | | | | | | | | | Update #9401. Fixes #18016. Change-Id: Icc24dd10dab1ad8e5cf295e0727d437afa5025c0 Reviewed-on: https://go-review.googlesource.com/33475 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
* database/sql: fix TestPendingConnsAfterErrDaniel Theophanes2016-11-221-9/+31
| | | | | | | | | | | | | | | | | | TestPendingConnsAfterErr showed a failure on slower systems. Wait and check for the database to close all connections before pronouncing failure. A more careful method was attempted but the connection pool behavior is too dependent on the scheduler behavior to be predictable. Fixes #15684 Change-Id: Iafdbc90ba51170c76a079db04c3d5452047433a4 Reviewed-on: https://go-review.googlesource.com/33418 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* doc: fix typos in go1.8.htmlJoe Tsai2016-11-221-9/+12
| | | | | | Change-Id: I51180e1c685e488f7ea4c51a63fd035148671b05 Reviewed-on: https://go-review.googlesource.com/33470 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: more go1.8.html contentBrad Fitzpatrick2016-11-222-58/+144
| | | | | | | | | | TBR=See https://golang.org/cl/33244 and review there. Updates #17929 Change-Id: I7cb0b666469dba35426d1f0ae1b185e0bdfeac05 Reviewed-on: https://go-review.googlesource.com/33474 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/go: print CC environment variables on Plan 9David du Colombier2016-11-221-7/+5
| | | | | | | | | | | | | This changes makes the output of `go env` the same as on other operating systems. Fixes #18013. Change-Id: I3079e14dcf7b30c75ec3fde6c78cb95721111320 Reviewed-on: https://go-review.googlesource.com/33396 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
View Lorry Controller Status