summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
| * crypto/aes: correct 'noescape' typo in s390xEuan Kemp2016-12-141-1/+1
| | | | | | | | | | | | Change-Id: I9e24a28b4daee5d6e1e4769547922a1a253b4ffc Reviewed-on: https://go-review.googlesource.com/34377 Reviewed-by: Michael Munday <munday@ca.ibm.com>
| * net: change "mask" to "prefix length" in ParseCIDR commentMatt Layher2016-12-141-1/+1
| | | | | | | | | | | | | | | | Fixes #18175 Change-Id: I0074109fa885976b22c2be9fa39641d4d0657dee Reviewed-on: https://go-review.googlesource.com/34375 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * net: document consecutive dialing in net.DialKaviraj2016-12-141-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | document about the consecutive dialing introduced in Go 1.5. If address is resolved to multiple addresses, Dial will try each address in order until one succeeds. Deadline is used to try each address (calculated based on total number of resolved addresses) Fixes: #17617 Change-Id: I56b6399edb640c8ef507675f98e0bd45a50d4e2d Reviewed-on: https://go-review.googlesource.com/34176 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * cmd/link: improve -X doc wordingIan Lance Taylor2016-12-141-1/+1
| | | | | | | | | | | | Change-Id: I9329738ec5dd6c12f72eea7de413d66617b7b5c2 Reviewed-on: https://go-review.googlesource.com/34373 Reviewed-by: Rob Pike <r@golang.org>
| * cmd/cgo: don't strip qualifiers from C void* pointerIan Lance Taylor2016-12-141-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we try to handle qualifiers correctly (as of CL 33325), don't strip them from a void* pointer. Otherwise we break a case like "const void**", as the "const" qualifier is dropped and the resulting "void**" triggers a warning from the C compiler. Fixes #18298. Change-Id: If51df1889b0f6a907715298c152e6d4584747acb Reviewed-on: https://go-review.googlesource.com/34370 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * cmd/link: explain how to find the name to use for -XIan Lance Taylor2016-12-141-0/+2
| | | | | | | | | | | | | | | | | | | | Doc change only. Fixes #18246. Change-Id: I2c7b181bcec81e124d30702f6fac5aa43bb57c04 Reviewed-on: https://go-review.googlesource.com/34230 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/cgo: add required gcc flags for GOARCH=mips{,le}Vladimir Stefanovic2016-12-132-0/+4
| | | | | | | | | | | | | | | | Change-Id: I1d6a2120a444d1ab9b9ecfdf27464325ad741d55 Reviewed-on: https://go-review.googlesource.com/34315 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * cmd/go: fix go get -t -u path/... containing vendor directoriesRuss Cox2016-12-133-21/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | A lot of things had to line up to make this break, but the caching of download results interacted badly with vendor directories, "go get -t -u", and wildcard expansion. Fixes #18219. Change-Id: I2676498d2f714eaeb69f399e9ed527640c12e60d Reviewed-on: https://go-review.googlesource.com/34201 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * os: must fixup path when 248 bytes longDaniel Theophanes2016-12-132-42/+56
| | | | | | | | | | | | | | | | | | | | Fixes #18283 Change-Id: Ic044d2d0657579e8e7786d7264fda2037ddc5ffb Reviewed-on: https://go-review.googlesource.com/34280 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/vet: fix panic and handling of XML in struct field tag checkTilman Dilo2016-12-132-5/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The check for duplicate struct field tags introduced in CL 16704 triggers a panic when an anonymous struct field with a duplicate name is encountered. For such a field, the names slice of the ast.Field is nil but accessed regardless to generate the warning message. Additionally, the check produces false positives for XML tags in some cases: - When fields are encoded as XML attributes, a warning is produced when an attribute reuses a name previously used for an element. Example: type Foo struct { First int `xml:"a"` NoDup int `xml:"a,attr"` // warning about reuse of "a" } - When XMLName is used to set the name of the enclosing struct element, it is treated as a regular struct field. Example: type Bar struct { XMLName xml.Name `xml:"a"` NoDup int `xml:"a"` // warning about reuse of "a" } This commit addresses all three issues. The panic is avoided by using the type name instead of the field name for anonymous struct fields when generating the warning message. An additional namespace for checking XML attribute names separately from element names is introduced. Lastly, fields named XMLName are excluded from the check for duplicate tags. Updates #18256 Change-Id: Ida48ea8584b56bd4d12ae3ebd588a66ced2594cc Reviewed-on: https://go-review.googlesource.com/34070 Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
| * os/exec: fix race in TestStdinCloseRaceIan Lance Taylor2016-12-131-1/+11
| | | | | | | | | | | | | | | | | | | | | | The test for the race detector itself had a race of a sort not detected by the race detector. Fixes #18286. Change-Id: I3265eae275aaa2869a6b6d3e8675b0d88b25831b Reviewed-on: https://go-review.googlesource.com/34287 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * net/http: update some commentsBrad Fitzpatrick2016-12-132-4/+9
| | | | | | | | | | | | | | | | | | | | | | And move some code to make control flow more obvious. No functional change. Change-Id: Iefaa96f664070ab2accade1857e1946e56df6902 Reviewed-on: https://go-review.googlesource.com/34285 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * cmd/go: don't assemble all .s files in a single cmd/asm runIan Lance Taylor2016-12-132-7/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For the 1.8 release, go back to invoking the assembler once per .s file, to avoid the problem in #18225. When the assembler is fixed, the change to cmd/go/build.go can be rolled back, but the test in cmd/go/go_test.go should remain. Fixes #18225. Update #15680. Change-Id: Ibff8d0c638536efb50a2b2c280b41399332f4fe4 Reviewed-on: https://go-review.googlesource.com/34284 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * cmd/internal/obj/mips: replace MOVD with MOVF on 32-bit to avoid unaligned ↵Shenghou Ma2016-12-121-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | memory access This is the simplest CL that I can make for Go 1.8. For Go 1.9, we can revisit it and optimize the redundant address generation instructions or just fix #599 instead. Fixes #18140. Change-Id: Ie4804ab0e00dc6bb318da2bece8035c7c71caac3 Reviewed-on: https://go-review.googlesource.com/34193 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
| * time: parse WITA timezone correctlyMax Riveiro2016-12-122-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | WITA stands for Asia/Makassar IANA timezone https://en.wikipedia.org/wiki/Asia/Makassar Fixes #18251 Change-Id: I5896efb8052593afb4e51ae4a34b574a8206d4dc Reviewed-on: https://go-review.googlesource.com/34253 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * runtime: don't crash if signal delivered on g0 stackIan Lance Taylor2016-12-121-18/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, if we changed the gsignal stack to match the stack we are executing on, restore it when returning from the signal handler, for safety. Fixes #18255. Change-Id: Ic289b36e4e38a56f8a6d4b5d74f68121c242e81a Reviewed-on: https://go-review.googlesource.com/34239 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: David Crawshaw <crawshaw@golang.org>
| * runtime, syscall: update openbsd for changes to syskillJoel Sing2016-12-126-13/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the openbsd runtime to use the current sys_kill and sys_thrkill system calls. Prior to OpenBSD 5.9 the sys_kill system call could be used with both processes and threads. In OpenBSD 5.9 this functionality was split into a sys_kill system call for processes (with a new syscall number) and a sys_thrkill system call for threads. The original/legacy system call was retained in OpenBSD 5.9 and OpenBSD 6.0, however has been removed and will not exist in the upcoming OpenBSD 6.1 release. Note: This change is needed to make Go work on OpenBSD 6.1 (to be released in May 2017) and should be included in the Go 1.8 release. This change also drops support for OpenBSD 5.8, which is already an unsupported OpenBSD release. Change-Id: I525ed9b57c66c0c6f438dfa32feb29c7eefc72b0 Reviewed-on: https://go-review.googlesource.com/34093 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * fmt: undo clearflags in catchPanic after error message has been printedMartin Möhrmann2016-12-112-11/+24
| | | | | | | | | | | | | | | | | | | | Fixes #18282 Change-Id: I024ca4a03bbbcccd48a0a6245bc3ec22c6a90288 Reviewed-on: https://go-review.googlesource.com/34254 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Martin Möhrmann <moehrmann@google.com> Reviewed-by: Rob Pike <r@golang.org>
| * cmd/link: limit darwin dynlink symbol exportsDavid Crawshaw2016-12-101-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pclntable contains pointers to functions. If the function symbol is exported in a plugin, and there is a matching symbol in the host binary, then the pclntable of a plugin ends up pointing at the function in the host module. This doesn't work because the traceback code expects the pointer to be in the same module space as the PC value. So don't export functions that might overlap with the host binary. This way the pointer stays in its module. Updates #18190 Change-Id: Ifb77605b35fb0a1e7edeecfd22b1e335ed4bb392 Reviewed-on: https://go-review.googlesource.com/34196 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * crypto/x509: marshal certificate revocation times in UTC (Zulu time).Martin Kreichgauer2016-12-102-4/+29
| | | | | | | | | | | | | | | | | | | | | | | | This is required by RFC 5280. Fixes #16686 Change-Id: I291c68dd97410a4f7ae7c4e524b91a2493ac50a9 Reviewed-on: https://go-review.googlesource.com/34245 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * io: update documentation on LimitedReaderJoe Tsai2016-12-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | Specify that that LimitedReader returns EOF when the underlying R returns EOF even if bytes remaining, N > 0. Fixes #18271 Change-Id: I990a7135f1d31488d535238ae061d42ee96bacb7 Reviewed-on: https://go-review.googlesource.com/34249 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * database/sql: use complete sentences in new docsBrad Fitzpatrick2016-12-091-6/+13
| | | | | | | | | | | | | | Change-Id: Icb842a80cab2b07b9ace1e8e14c4a19c48a92c43 Reviewed-on: https://go-review.googlesource.com/34247 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
| * runtime/pprof: track locations for goroutine profilesRaul Silvera2016-12-091-1/+11
| | | | | | | | | | | | | | | | | | | | | | Must add locations to the profile when generating a profile.proto. This fixes #18229 Change-Id: I49cd63a30759d3fe8960d7b7c8bd5a554907f8d1 Reviewed-on: https://go-review.googlesource.com/34028 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * go/build: clarify Context.HasSubdir docsBrad Fitzpatrick2016-12-091-2/+3
| | | | | | | | | | | | | | | | | | Fixes #17888 Change-Id: I7490b95a03b810a0f7ed1f07f37d7c7b3ac036be Reviewed-on: https://go-review.googlesource.com/34240 Reviewed-by: Dmitri Shuralyov <shurcool@gmail.com> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
| * Revert "testing: add T.Context method"Joe Tsai2016-12-095-96/+34
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 26827bc2fe4c80dc68b3793631d24975425c9467. Fixes #18199 Change-Id: I42e292cb4e3d740a4fbb5d0380c6ee15ac742092 Reviewed-on: https://go-review.googlesource.com/34141 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * database/sql: document that drivers may not return right after cancelDaniel Theophanes2016-12-091-1/+4
| | | | | | | | | | | | | | | | Fixes #18168 Change-Id: Idbfe3d4daedd93c7caf6f1770ecd988e9af39949 Reviewed-on: https://go-review.googlesource.com/34144 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/compile/internal/obj: remove superfluous addvarint parameter and assignmentRobert Griesemer2016-12-091-7/+6
| | | | | | | | | | | | | | Change-Id: I395625dca9b719290c52d2c46f60b53e8fb3abc4 Reviewed-on: https://go-review.googlesource.com/34139 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * all: make spelling consistentBrad Fitzpatrick2016-12-0813-18/+18
| | | | | | | | | | | | | | | | | | | | Fixes #17938 Change-Id: Iad12155f4976846bd4a9a53869f89e40e5b3deb3 Reviewed-on: https://go-review.googlesource.com/34147 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
| * net/http: don't retry Transport requests if they have a bodyBrad Fitzpatrick2016-12-082-7/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This rolls back https://golang.org/cl/27117 partly, softening it so it only retries POST/PUT/DELETE etc requests where there's no Body (nil or NoBody). This is a little useless, since most idempotent requests have a body (except maybe DELETE), but it's late in the Go 1.8 release cycle and I want to do the proper fix. The proper fix will look like what we did for http2 and only retrying the request if Request.GetBody is defined, and then creating a new request for the next attempt. See https://golang.org/cl/33971 for the http2 fix. Updates #15723 Fixes #18239 Updates #18241 Change-Id: I6ebaa1fd9b19b5ccb23c8d9e7b3b236e71cf57f3 Reviewed-on: https://go-review.googlesource.com/34134 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com>
| * cmd/link: do not mark go.plugin.tabs as reachable in non-pluginsMichael Hudson-Doyle2016-12-081-2/+1
| | | | | | | | | | | | | | | | | | Fixes #18250 Change-Id: I4f61591356ddb4a906c206ad8456d1839daf7b91 Reviewed-on: https://go-review.googlesource.com/34170 Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> Reviewed-by: David Crawshaw <crawshaw@golang.org>
| * io: fix MultiReader panic on nil reader.Joe Tsai2016-12-082-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The combination of two prior CLs can cause panics: * CL/17873: make chained multiReader Read more efficient * CL/28533: make MultiReader nil exhausted Readers for earlier GC The first CL allows MultiReader to "inherit" another MultiReader's list of Readers for efficiency reasons. This is problematic when combined with the later CL since that can set prior Readers in that list to nil for GC reasons. This causes panics when two MultiReaders are used together (even synchronously). To fix this, rather than setting consumed Readers as nil, we set them with a special eofReader that always returns EOF. Fixes #18232 Change-Id: I2a9357ab217e3d54d38ea9022d18e4d14f4182d3 Reviewed-on: https://go-review.googlesource.com/34140 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * os: document that Rename does not replace an existing directoryIan Lance Taylor2016-12-081-1/+1
| | | | | | | | | | | | | | | | Fixes #18240. Change-Id: Ife951e2c1320b3f1362c85642615b24fd4291189 Reviewed-on: https://go-review.googlesource.com/34135 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime: add number of forced GCs to MemStatsAustin Clements2016-12-073-5/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | This adds a counter for the number of times the application forced a GC by, e.g., calling runtime.GC(). This is useful for detecting applications that are overusing/abusing runtime.GC() or debug.FreeOSMemory(). Fixes #18217. Change-Id: I990ab7a313c1b3b7a50a3d44535c460d7c54f47d Reviewed-on: https://go-review.googlesource.com/34067 Reviewed-by: Russ Cox <rsc@golang.org>
| * cmd/internal/obj: regenerate relocation stringsDavid Crawshaw2016-12-071-2/+2
| | | | | | | | | | | | | | | | Change-Id: Ib9ba8f0b8785f1b0ddb29214beb8674dc06f7422 Reviewed-on: https://go-review.googlesource.com/34111 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * cmd/link: fix sym sect when splitting text on ppc64leLynn Boger2016-12-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While processing a symbol for a function, if it is determined that a function would make the text section too large then a new text section is created and the address of the function is in the new text section. But the symbol for the function is marked as being in the previous text section, causing incorrect codegen for the function and leading to a segv if that function is called. This adds code to set the sym.Sect field to the new section if a new one is created. Note that this problem only happens at the point where a new section is created. Fixes #18218 Change-Id: Ic21ae11368d9d88ff6d5d3977f9ea72fe6477ed1 Reviewed-on: https://go-review.googlesource.com/34069 Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * crypto/x509: reduce test's sought number of system certsBrad Fitzpatrick2016-12-071-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | 150 is too high for some people. Reports of 132, 145, 149 on OS X. Fixes #18203 Change-Id: I559639aba7e87e07d1a1249f8b212b3f34a078ab Reviewed-on: https://go-review.googlesource.com/34019 Reviewed-by: Russ Cox <rsc@golang.org>
| * runtime: on stack copy, adjust BPKeith Randall2016-12-072-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we copy the stack, we need to adjust all BPs. We correctly adjust the ones on the stack, but we also need to adjust the one that is in g.sched.bp. Like CL 33754, no test as only kernel-gathered profiles will notice. Tests will come (in 1.9) with the implementation of #16638. The invariant should hold that every frame pointer points to somewhere within its stack. After this CL, it is mostly true, but something about cgo breaks it. The runtime checks are disabled until I figure that out. Update #16638 Fixes #18174 Change-Id: I6023ee64adc80574ee3e76491d4f0fa5ede3dbdb Reviewed-on: https://go-review.googlesource.com/33895 Reviewed-by: Austin Clements <austin@google.com>
| * fmt: remove unnecessary else statementOdin Ugedal2016-12-071-8/+7
| | | | | | | | | | | | | | | | Change-Id: If30ccfcf56d56fb40102ad567a980793bd39f320 Reviewed-on: https://go-review.googlesource.com/34071 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * crypto/*: document use or non-use of constant-time algorithmsRuss Cox2016-12-077-2/+28
| | | | | | | | | | | | | | | | | | | | Fixes #16821. Change-Id: I63d5f3d7cfba1c76259912d754025c5f3cbe4a56 Reviewed-on: https://go-review.googlesource.com/31573 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * crypto/dsa: don't allow signing with degenerate private keys to loop forever.Adam Langley2016-12-072-2/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it was possible to craft a DSA private key that would cause Sign() to loop forever because no signature could be valid. This change does some basic sanity checks and ensures that Sign will always terminate. Thanks to Yolan Romailler for highing this. Be aware, however, that it's still possible for an attacker to simply craft a private key with enormous values and thus cause Sign to take an arbitrary amount of time. Change-Id: Icd53939e511eef513a4977305dd9015d9436d0ce Reviewed-on: https://go-review.googlesource.com/33725 Reviewed-by: Yolan Romailler <y@romailler.ch> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
| * net: use baked-in port numbers as fallback if cgo port lookup failsBrad Fitzpatrick2016-12-072-8/+9
| | | | | | | | | | | | | | | | | | | | Fixes TestLookupPort_Minimal on android. Fixes #18213 Change-Id: I1b65e790525d339a4cb7f17afe7e3a02c4587302 Reviewed-on: https://go-review.googlesource.com/34014 Reviewed-by: Russ Cox <rsc@golang.org>
| * cmd/go: ensure streaming test's stdout, stderr are same as cmd/go'sBrad Fitzpatrick2016-12-074-11/+96
| | | | | | | | | | | | | | | | Fixes #18153 Change-Id: Ie8a32dd6fe306f00e51cde77dd4ea353f7109940 Reviewed-on: https://go-review.googlesource.com/34010 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * reflect: add example for StructOfSebastien Binet2016-12-061-0/+41
| | | | | | | | | | | | | | | | | | | | | | This CL adds a simple example for StructOf. The example shows how StructOf can be used in a JSON roundtrip. Change-Id: I9ff1ea9cb8c0cf297c5fae74e68b89931076adfd Reviewed-on: https://go-review.googlesource.com/33953 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
| * net/http: update bundled http2Brad Fitzpatrick2016-12-061-9/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates bundled x/net/http2 to git rev 8dab9293 for: http2: make Transport retry on server's GOAWAY graceful shutdown https://golang.org/cl/33971 Fixes #18083 Change-Id: I676f5eb4b490a4d86356778bb17296c451f16d90 Reviewed-on: https://go-review.googlesource.com/34011 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com>
| * cmd/link: hash packages after loading all symbolsDavid Crawshaw2016-12-063-13/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | Conditioning on the plugin.Open symbol existing before loading all symbols means sometimes some packages don't have a hash value. Fixes #17928 Change-Id: I2722449aa58eca08a25117d3ce976f11f805b5ac Reviewed-on: https://go-review.googlesource.com/33925 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * cmd/compile: fix static-initialization compilation failureMatthew Dempsky2016-12-061-1/+3
| | | | | | | | | | | | | | | | | | | | | | Fixes #13263. Change-Id: Ie1cafc62b6bfe6c5381c35d9a95563267b4cc9b0 Reviewed-on: https://go-review.googlesource.com/33970 Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * net/http: fix typo in Request.GetBody's doc stringChris Broadfoot2016-12-061-1/+1
| | | | | | | | | | | | Change-Id: I84043b6fe4b20a2514d47217e07e44f26bec52ab Reviewed-on: https://go-review.googlesource.com/33973 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime/cgo: retry pthread_create on EAGAIN for OpenBSDIan Lance Taylor2016-12-054-3/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For reasons that I do not know, OpenBSD does not call pthread_create directly, but instead looks it up in libpthread.so. That means that we can't use the code used on other systems to retry pthread_create on EAGAIN, since that code simply calls pthread_create. This patch copies that code to an OpenBSD-specific version. Also, check for an EAGAIN failure in the test, as that seems to be the underlying cause of the test failure on several systems including OpenBSD. Fixes #18146. Change-Id: I3bceaa1e03a7eaebc2da19c9cc146b25b59243ef Reviewed-on: https://go-review.googlesource.com/33905 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime/cgo: retry pthread_create on EAGAINIan Lance Taylor2016-12-0522-21/+72
| | | | | | | | | | | | | | | | | | | | Update #18146. Change-Id: Ib447aabae9f203a8b61fb8c984b57d8e2bfe69c2 Reviewed-on: https://go-review.googlesource.com/33894 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime: don't skip TestCgoCallbackGC on FreeBSDIan Lance Taylor2016-12-051-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | Seems to be fixed according to discussion on issue 16396. Fixes #16396. Change-Id: Ibac7037a24280204e48cb4d3000af524f65afd36 Reviewed-on: https://go-review.googlesource.com/33903 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
View Lorry Controller Status