summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
| * cmd/go: skip flaky TestCgoConsistentResults on FreeBSDMikio Hara2016-12-221-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | FreeBSD 11 or above uses clang-3.6 or higher by default. Updates #15405. Change-Id: If49ce298130165f9e1525c7fd0fd5aa39099ad53 Reviewed-on: https://go-review.googlesource.com/34675 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * runtime: avoid CreateThread panic when exiting processAustin Clements2016-12-211-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Windows, CreateThread occasionally fails with ERROR_ACCESS_DENIED. We're not sure why this is, but the Wine source code suggests that this can happen when there's a concurrent CreateThread and ExitProcess in the same process. Fix this by setting a flag right before calling ExitProcess and halting if CreateThread fails and this flag is set. Updates #18253 (might fix it, but we're not sure this is the issue and can't reproduce it on demand). Change-Id: I1945b989e73a16cf28a35bf2613ffab07577ed4e Reviewed-on: https://go-review.googlesource.com/34616 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * cmd/compile/internal/ssa: add tests for BSWAP on stores on AMD64Kirill Smelkov2016-12-211-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 10f75748 (CL 32222) taught AMD64 backend to rewrite series of byte loads or stores with corresponding shifts into a single long or quad load or store + appropriate BSWAP. However it did not added test for stores - only loads were tested. Fix it. NOTE Tests for indexed stores are not added because 10f75748 did not add support for indexed stores - only indexed loads were handled then. Change-Id: I48c867ebe7622ac8e691d43741feed1d40cca0d7 Reviewed-on: https://go-review.googlesource.com/34634 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * io: fix PipeWriter.Close to wake up WritesKirill Smelkov2016-12-212-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit cc62bed0 (CL 994043) the pipe deadlock when doing Read+Close or Write+Close on same end was fixed, alas with test for Read+Close case only. Then commit 6d6f3381 (CL 4252057) made a thinko: in the writer path p.werr is checked for != nil and then err is set but there is no break from waiting loop unlike break is there in similar condition for reader. Together with having only Read+Close case tested that made it to leave reintroduced Write+Close deadlock unnoticed. Fix it. Implicitly this also fixes net.Pipe to conform to semantic of net.Conn interface where Close is documented to unblock any blocked Read or Write operations. No test added to net/ since net.Pipe tests are "Assuming that the underlying io.Pipe implementation is solid and we're just testing the net wrapping". The test added in this patch should be enough to cover the breakage. Fixes #18401 Updates #18170 Change-Id: I9e9460b3fd7d220bbe60b726accf86f352aed8d4 Reviewed-on: https://go-review.googlesource.com/34637 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
| * go/parser: fix reference in ParseExprFrom docsTakuya Ueda2016-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | The ParseExprFrom docs refer to Parse. It meant ParseFile. Fixes #18398 Change-Id: I06fb3b5178c6319e86199823fe4769a8eb9dc49c Reviewed-on: https://go-review.googlesource.com/34671 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * Revert "cmd/go: note when some Go files were ignored on no-Go-files errors"Brad Fitzpatrick2016-12-213-22/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit eee727d0855b9e78f9df87e08d57b1d7f264876c (https://golang.org/cl/29113) The " (.go files ignored due to build tags)" error message is not always accurate. Fixes #18396 Updates #17008 Change-Id: I609653120603a7f6094bc1dc3a83856f4b259241 Reviewed-on: https://go-review.googlesource.com/34662 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
| * cmd/vet: avoid crash in cgo test on recursive typeIan Lance Taylor2016-12-213-9/+14
| | | | | | | | | | | | | | | | | | | | | | This CL also re-enables the cgo tests that were accidentally disabled in CL 32754. Fixes #18389. Change-Id: I2fdc4fe3ec1f92b7da3db3fa66f4e0f806fc899f Reviewed-on: https://go-review.googlesource.com/34660 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * net: make InterfaceByIndex return a consistent name on solarisMikio Hara2016-12-214-28/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also retightens test cases for Resolve{TCP,UDP,IP}Addr which are using interface names for specifying IPv6 zone. Updates #14037. Fixes #18362. Change-Id: I7444b6302e2847dfbdab8a0ad5b2e702bed1a3d6 Reviewed-on: https://go-review.googlesource.com/34670 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * net: fix LookupCNAME on Plan 9David du Colombier2016-12-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In CL 34650, LookupCNAME was changed so it always returns the canonical DNS host, even when there is no CNAME record. Consequently, TestLookupCNAME was failing on Plan 9, because www.google.com doesn't have a CNAME record. We changed the implementation of lookupCNAME on Plan 9, so it returns the canonical DNS host after a CNAME lookup failure. Fixes #18391. Change-Id: I59f361bfb2c9de3953e998e8ac58c054979210bd Reviewed-on: https://go-review.googlesource.com/34633 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * net/http, doc: more redirect documentationBrad Fitzpatrick2016-12-202-0/+27
| | | | | | | | | | | | | | | | | | Updates #18347 Updates #9348 Change-Id: I115203b0be3eb2e7e269ff28e2f3c47eeca86038 Reviewed-on: https://go-review.googlesource.com/34657 Reviewed-by: Russ Cox <rsc@golang.org>
| * net: mark TestDialerDualStackFDLeak as flaky on OpenBSDBrad Fitzpatrick2016-12-201-0/+2
| | | | | | | | | | | | | | | | | | Updates #15157 Change-Id: Id280705f4382c3b2323f0eed786a400a184614de Reviewed-on: https://go-review.googlesource.com/34656 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
| * net: make LookupCNAME's native behavior match its cgo behaviorMatthew Dempsky2016-12-206-84/+83
| | | | | | | | | | | | | | | | | | Fixes #18172. Change-Id: I4a21fb5c0753cced025a03d88a6dd1aa3ee01d05 Reviewed-on: https://go-review.googlesource.com/34650 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com>
| * runtime: avoid incorrect panic when a signal arrives during STWAustin Clements2016-12-201-6/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop-the-world and freeze-the-world (used for unhandled panics) are currently not safe to do at the same time. While a regular unhandled panic can't happen concurrently with STW (if the P hasn't been stopped, then the panic blocks the STW), a panic from a _SigThrow signal can happen on an already-stopped P, racing with STW. When this happens, freezetheworld sets sched.stopwait to 0x7fffffff and stopTheWorldWithSema panics because sched.stopwait != 0. Fix this by detecting when freeze-the-world happens before stop-the-world has completely stopped the world and freeze the STW operation rather than panicking. Fixes #17442. Change-Id: I646a7341221dd6d33ea21d818c2f7218e2cb7e20 Reviewed-on: https://go-review.googlesource.com/34611 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * crypto/x509: fix spelling/grammar in commentsKevin Burke2016-12-201-4/+4
| | | | | | | | | | | | | | | | Also tweak one of the comment lines to fit in 80 characters. Change-Id: I9c6d2028c29318ba9264486590056cb1ffc8219e Reviewed-on: https://go-review.googlesource.com/34655 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * crypto/x509: speed up and deflake non-cgo Darwin root cert discoveryBrad Fitzpatrick2016-12-202-60/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Piping into security verify-cert only worked on macOS Sierra, and was flaky for unknown reasons. Users reported that the number of trusted root certs stopped randomly jumping around once they switched to using verify-cert against files on disk instead of /dev/stdin. But even using "security verify-cert" on 150-200 certs took too long. It took 3.5 seconds on my machine. More than 4 goroutines hitting verify-cert didn't help much, and soon started to hurt instead. New strategy, from comments in the code: // 1. Run "security trust-settings-export" and "security // trust-settings-export -d" to discover the set of certs with some // user-tweaked trusy policy. We're too lazy to parse the XML (at // least at this stage of Go 1.8) to understand what the trust // policy actually is. We just learn that there is _some_ policy. // // 2. Run "security find-certificate" to dump the list of system root // CAs in PEM format. // // 3. For each dumped cert, conditionally verify it with "security // verify-cert" if that cert was in the set discovered in Step 1. // Without the Step 1 optimization, running "security verify-cert" // 150-200 times takes 3.5 seconds. With the optimization, the // whole process takes about 180 milliseconds with 1 untrusted root // CA. (Compared to 110ms in the cgo path) Fixes #18203 Change-Id: I4e9c11fa50d0273c615382e0d8f9fd03498d4cb4 Reviewed-on: https://go-review.googlesource.com/34389 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Quentin Smith <quentin@golang.org>
| * cmd/cover: fix spelling mistakeKevin Burke2016-12-201-1/+1
| | | | | | | | | | | | Change-Id: Iac7c4f22dc55c970940af33e0f0470694da5c4a6 Reviewed-on: https://go-review.googlesource.com/34654 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * Revert: "archive/zip: handle mtime in NTFS/UNIX/ExtendedTS extra fields"Joe Tsai2016-12-207-154/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change reverts the following CLs: CL/18274: handle mtime in NTFS/UNIX/ExtendedTS extra fields CL/30811: only use Extended Timestamp on non-zero MS-DOS timestamps We are reverting support for extended timestamps since the support was not not complete. CL/18274 added full support for reading extended timestamp fields and minimal support for writing them. CL/18274 is incomplete because it made no changes to the FileHeader struct, so timezone information was lost when reading and/or writing. While CL/18274 was a step in the right direction, we should provide full support for high precision timestamps in both the reader and writer. This will probably require that we add a new field of type time.Time. The complete fix is too involved to add in the time remaining for Go 1.8 and will be completed in Go 1.9. Updates #10242 Updates #17403 Updates #18359 Fixes #18378 Change-Id: Icf6d028047f69379f7979a29bfcb319a02f4783e Reviewed-on: https://go-review.googlesource.com/34651 Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/cover: retain un-attached compiler directivesDhananjay Nakrani2016-12-203-11/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Parser doesn't attach some compiler directives to anything in the tree. We have to explicitely retain them in the generated code. This change, makes cover explicitely print out any compiler directive that wasn't handled in the ast.Visitor. Fixes #18285. Change-Id: Ib60f253815e92d7fc85051a7f663a61116e40a91 Reviewed-on: https://go-review.googlesource.com/34563 Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
| * runtime: use mincore to detect physical page size as last resort on AndroidShenghou Ma2016-12-191-0/+20
| | | | | | | | | | | | | | | | Fixes #18041. Change-Id: Iad1439b2dd56b113c8829699eda467d1367b0e15 Reviewed-on: https://go-review.googlesource.com/34610 Reviewed-by: Austin Clements <austin@google.com>
| * runtime: clean up and improve reflect.methodValue commentsAustin Clements2016-12-192-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The runtime no longer hard-codes the offset of reflect.methodValue.stack, so remove these obsolete comments. Also, reflect.methodValue and runtime.reflectMethodValue must also agree with reflect.makeFuncImpl, so update the comments on all three to mention this. This was pointed out by Minux on CL 31138. Change-Id: Ic5ed1beffb65db76aca2977958da35de902e8e58 Reviewed-on: https://go-review.googlesource.com/34590 Reviewed-by: Keith Randall <khr@golang.org>
| * cmd/compile: test for correct zeroingKeith Randall2016-12-191-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we generate the right code for zeroing a structure. Check in after Matthew's CL (34564). Update #18370 Change-Id: I987087f979d99227a880b34c44d9d4de6c25ba0c Reviewed-on: https://go-review.googlesource.com/34565 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Keith Randall <khr@golang.org>
| * cmd/go: fix doc about examples with empty OutputAlberto Donizetti2016-12-192-2/+4
| | | | | | | | | | | | | | | | Fixes #18191 Change-Id: Ic2bac9d2a6f42d14e780c74d9c842ee344ab030a Reviewed-on: https://go-review.googlesource.com/34512 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/compile: restore zero assignment optimization for non-pointer typesMatthew Dempsky2016-12-191-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | golang.org/cl/31572 disabled some write barrier optimizations, but inadvertantly disabled optimizations for some non-pointer composite literal assignments too. Fixes #18370. Change-Id: Ia25019bd3016b6ab58173298c7d16202676bce6b Reviewed-on: https://go-review.googlesource.com/34564 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
| * crypto/tls: fix a typoMikio Hara2016-12-191-1/+1
| | | | | | | | | | | | | | | | Change-Id: Id0044c45c23c12ee0bca362a9cdd25369ed7776c Reviewed-on: https://go-review.googlesource.com/34533 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/compile, runtime: a different approach to duplicate itabsMichael Hudson-Doyle2016-12-193-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | golang.org/issue/17594 was caused by additab being called more than once for an itab. golang.org/cl/32131 fixed that by making the itabs local symbols, but that in turn causes golang.org/issue/18252 because now there are now multiple itab symbols in a process for a given (type,interface) pair and different code paths can end up referring to different itabs which breaks lots of reflection stuff. So this makes itabs global again and just takes care to only call additab once for each itab. Fixes #18252 Change-Id: I781a193e2f8dd80af145a3a971f6a25537f633ea Reviewed-on: https://go-review.googlesource.com/34173 Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
| * path/filepath: deprecate HasPrefixJoe Tsai2016-12-163-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the new "Deprecated:" syntax for all instances of HasPrefix. This is a follow-up to http://golang.org/cl/28413 which only modified path_unix.go. In this CL, we avoid mentioning that strings.HasPrefix should be used since that function is still subtly wrong in security applications. See http://golang.org/cl/5712045 for more information. Fixes #18355 Change-Id: I0d0306152cd0b0ea5110774c2c78117515b9f5cd Reviewed-on: https://go-review.googlesource.com/34554 Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime: cross-reference _func type betterAustin Clements2016-12-162-1/+4
| | | | | | | | | | | | | | | | | | | | It takes me several minutes every time I want to find where the linker writes out the _func structures. Add some comments to make this easier. Change-Id: Ic75ce2786ca4b25726babe3c4fe9cd30c85c34e2 Reviewed-on: https://go-review.googlesource.com/34390 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * runtime/pprof: fix spelling in testKevin Burke2016-12-161-1/+1
| | | | | | | | | | | | Change-Id: Id10e41fe396156106f63a4b29d673b31bea5358f Reviewed-on: https://go-review.googlesource.com/34551 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * net: clarify IP.IsGlobalUnicast docsMikio Hara2016-12-161-0/+6
| | | | | | | | | | | | | | | | | | | | Fixes #18181. Change-Id: I5eed99dfb7b013aa4d4e668e95a97f5bb643d307 Reviewed-on: https://go-review.googlesource.com/34531 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime/pprof: deflake tests for heavily loaded systemsIan Lance Taylor2016-12-161-1/+5
| | | | | | | | | | | | | | | | | | | | In the sampling tests, let the test pass if we get at least 10 samples. Fixes #18332. Change-Id: I8aad083d1a0ba179ad6663ff43f6b6b3ce1e18cd Reviewed-on: https://go-review.googlesource.com/34507 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime: preserve callee-saved C registers in sigtrampBryan C. Mills2016-12-158-25/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes Linux and the *BSD platforms on 386/amd64. A few OS/arch combinations were already saving registers and/or doing something that doesn't clearly resemble the SysV C ABI; those have been left alone. Fixes #18328. Change-Id: I6398f6c71020de108fc8b26ca5946f0ba0258667 Reviewed-on: https://go-review.googlesource.com/34501 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * net/http: deflake TestServerTimeouts maybeBrad Fitzpatrick2016-12-151-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I haven't been able to reproduce this one, but change a few suspect things in this test. Notably, using the global "Get" function and thus using the DefaultTransport was buggy in a parallel test. Then add some error checks and close a TCP connection. Hopefully the failure wasn't timing-related. Fixes #18036 (I hope) Change-Id: I4904e42e40b26d488cf82111424a1d4d46f42dae Reviewed-on: https://go-review.googlesource.com/34490 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * net/http: update bundled http2Chris Broadfoot2016-12-151-51/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates bundled x/net/http2 to git rev 1195a05d for: http2: fix incorrect panic https://golang.org/cl/34498 http2: fix race in writePushPromise https://golang.org/cl/34493 http2: speed up TestTransportFlowControl in short mode https://golang.org/cl/33241 http2: don't flush a stream's write queue in sc.resetStream https://golang.org/cl/34238 http2: allow Transport to connect to https://[v6literal]/ without port https://golang.org/cl/34143 http2: log Framer reads and writes when a server test fails https://golang.org/cl/34130 Updates #18326 Updates #18273 Updates #18111 Updates #18248 Updates #18235 Change-Id: I18c7a297fc94d6a843284efcfc43e0fdab9b5f41 Reviewed-on: https://go-review.googlesource.com/34495 Run-TryBot: Chris Broadfoot <cbro@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * net: fix comment on IPv4bcastMikio Hara2016-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | In Go 1.8, almost all the platforms except NaCl provide network interface and address identification and applications can use IPv4 limited or directed broadcast addresses appropriately. Fixes #18176. Change-Id: Ie5de834d19c0aaeb4128a3ca655f6c4c9ae5e501 Reviewed-on: https://go-review.googlesource.com/34435 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/pprof: search for sample types in profileRaul Silvera2016-12-151-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Search the sample types in the profile being processed to map sample type options to indices in the profile sample type array. Previously these were hardcoded, which caused issues when the sample types for a profile type changed. For instance, this was triggered by the native generation of profiles in profile.proto format. This fixes #18230. A similar mechanism already exists on the upstream pprof. Change-Id: I945d8d842a0c2ca14299dabefe83124746ecd7e2 Reviewed-on: https://go-review.googlesource.com/34382 Reviewed-by: Michael Matloob <matloob@golang.org>
| * net: fix ParseCIDR docsMikio Hara2016-12-151-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change replaces the remaining use of "mask" with "prefix length" and uses IPv4 reserved address blocks for documentation. UPdates #15228. Updates #18175. Change-Id: I56c4f1205821c64f3195b023ad515b9d54e33f64 Reviewed-on: https://go-review.googlesource.com/34431 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/go, plugin: disable plugins on darwinDavid Crawshaw2016-12-153-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We are seeing a bad stack map in #18190. In a copystack, it is mistaking a slot for a pointer. Presumably this is caused either by our fledgling dynlink support on darwin, or a consequence of having two copies of the runtime in the process. But I have been unable to work out which in the 1.8 window, so pushing darwin support to 1.9 or later. Change-Id: I7fa4d2dede75033d9a428f24c1837a4613bd2639 Reviewed-on: https://go-review.googlesource.com/34391 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * net: fix typoKevin Burke2016-12-151-1/+1
| | | | | | | | | | | | Change-Id: Icef8a21654a248666c684d5b10d0337c544ddb25 Reviewed-on: https://go-review.googlesource.com/34388 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * runtime: fix mips assemblyCherry Zhang2016-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | I meant to say ~7, instead of ^7, in the review. Fix build. Change-Id: I5060bbcd98b4ab6f00251fdb68b6b35767e5acf1 Reviewed-on: https://go-review.googlesource.com/34411 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * net: fix consecutive dialing docsIan Lance Taylor2016-12-151-6/+8
| | | | | | | | | | | | | | | | Update #17617. Change-Id: Ia0bc9954bb914b650b7c7af35ef714ca6b0740b4 Reviewed-on: https://go-review.googlesource.com/34376 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| * cmd/dist: enable cgo by default for GOARCH=mips{,le}Vladimir Stefanovic2016-12-152-3/+3
| | | | | | | | | | | | | | | | Change-Id: I7dd927be1e702e8fd469f4834ab918e0bcd9bafc Reviewed-on: https://go-review.googlesource.com/34318 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * net/http/httptrace: clarify WroteRequest may be called multiple timesBrad Fitzpatrick2016-12-151-1/+2
| | | | | | | | | | | | | | | | Updates #18305 Change-Id: I63b28d511df1a6c54e32c8bfc7e2264f94e38cd7 Reviewed-on: https://go-review.googlesource.com/34386 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * cmd/objdump: disable objdump_test with external linking on GOARCH=mips{,le}Vladimir Stefanovic2016-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | Updates #12559. Change-Id: I5e8f4cf7071d0d71618527a6b6096e771d5eeb28 Reviewed-on: https://go-review.googlesource.com/34317 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * runtime: add cgo support for GOARCH=mips{,le}Vladimir Stefanovic2016-12-147-24/+422
| | | | | | | | | | | | | | | | Change-Id: Ib425ead7b340672837d3cb983bd785488706bd6d Reviewed-on: https://go-review.googlesource.com/34314 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * cmd/link: add external linking support for GOARCH=mips{,le}Vladimir Stefanovic2016-12-144-17/+96
| | | | | | | | | | | | | | | | | | | | Fixes #17792. Change-Id: If4f24455eec0edb3b221aef6777a681f6c768866 Reviewed-on: https://go-review.googlesource.com/34313 Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * cmd/link: do not export plugin C symbolsDavid Crawshaw2016-12-143-3/+66
| | | | | | | | | | | | | | | | | | | | | | Explicitly filter any C-only cgo functions out of pclntable, which allows them to be duplicated with the host binary. Updates #18190. Change-Id: I50d8706777a6133b3e95f696bc0bc586b84faa9e Reviewed-on: https://go-review.googlesource.com/34199 Reviewed-by: Ian Lance Taylor <iant@golang.org>
| * net/http: deflake TestClientTimeout_Headers_h2 on WindowsBrad Fitzpatrick2016-12-141-13/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The client code was using time.Now() (wall time) to determine whether the cause of a non-nil error meant that a timeout had occured. But on Windows, the clock used for timers (time.After, time.Sleep, etc) is much more accurate than the time.Now clock, which doesn't update often. But it turns out that as of the recent https://golang.org/cl/32478 we already have the answer available easily. It just wasn't in scope. Instead of passing this information along by decorating the errors (risky this late in Go 1.8, especially with #15935 unresolved), just passing along the "didTimeout" func internally for now. We can remove that later in Go 1.9 if we overhaul Transport errors. Fixes #18287 (I hope) Change-Id: Icbbfceaf02de6c7ed04fe37afa4ca16374b58f3c Reviewed-on: https://go-review.googlesource.com/34381 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
| * go/internal/gccgoimporter: accept missed portions of v2 formatRobert Griesemer2016-12-144-4/+19
| | | | | | | | | | | | | | | | | | | | | | Fixes #18301. Change-Id: I990c105904ab62f2225d671bbc10209ec51b12e2 Reviewed-on: https://go-review.googlesource.com/34371 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
| * runtime: correct writebarrier typosEuan Kemp2016-12-141-2/+2
| | | | | | | | | | | | | | | | Change-Id: I7d67c3d64be915f0be5932d2c068606d74f93c29 Reviewed-on: https://go-review.googlesource.com/34378 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
| * database/sql: do not store Tx options in ContextDaniel Theophanes2016-12-145-77/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | Drivers which previously supported tip will need to update to this revision before release. Fixes #18284 Change-Id: I70b8e7afff1558a8b5348885ce9f50e067c72ee9 Reviewed-on: https://go-review.googlesource.com/34330 Run-TryBot: Daniel Theophanes <kardianos@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
View Lorry Controller Status