<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/haproxy.git/include/haproxy/http_rules.h, branch master</title>
<subtitle>github.com: haproxy/haproxy.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/'/>
<entry>
<title>MINOR: proxy: add http_free_redirect_rule() function</title>
<updated>2023-05-11T13:37:04+00:00</updated>
<author>
<name>Aurelien DARRAGON</name>
<email>adarragon@haproxy.com</email>
</author>
<published>2023-05-11T08:30:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=7abc9224a69eb5f1b592336044257b38823a8fe3'/>
<id>7abc9224a69eb5f1b592336044257b38823a8fe3</id>
<content type='text'>
Adding http_free_redirect_rule() function to free a single redirect rule
since it may be required to free rules outside of free_proxy() function.

This patch is required for an upcoming bugfix.

[for 2.2, free_proxy function did not exist (first seen in 2.4), thus
http_free_redirect_rule() needs to be deducted from haproxy.c deinit()
function if the patch is required]
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adding http_free_redirect_rule() function to free a single redirect rule
since it may be required to free rules outside of free_proxy() function.

This patch is required for an upcoming bugfix.

[for 2.2, free_proxy function did not exist (first seen in 2.4), thus
http_free_redirect_rule() needs to be deducted from haproxy.c deinit()
function if the patch is required]
</pre>
</div>
</content>
</entry>
<entry>
<title>BUILD: http_rules: do not declare http_*_keywords_registre() inline</title>
<updated>2022-03-02T13:50:38+00:00</updated>
<author>
<name>Willy Tarreau</name>
<email>w@1wt.eu</email>
</author>
<published>2022-03-02T13:50:38+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=368479c3fc2183423b777e91e2770035dcc21705'/>
<id>368479c3fc2183423b777e91e2770035dcc21705</id>
<content type='text'>
The 3 functions http_{req,res,after_res}_keywords_register() are
referenced in initcalls by their pointer, it makes no sense to declare
them inline. At best it causes function duplication, at worst it doesn't
build on older compilers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The 3 functions http_{req,res,after_res}_keywords_register() are
referenced in initcalls by their pointer, it makes no sense to declare
them inline. At best it causes function duplication, at worst it doesn't
build on older compilers.
</pre>
</div>
</content>
</entry>
<entry>
<title>CLEANUP: lists/tree-wide: rename some list operations to avoid some confusion</title>
<updated>2021-04-21T07:20:17+00:00</updated>
<author>
<name>Willy Tarreau</name>
<email>w@1wt.eu</email>
</author>
<published>2021-04-21T05:32:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=2b71810cb3a45c8a52537a72ff0198fa6ae298b7'/>
<id>2b71810cb3a45c8a52537a72ff0198fa6ae298b7</id>
<content type='text'>
The current "ADD" vs "ADDQ" is confusing because when thinking in terms
of appending at the end of a list, "ADD" naturally comes to mind, but
here it does the opposite, it inserts. Several times already it's been
incorrectly used where ADDQ was expected, the latest of which was a
fortunate accident explained in 6fa922562 ("CLEANUP: stream: explain
why we queue the stream at the head of the server list").

Let's use more explicit (but slightly longer) names now:

   LIST_ADD        -&gt;       LIST_INSERT
   LIST_ADDQ       -&gt;       LIST_APPEND
   LIST_ADDED      -&gt;       LIST_INLIST
   LIST_DEL        -&gt;       LIST_DELETE

The same is true for MT_LISTs, including their "TRY" variant.
LIST_DEL_INIT keeps its short name to encourage to use it instead of the
lazier LIST_DELETE which is often less safe.

The change is large (~674 non-comment entries) but is mechanical enough
to remain safe. No permutation was performed, so any out-of-tree code
can easily map older names to new ones.

The list doc was updated.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current "ADD" vs "ADDQ" is confusing because when thinking in terms
of appending at the end of a list, "ADD" naturally comes to mind, but
here it does the opposite, it inserts. Several times already it's been
incorrectly used where ADDQ was expected, the latest of which was a
fortunate accident explained in 6fa922562 ("CLEANUP: stream: explain
why we queue the stream at the head of the server list").

Let's use more explicit (but slightly longer) names now:

   LIST_ADD        -&gt;       LIST_INSERT
   LIST_ADDQ       -&gt;       LIST_APPEND
   LIST_ADDED      -&gt;       LIST_INLIST
   LIST_DEL        -&gt;       LIST_DELETE

The same is true for MT_LISTs, including their "TRY" variant.
LIST_DEL_INIT keeps its short name to encourage to use it instead of the
lazier LIST_DELETE which is often less safe.

The change is large (~674 non-comment entries) but is mechanical enough
to remain safe. No permutation was performed, so any out-of-tree code
can easily map older names to new ones.

The list doc was updated.
</pre>
</div>
</content>
</entry>
<entry>
<title>MINOR: actions: Export actions lookup functions</title>
<updated>2020-12-02T08:45:18+00:00</updated>
<author>
<name>Thierry Fournier</name>
<email>thierry.fournier@ozon.io</email>
</author>
<published>2020-11-28T16:40:24+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=7a71a6d9d262d7a0f7c3d208ab339d469958011d'/>
<id>7a71a6d9d262d7a0f7c3d208ab339d469958011d</id>
<content type='text'>
These functions will be useful to check if a keyword is already registered.
This will be needed by a next patch to fix a bug, and will need to be
backported.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These functions will be useful to check if a keyword is already registered.
This will be needed by a next patch to fix a bug, and will need to be
backported.
</pre>
</div>
</content>
</entry>
<entry>
<title>CLEANUP: include: tree-wide alphabetical sort of include files</title>
<updated>2020-06-11T08:18:59+00:00</updated>
<author>
<name>Willy Tarreau</name>
<email>w@1wt.eu</email>
</author>
<published>2020-06-09T07:07:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=b2551057af2e10584c39526dbea901213febf86c'/>
<id>b2551057af2e10584c39526dbea901213febf86c</id>
<content type='text'>
This patch fixes all the leftovers from the include cleanup campaign. There
were not that many (~400 entries in ~150 files) but it was definitely worth
doing it as it revealed a few duplicates.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch fixes all the leftovers from the include cleanup campaign. There
were not that many (~400 entries in ~150 files) but it was definitely worth
doing it as it revealed a few duplicates.
</pre>
</div>
</content>
</entry>
<entry>
<title>REORG: include: move proxy.h to haproxy/proxy{,-t}.h</title>
<updated>2020-06-11T08:18:58+00:00</updated>
<author>
<name>Willy Tarreau</name>
<email>w@1wt.eu</email>
</author>
<published>2020-06-04T20:29:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=a264d960f687140f833a02358f3c362cb4587c20'/>
<id>a264d960f687140f833a02358f3c362cb4587c20</id>
<content type='text'>
This one is particularly difficult to split because it provides all the
functions used to manipulate a proxy state and to retrieve names or IDs
for error reporting, and as such, it was included in 73 files (down to
68 after cleanup). It would deserve a small cleanup though the cut points
are not obvious at the moment given the number of structs involved in
the struct proxy itself.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This one is particularly difficult to split because it provides all the
functions used to manipulate a proxy state and to retrieve names or IDs
for error reporting, and as such, it was included in 73 files (down to
68 after cleanup). It would deserve a small cleanup though the cut points
are not obvious at the moment given the number of structs involved in
the struct proxy itself.
</pre>
</div>
</content>
</entry>
<entry>
<title>REORG: include: move http_rules.h to haproxy/http_rules.h</title>
<updated>2020-06-11T08:18:57+00:00</updated>
<author>
<name>Willy Tarreau</name>
<email>w@1wt.eu</email>
</author>
<published>2020-06-04T09:40:28+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/haproxy.git/commit/?id=c761f843dac07a884d76978983d45d24f54b7752'/>
<id>c761f843dac07a884d76978983d45d24f54b7752</id>
<content type='text'>
There was no include file. This one still includes types/proxy.h.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There was no include file. This one still includes types/proxy.h.
</pre>
</div>
</content>
</entry>
</feed>
