delta/java/ant.git, branch java-10-version

try to adapt to Java10+ rapidly changing major versions

2017-11-29T15:17:34+00:00

BZ-61718 Upgrade to 0.1.54 of Jsch library

2017-11-05T11:08:09+00:00

This close #48 pull request at github/apache/ant

Remove the redundant nullcheck of value known to be non-null.

2017-10-15T05:25:19+00:00

This statement contains a redundant check of a known non-null s against the constant null.
http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

properly handle factory configuration exception

2017-10-15T05:24:40+00:00

based on patch by Kui Liu

createAndSet never returns null

2017-10-15T05:24:15+00:00

based on pytch by Kui Liu

Fix the inefficient use of keySet iterator with entrySet iterator.

2017-10-13T06:42:41+00:00

The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator.
It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup.

Fix the problem of using '+=' operator to concatenate strings a in a loop.

2017-10-13T06:32:09+00:00

The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a StringBuilder, appended to, and converted back to a String.
This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration.
Better performance can be obtained by using a StringBuilder explicitly.
http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION

credit Kui Liu for #41

2017-10-11T12:06:07+00:00

forgot to credit George Bateman

2017-10-11T11:06:16+00:00

Fix the problem of instanceof test always return true.

2017-10-11T10:03:11+00:00

This instanceof test will always return true because DataType is the superclass of variable nested's class ResourceComparator. The variable nested is not initialized, it would be better to do a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF