delta/libgit2.git, branch peff/binary-search-do-while github.com: libgit2/libgit2.git sha1_position: convert do-while to while 2017-08-09T20:34:02+00:00 Jeff King peff@peff.net 2017-08-09T20:34:02+00:00 09930192b903e15d5c55afc2fd83d6f37ba6edd9 If we enter the sha1_position() function with "lo == hi", we have no elements. But the do-while loop means that we'll enter the loop body once anyway, picking "mi" at that same value and comparing nonsense to our desired key. This is unlikely to match in practice, but we still shouldn't be looking at the memory in the first place. This bug is inherited from git.git; it was fixed there in e01580cfe01526ec2c4eb4899f776a82ade7e0e1. 
If we enter the sha1_position() function with "lo == hi",
we have no elements. But the do-while loop means that we'll
enter the loop body once anyway, picking "mi" at that same
value and comparing nonsense to our desired key. This is
unlikely to match in practice, but we still shouldn't be
looking at the memory in the first place.

This bug is inherited from git.git; it was fixed there in
e01580cfe01526ec2c4eb4899f776a82ade7e0e1.
Merge pull request #4304 from pks-t/pks/patch-buffers 2017-07-31T00:20:21+00:00 Edward Thomson ethomson@edwardthomson.com 2017-07-31T00:20:21+00:00 a9d6b9d529daa920b558ee3f34151422d10bc95e patch_generate: represent buffers as void pointers 
patch_generate: represent buffers as void pointers
 Merge pull request #4323 from libgit2/ethomson/remove_sys_remote_h 2017-07-31T00:17:24+00:00 Edward Thomson ethomson@edwardthomson.com 2017-07-31T00:17:24+00:00 dca8c44f4f882098a9653a42d37194d7e3782119 Remove unused 'sys/remote.h' header 
Remove unused 'sys/remote.h' header
 Merge branch '4233' 2017-07-30T23:59:27+00:00 Edward Thomson ethomson@edwardthomson.com 2017-07-30T23:58:58+00:00 fb585d01205e1a0b580a39f9cbdc829ff63e02c9 






changelog: update to reflect `detached` api name
2017-07-30T23:58:35+00:00

Edward Thomson
ethomson@edwardthomson.com

2017-07-30T23:58:35+00:00

868ce84f9ed21f8881b3c66b2363b29b219a99ab












Remove unused 'sys/remote.h' header
2017-07-30T23:38:28+00:00

Edward Thomson
ethomson@edwardthomson.com

2017-07-30T23:38:28+00:00

37841317377aee4ce08ce3787d88dd24f3d7b982












Merge pull request #4320 from pks-t/pks/rebase-submodule-asserts
2017-07-28T10:19:24+00:00

Edward Thomson
ethomson@edwardthomson.com

2017-07-28T10:19:24+00:00

d55431ebfaf3958ca2030ac73a3caff9c8507b4c

tests: rebase::submodule: verify initialization method calls




tests: rebase::submodule: verify initialization method calls






tests: rebase::submodule: verify initialization method calls
2017-07-28T07:01:41+00:00

Patrick Steinhardt
ps@pks.im

2017-07-28T07:01:41+00:00

c0558c62989215d724ebc3b267ae1022618c49e8

Some return codes for functions which may fail are not being checked in
`test_rebase_submodule__initialize`. This may lead us to not notice
errors when initializing the environment and would possibly result in
either memory corruption or segfaults as soon as any of the
initialization steps fails. Fix this by wrapping these function calls
into `cl_git_pass`.





Some return codes for functions which may fail are not being checked in
`test_rebase_submodule__initialize`. This may lead us to not notice
errors when initializing the environment and would possibly result in
either memory corruption or segfaults as soon as any of the
initialization steps fails. Fix this by wrapping these function calls
into `cl_git_pass`.







Merge pull request #4275 from tiennou/fix-rebase-submodule-test
2017-07-27T22:05:53+00:00

Edward Thomson
ethomson@edwardthomson.com

2017-07-27T22:05:53+00:00

4f4bc5732baf4545ab42bbd80d2a971e2f1e316c

tests: rewrite rebase-submodule .gitmodule file




tests: rewrite rebase-submodule .gitmodule file






Merge pull request #4314 from pks-t/pks/timsort
2017-07-26T22:24:28+00:00

Edward Thomson
ethomson@edwardthomson.com

2017-07-26T22:24:28+00:00

ed00ac06049b05992b677ef970071fe4129b2781

tsort: remove idempotent conditional assignment




tsort: remove idempotent conditional assignment