<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/cmake, branch ethomson/test_https</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/'/>
<entry>
<title>cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIR</title>
<updated>2021-12-23T17:23:34+00:00</updated>
<author>
<name>Josh Junon</name>
<email>josh.junon@protonmail.com</email>
</author>
<published>2021-12-23T17:23:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=c5cd71b203cd73a815aa4bc8b9ef603800fa8b4b'/>
<id>c5cd71b203cd73a815aa4bc8b9ef603800fa8b4b</id>
<content type='text'>
Also applies to *_BINARY_DIR.

This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c,
which broke all users of libgit2 that use it as a CMake subdirectory
(via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers
to the root-most CMake directory, which in the case of
`add_subdirectory()` is a parent project to libgit2 and thus the paths
don't make any sense to the configuration files. Corollary,
CMAKE_SOURCE_DIR only makes sense if the CMake project is always the
root project - which can rarely be guaranteed.

In all honesty, CMake should deprecate and eventually remove
CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches
and confusion for years, they're rarely useful over
CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR,
and they cause a lot of confusing configuration and source
code layouts to boot.

Any time they are used, they break `add_subdirectory()` almost 100% of
the time, cause confusing error messages, and hide subtle bugs.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also applies to *_BINARY_DIR.

This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c,
which broke all users of libgit2 that use it as a CMake subdirectory
(via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers
to the root-most CMake directory, which in the case of
`add_subdirectory()` is a parent project to libgit2 and thus the paths
don't make any sense to the configuration files. Corollary,
CMAKE_SOURCE_DIR only makes sense if the CMake project is always the
root project - which can rarely be guaranteed.

In all honesty, CMake should deprecate and eventually remove
CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches
and confusion for years, they're rarely useful over
CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR,
and they cause a lot of confusing configuration and source
code layouts to boot.

Any time they are used, they break `add_subdirectory()` almost 100% of
the time, cause confusing error messages, and hide subtle bugs.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR</title>
<updated>2021-11-22T14:27:59+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-19T13:48:08+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=84083dcc8bd41332ccac9d7b537f3e254d79011c'/>
<id>84083dcc8bd41332ccac9d7b537f3e254d79011c</id>
<content type='text'>
Instead of using the project-specific `libgit2_SOURCE_DIR` and
`libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and
`CMAKE_BINARY_DIR`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of using the project-specific `libgit2_SOURCE_DIR` and
`libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and
`CMAKE_BINARY_DIR`.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: use WINHTTP when USE_WINHTTP is specified</title>
<updated>2021-11-17T13:25:56+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-17T13:25:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=1b8d14ac2a31eb48665ffbf2a984399a77ea62d8'/>
<id>1b8d14ac2a31eb48665ffbf2a984399a77ea62d8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: move sha1 source selection into CMakeLists.txt</title>
<updated>2021-11-14T12:25:41+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-12T04:09:44+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=2c154145a8f7ce3c01f1afc40e3934c1e43c377e'/>
<id>2c154145a8f7ce3c01f1afc40e3934c1e43c377e</id>
<content type='text'>
The select hashes module selects the hash; the CMakeLists.txt selects
the files to implement it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The select hashes module selects the hash; the CMakeLists.txt selects
the files to implement it.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: refactor global variables</title>
<updated>2021-11-14T12:25:41+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-12T03:10:51+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=395b3dc403621f1ab3c400780b057cae91c6f6c1'/>
<id>395b3dc403621f1ab3c400780b057cae91c6f6c1</id>
<content type='text'>
Update the global variables `LIBGIT2_OBJECTS` to
`LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update the global variables `LIBGIT2_OBJECTS` to
`LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: reformat modules</title>
<updated>2021-11-14T12:25:41+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-12T03:37:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=c3fec45645e6939b3604d2d233be6f97ff629f87'/>
<id>c3fec45645e6939b3604d2d233be6f97ff629f87</id>
<content type='text'>
Apply the standard project cmake formatting to the modules.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Apply the standard project cmake formatting to the modules.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: move missing-declarations warning to top-level</title>
<updated>2021-11-11T22:31:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T22:04:24+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=4a6ef5a4a6cabfaa7147aab28130da49e5b177ea'/>
<id>4a6ef5a4a6cabfaa7147aab28130da49e5b177ea</id>
<content type='text'>
We should enforce declarations throughout the code-base, including
examples, fuzzers and tests, not just in the `src` tree.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should enforce declarations throughout the code-base, including
examples, fuzzers and tests, not just in the `src` tree.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: refactor zlib selection</title>
<updated>2021-11-11T20:56:11+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T02:59:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=4e84ddd5b091b6e6e85ff6484e72d9f90da1c4b0'/>
<id>4e84ddd5b091b6e6e85ff6484e72d9f90da1c4b0</id>
<content type='text'>
Move zlib selection into its own cmake module.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move zlib selection into its own cmake module.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: refactor WinHTTP selection</title>
<updated>2021-11-11T20:56:11+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T02:58:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=83fa548078b0b35030ba028676d6b5674d86ba18'/>
<id>83fa548078b0b35030ba028676d6b5674d86ba18</id>
<content type='text'>
Move WinHTTP selection into its own cmake module.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move WinHTTP selection into its own cmake module.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: refactor libssh2 selection</title>
<updated>2021-11-11T20:56:11+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T02:55:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=e35a22a080ad8127c1b3f058e6eea99d50fcfc79'/>
<id>e35a22a080ad8127c1b3f058e6eea99d50fcfc79</id>
<content type='text'>
Move SSH selection into its own cmake module.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move SSH selection into its own cmake module.
</pre>
</div>
</content>
</entry>
</feed>
