<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/deps/winhttp, branch ethomson/test_https</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/'/>
<entry>
<title>cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIR</title>
<updated>2021-12-23T17:23:34+00:00</updated>
<author>
<name>Josh Junon</name>
<email>josh.junon@protonmail.com</email>
</author>
<published>2021-12-23T17:23:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=c5cd71b203cd73a815aa4bc8b9ef603800fa8b4b'/>
<id>c5cd71b203cd73a815aa4bc8b9ef603800fa8b4b</id>
<content type='text'>
Also applies to *_BINARY_DIR.

This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c,
which broke all users of libgit2 that use it as a CMake subdirectory
(via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers
to the root-most CMake directory, which in the case of
`add_subdirectory()` is a parent project to libgit2 and thus the paths
don't make any sense to the configuration files. Corollary,
CMAKE_SOURCE_DIR only makes sense if the CMake project is always the
root project - which can rarely be guaranteed.

In all honesty, CMake should deprecate and eventually remove
CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches
and confusion for years, they're rarely useful over
CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR,
and they cause a lot of confusing configuration and source
code layouts to boot.

Any time they are used, they break `add_subdirectory()` almost 100% of
the time, cause confusing error messages, and hide subtle bugs.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also applies to *_BINARY_DIR.

This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c,
which broke all users of libgit2 that use it as a CMake subdirectory
(via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers
to the root-most CMake directory, which in the case of
`add_subdirectory()` is a parent project to libgit2 and thus the paths
don't make any sense to the configuration files. Corollary,
CMAKE_SOURCE_DIR only makes sense if the CMake project is always the
root project - which can rarely be guaranteed.

In all honesty, CMake should deprecate and eventually remove
CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches
and confusion for years, they're rarely useful over
CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR,
and they cause a lot of confusing configuration and source
code layouts to boot.

Any time they are used, they break `add_subdirectory()` almost 100% of
the time, cause confusing error messages, and hide subtle bugs.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR</title>
<updated>2021-11-22T14:27:59+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-19T13:48:08+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=84083dcc8bd41332ccac9d7b537f3e254d79011c'/>
<id>84083dcc8bd41332ccac9d7b537f3e254d79011c</id>
<content type='text'>
Instead of using the project-specific `libgit2_SOURCE_DIR` and
`libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and
`CMAKE_BINARY_DIR`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of using the project-specific `libgit2_SOURCE_DIR` and
`libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and
`CMAKE_BINARY_DIR`.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: stylistic refactoring</title>
<updated>2021-10-18T12:30:14+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-09-27T03:11:13+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=52693ab44efe33d9340038c3936b9e75a70fe7bb'/>
<id>52693ab44efe33d9340038c3936b9e75a70fe7bb</id>
<content type='text'>
Ensure that we always use lowercase function names, and that we do not
have spaces preceding open parentheses, for consistency.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ensure that we always use lowercase function names, and that we do not
have spaces preceding open parentheses, for consistency.
</pre>
</div>
</content>
</entry>
<entry>
<title>docs: clarify and include licenses of dependencies</title>
<updated>2018-08-30T10:16:59+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2018-08-30T10:16:40+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=2e0f926e1cf1bad7a1d20277e0ce43a3b782d13f'/>
<id>2e0f926e1cf1bad7a1d20277e0ce43a3b782d13f</id>
<content type='text'>
While our contribution guide tries to make clear the licenses that apply
to libgit2, it does not make clear that different licenses apply to our
bundled dependencies. Make this clear by listing each dependency
together with the licenses that they are governed by. Furthermore,
bundle the complete license texts next to the code they apply to.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
While our contribution guide tries to make clear the licenses that apply
to libgit2, it does not make clear that different licenses apply to our
bundled dependencies. Make this clear by listing each dependency
together with the licenses that they are governed by. Furthermore,
bundle the complete license texts next to the code they apply to.
</pre>
</div>
</content>
</entry>
<entry>
<title>mingw: update TLS option flags</title>
<updated>2018-02-27T11:22:34+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2018-02-27T10:32:29+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=8c8db98078b97404cb731e53bd02c9dab3b89d7c'/>
<id>8c8db98078b97404cb731e53bd02c9dab3b89d7c</id>
<content type='text'>
Include the constants for `WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_1` and
`WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_2` so that they can be used by mingw.

This updates both the `deps/winhttp` framework (for classic mingw) and
adds the defines for mingw64, which does not use that framework.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Include the constants for `WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_1` and
`WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_2` so that they can be used by mingw.

This updates both the `deps/winhttp` framework (for classic mingw) and
adds the defines for mingw64, which does not use that framework.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: use project-relative binary and source directories</title>
<updated>2017-10-20T05:38:34+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2017-10-20T05:29:17+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=4da74c83e4263bb2d62c85af6188d223fd0157d6'/>
<id>4da74c83e4263bb2d62c85af6188d223fd0157d6</id>
<content type='text'>
Due to our split of CMake files into multiple modules, we had to replace
some uses of the `${CMAKE_CURRENT_SOURCE_DIR}` and
`${CMAKE_CURRENT_BINARY_DIR}` variables and replace them with
`${CMAKE_SOURCE_DIR}` and `${CMAKE_BINARY_DIR}`. This enabled us to
still be able to refer to top-level files when defining build
instructions inside of a subdirectory.

When replacing all variables, it was assumed that the absolute set of
variables is always relative to the current project. But in fact, this
is not the case, as these variables always point to the source and
binary directory as given by the top-levl project. So the change
actually broke the ability to include libgit2 directly as a subproject,
as source files cannot be found anymore.

Fix this by instead using project-specific source and binary directories
with `${libgit2_SOURCE_DIR}` and `${libgit2_BINARY_DIR}`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Due to our split of CMake files into multiple modules, we had to replace
some uses of the `${CMAKE_CURRENT_SOURCE_DIR}` and
`${CMAKE_CURRENT_BINARY_DIR}` variables and replace them with
`${CMAKE_SOURCE_DIR}` and `${CMAKE_BINARY_DIR}`. This enabled us to
still be able to refer to top-level files when defining build
instructions inside of a subdirectory.

When replacing all variables, it was assumed that the absolute set of
variables is always relative to the current project. But in fact, this
is not the case, as these variables always point to the source and
binary directory as given by the top-levl project. So the change
actually broke the ability to include libgit2 directly as a subproject,
as source files cannot be found anymore.

Fix this by instead using project-specific source and binary directories
with `${libgit2_SOURCE_DIR}` and `${libgit2_BINARY_DIR}`.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: move winhttp build instructions into subdirectory</title>
<updated>2017-08-16T05:12:38+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2017-06-28T11:21:09+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=432485001593d25c6900acbd17f089e056ce91d2'/>
<id>432485001593d25c6900acbd17f089e056ce91d2</id>
<content type='text'>
Extract code required to build the winhttp library into its own
CMakeLists.txt, which is included as required.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extract code required to build the winhttp library into its own
CMakeLists.txt, which is included as required.
</pre>
</div>
</content>
</entry>
<entry>
<title>Correct line endings on winhttp.def</title>
<updated>2015-06-10T20:36:38+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@microsoft.com</email>
</author>
<published>2015-06-10T20:36:38+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=4f0f2b8473e06818e62ba05f3e88deeb2a498589'/>
<id>4f0f2b8473e06818e62ba05f3e88deeb2a498589</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>use a different .def file for 64 bit</title>
<updated>2015-03-16T21:59:20+00:00</updated>
<author>
<name>Tony Kelman</name>
<email>tony@kelman.net</email>
</author>
<published>2015-03-16T21:49:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=547517d7f9c7519681c67eb89cb6343a4457eb27'/>
<id>547517d7f9c7519681c67eb89cb6343a4457eb27</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>patch so mingw-w64 can build</title>
<updated>2015-03-16T20:59:02+00:00</updated>
<author>
<name>klutzy</name>
<email>klutzytheklutzy@gmail.com</email>
</author>
<published>2015-03-16T19:46:33+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=e613e6ebb830137bb8d61ab350b0ba622d27c819'/>
<id>e613e6ebb830137bb8d61ab350b0ba622d27c819</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
