delta/libgit2.git/src/futils.h, branch ethomson/treebuilder_write github.com: libgit2/libgit2.git futils: fix order of declared parameters for `git_futils_fake_symlink` 2020-05-12T19:37:18+00:00 Patrick Steinhardt ps@pks.im 2020-05-12T19:35:07+00:00 a2eca682825523df8a03119ccd319519b52d341f While the function `git_futils_fake_symlink` is declared with arguments `new, old`, the implementation uses the reverse order `old, new`. Let's fix the ordering issues to be `new, old` for both, which matches what symlink(3P) has. While at it, we also rename these parameters: `old` and `new` doesn't really make a lot of sense in the context of symlinks, which is why this commit renames them to be called `target` and `path`. 
While the function `git_futils_fake_symlink` is declared with arguments
`new, old`, the implementation uses the reverse order `old, new`. Let's
fix the ordering issues to be `new, old` for both, which matches what
symlink(3P) has. While at it, we also rename these parameters: `old` and
`new` doesn't really make a lot of sense in the context of symlinks,
which is why this commit renames them to be called `target` and `path`.
mmap: use a 64-bit signed type `off64_t` for mmap 2019-11-25T02:18:28+00:00 Edward Thomson ethomson@edwardthomson.com 2019-06-23T16:09:22+00:00 8be12026a158f0836c73f6b9f33abab640d9a115 Prefer `off64_t` to `git_off_t` for internal visibility. 
Prefer `off64_t` to `git_off_t` for internal visibility.
filestamp: use `uint64_t` for object size 2019-11-22T04:18:54+00:00 Edward Thomson ethomson@edwardthomson.com 2019-11-22T04:18:54+00:00 6c13cf6dacf5f5f2f5ba4f28b3632f3f9df29b7c Instead of using a signed type (`off_t`) use an unsigned `uint64_t` for the size of the files. 
Instead of using a signed type (`off_t`) use an unsigned `uint64_t` for
the size of the files.
futils_filesize: use `uint64_t` for object size 2019-11-22T04:13:05+00:00 Edward Thomson ethomson@edwardthomson.com 2019-06-23T15:23:59+00:00 fb2198db6b48ce3c5e3cecaa03ecb179c5a02382 Instead of using a signed type (`off_t`) use `uint64_t` for the maximum size of files. 
Instead of using a signed type (`off_t`) use `uint64_t` for the maximum
size of files.
fileops: rename to "futils.h" to match function signatures 2019-07-20T17:11:20+00:00 Patrick Steinhardt ps@pks.im 2019-06-29T07:17:32+00:00 e54343a4024e75dfaa940e652c2c9799d33634b2 Our file utils functions all have a "futils" prefix, e.g. `git_futils_touch`. One would thus naturally guess that their definitions and implementation would live in files "futils.h" and "futils.c", respectively, but in fact they live in "fileops.h". Rename the files to match expectations. 
Our file utils functions all have a "futils" prefix, e.g.
`git_futils_touch`. One would thus naturally guess that their
definitions and implementation would live in files "futils.h" and
"futils.c", respectively, but in fact they live in "fileops.h".

Rename the files to match expectations.