<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/src/ignore.c, branch ethomson/codespaces</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/'/>
<entry>
<title>str: introduce `git_str` for internal, `git_buf` is external</title>
<updated>2021-10-17T13:49:01+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-09-07T21:53:49+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=f0e693b18afbe1de37d7da5b5a8967b6c87d8e53'/>
<id>f0e693b18afbe1de37d7da5b5a8967b6c87d8e53</id>
<content type='text'>
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
</pre>
</div>
</content>
</entry>
<entry>
<title>attr_file: don't take the `repo` as an arg</title>
<updated>2021-09-26T21:46:07+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-09-26T15:28:47+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=46508fe64737c2fe71d9e3221c56fbe0fae6996c'/>
<id>46508fe64737c2fe71d9e3221c56fbe0fae6996c</id>
<content type='text'>
The `repo` argument is now unnecessary.  Remove it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `repo` argument is now unnecessary.  Remove it.
</pre>
</div>
</content>
</entry>
<entry>
<title>attr: include the filename in the attr source</title>
<updated>2021-07-22T19:08:50+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-05-24T12:44:45+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=1cd863fd16a60517d2e42402c69238bf03b5dae0'/>
<id>1cd863fd16a60517d2e42402c69238bf03b5dae0</id>
<content type='text'>
The attribute source object is now the type and the path.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The attribute source object is now the type and the path.
</pre>
</div>
</content>
</entry>
<entry>
<title>attr: rename internal attr file source enum</title>
<updated>2021-07-22T19:08:50+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-05-22T17:47:03+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=5ee5048841b514e80695a2ec5d19cb1ad34eeffa'/>
<id>5ee5048841b514e80695a2ec5d19cb1ad34eeffa</id>
<content type='text'>
The enum `git_attr_file_source` is better suffixed with a `_t` since
it's a type-of source.  Similarly, its members should have a matching
name.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The enum `git_attr_file_source` is better suffixed with a `_t` since
it's a type-of source.  Similarly, its members should have a matching
name.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5824 from palmin/fix-ignore-negate</title>
<updated>2021-07-14T12:39:24+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-07-14T12:39:24+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=84ce9746ae0699d61fc1c57ccec4887d98e1dfc1'/>
<id>84ce9746ae0699d61fc1c57ccec4887d98e1dfc1</id>
<content type='text'>
fix check for ignoring of negate rules</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
fix check for ignoring of negate rules</pre>
</div>
</content>
</entry>
<entry>
<title>Apply suggestions from code review</title>
<updated>2021-06-14T23:22:30+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2021-06-14T23:22:30+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=6d2a6f3e06a2d0468c89ed4c2efced58434a8735'/>
<id>6d2a6f3e06a2d0468c89ed4c2efced58434a8735</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update src/ignore.c</title>
<updated>2021-06-13T06:21:05+00:00</updated>
<author>
<name>Anders Borum</name>
<email>palmin@users.noreply.github.com</email>
</author>
<published>2021-06-13T06:21:05+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=8cad7e62cdbe13d41dbced7088a508366b416d6b'/>
<id>8cad7e62cdbe13d41dbced7088a508366b416d6b</id>
<content type='text'>
Co-authored-by: lhchavez &lt;lhchavez@lhchavez.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Co-authored-by: lhchavez &lt;lhchavez@lhchavez.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>Update src/ignore.c</title>
<updated>2021-06-13T06:20:59+00:00</updated>
<author>
<name>Anders Borum</name>
<email>palmin@users.noreply.github.com</email>
</author>
<published>2021-06-13T06:20:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=9410f2b52e3b56ec3c0571417b88d2a700c76558'/>
<id>9410f2b52e3b56ec3c0571417b88d2a700c76558</id>
<content type='text'>
Co-authored-by: lhchavez &lt;lhchavez@lhchavez.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Co-authored-by: lhchavez &lt;lhchavez@lhchavez.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>ignore: validate workdir paths for ignore files</title>
<updated>2021-04-28T12:03:34+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-04-04T19:46:40+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=289aaa414b4d31a0a2412c0395ff7053cef1ccff'/>
<id>289aaa414b4d31a0a2412c0395ff7053cef1ccff</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>attr: validate workdir paths for attribute files</title>
<updated>2021-04-28T12:03:34+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-04-04T18:59:57+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=9fb755d561e149b81950c7cc7d8cb5131b24079b'/>
<id>9fb755d561e149b81950c7cc7d8cb5131b24079b</id>
<content type='text'>
We should allow attribute files - inside working directories - to have
names longer than MAX_PATH when core.longpaths is set.
`git_attr_path__init` takes a repository to validate the path with.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should allow attribute files - inside working directories - to have
names longer than MAX_PATH when core.longpaths is set.
`git_attr_path__init` takes a repository to validate the path with.
</pre>
</div>
</content>
</entry>
</feed>
