delta/libgit2.git/src/libgit2/transports/httpclient.c, branch main github.com: libgit2/libgit2.git http: Update httpclient options when reusing an existing connection. 2022-10-20T01:04:56+00:00 Sebastian Lackner sebastian.lackner@sysmagine.com 2022-10-06T03:04:38+00:00 f8683b7a93c54db3df510fbb8593082c2667bfcd Httpclient internally stores a copy of the certificate_check callback and payload. When connecting via HTTPS, and if the server sends back "Connection: close" after the first request, the following request would attempt to re-use the httpclient and call the (now outdated) callback. In particular for pygit2 this is a problem, since callbacks / payloads are only valid for the duration of a libgit2 call, leading to a ffi.from_handle() error and crashing the Python interpreter. 
Httpclient internally stores a copy of the certificate_check callback and
payload. When connecting via HTTPS, and if the server sends back
"Connection: close" after the first request, the following request would
attempt to re-use the httpclient and call the (now outdated) callback. In
particular for pygit2 this is a problem, since callbacks / payloads are only
valid for the duration of a libgit2 call, leading to a ffi.from_handle()
error and crashing the Python interpreter.
http: skip processing when body is null or 0 length 2022-02-27T15:02:05+00:00 Edward Thomson ethomson@edwardthomson.com 2022-02-27T15:02:05+00:00 241d838f4878c251290291be1fb847cc6c6cbd03 Mistakenly `&&` when we should have `||`d. 
Mistakenly `&&` when we should have `||`d.
refactor: `src` is now `src/libgit2` 2022-02-23T03:07:44+00:00 Edward Thomson ethomson@edwardthomson.com 2021-11-14T13:47:40+00:00 ef4ab2988320005cbcb3db920e6b41f10b3c60cf